Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764123AbXHOJ7b (ORCPT ); Wed, 15 Aug 2007 05:59:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754081AbXHOJ7V (ORCPT ); Wed, 15 Aug 2007 05:59:21 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:39590 "EHLO the-village.bc.nu" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751410AbXHOJ7T (ORCPT ); Wed, 15 Aug 2007 05:59:19 -0400 Date: Wed, 15 Aug 2007 11:06:54 +0100 From: Alan Cox To: Sonic Zhang Cc: Linux IDE , Linux Kernel , Jeff Garzik Subject: Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller. Message-ID: <20070815110654.360cc210@the-village.bc.nu> In-Reply-To: <1187169256.31383.3.camel@sevens.analog.com> References: <1187169256.31383.3.camel@sevens.analog.com> X-Mailer: Claws Mail 2.10.0 (GTK+ 2.10.14; i386-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 20 On Wed, 15 Aug 2007 17:14:15 +0800 Sonic Zhang wrote: > Update: > 1. Condition branch code instead of while loop from Alan Cox. > 2. Condtinue in PIO mode after failing to request DMA. > > Signed-off-by: Sonic Zhang Acked-by: Alan Cox Minor stuff like consts can go in later as a tidy up. Also the big chunk of work to improve this driver (removing a lot of shared reset/probe code) needs libata changes and will be easier to do after not before merge - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/