Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH 1/1] i2c: designware: add pinctrl for recovery info as an option
Message-ID: <806e1787-1f6d-7551-52fd-2e1e25aebaef@amazon.com>
Date:   Wed, 14 Dec 2022 15:43:28 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <jarkko.nikula@linux.intel.com>, <mika.westerberg@linux.intel.com>,
        <jsd@semihalf.com>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dwmw@amazon.co.uk>,
        <benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>,
        <jonnyc@amazon.com>, <hanochu@amazon.com>, <farbere@amazon.com>,
        <itamark@amazon.com>
References: <20221214102707.60018-1-hhhawa@amazon.com>
 <Y5m2nux5Q1npXAo+@smile.fi.intel.com>
Content-Language: en-US
From:   "Hawa, Hanna" <hhhawa@amazon.com>
In-Reply-To: <Y5m2nux5Q1npXAo+@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/14/2022 1:42 PM, Andy Shevchenko wrote:
> Can you explain, why pinctrl_bind_pins() is not enough?
> 
> (You may also refer to the ab78029ecc34 ("drivers/pinctrl: grab default handles
>   from device core") for more details.)

Thanks for your reviewing and pointing to this function.

No need to recall the devm_pinctrl_get() during the i2c probe, as the 
pinctrl_bind_pins() is enough to init the pinctrl struct. But still need 
to set the rinfo->pinctrl with dev->pins->p, will upload new patchset.

The change will look like:

@@ -832,6 +833,9 @@ static int i2c_dw_init_recovery_info(struct 
dw_i2c_dev *dev)
         struct i2c_adapter *adap = &dev->adapter;
         struct gpio_desc *gpio;

+       if (dev->dev->pins && dev->dev->pins->p)
+               rinfo->pinctrl = dev->dev->pins->p;
+
         gpio = devm_gpiod_get_optional(dev->dev, "scl", GPIOD_OUT_HIGH);
         if (IS_ERR_OR_NULL(gpio))
                 return PTR_ERR_OR_ZERO(gpio);

Thanks,
Hanna