Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 14:19:43 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Lukasz Majewski <lukma@denx.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Stephen Kitt <steve@sk2.org>, patches@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: wm8940: Mute also the speaker output
Message-ID: <Y5nbf72ksywcXK65@sirena.org.uk>
References: <20221214123743.3713843-1-lukma@denx.de>
 <20221214123743.3713843-4-lukma@denx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6/ZnCXYOB14izKmh"
Content-Disposition: inline
In-Reply-To: <20221214123743.3713843-4-lukma@denx.de>
Precedence: bulk


--6/ZnCXYOB14izKmh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 14, 2022 at 01:37:42PM +0100, Lukasz Majewski wrote:
> Without this change the BTL speaker produces some
> "distortion" noise when test program
> (speaker-test -t waw) is ended with ctrl+c.

> As our design uses speaker outputs to drive BTL speaker,
> it was necessary to also mute the speaker via the codec
> internal WM8940_SPKVOL register with setting
> WM8940_SPKMUTE bit.

> @@ -465,9 +465,18 @@ static int wm8940_mute(struct snd_soc_dai *dai, int =
mute, int direction)
>  {

> +	spkvol_reg &=3D ~WM8940_SPKMUTE;
> +	if (mute) {
>  		mute_reg |=3D 0x40;
> +		spkvol_reg |=3D WM8940_SPKMUTE;
> +	}
> +
> +	ret =3D snd_soc_component_write(component, WM8940_SPKVOL, spkvol_reg);
> +	if (ret)
> +		return ret;
> =20
>  	return snd_soc_component_write(component, WM8940_DAC, mute_reg);

In addition to the issue Charles raised this is simply not what the mute
callback should do, the mute callback should specifically mute the
digital input (with the goal of masking any glitching on there while
clocks are started/stopped).  Looking at the driver the device supports
analogue bypass paths to the speaker - these will be broken by your
patch so if you genuinely need some workaround in this area I'd be
looking at the Speaker Mixer PCM Playback Switch rather than muting the
speaker as a whole.  If the device just can't cope without an input then
ignore_mdown_time might be what you're looking for, it looks like the
device doesn't have any lengthy sleeps in the power up/down paths so
that should be fine so long as it doesn't pop/click.

I'd also check there's not some other system configuration issue here
which is more obvious when the input from the DAC stops getting input,
check that you don't see similar issues when silence is played for
example.  It might be worth checking that none of the analogue bypass
paths are enabled.

--6/ZnCXYOB14izKmh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOZ238ACgkQJNaLcl1U
h9BgmAf/WFppJCmZ/1kHJn/v0qAcUP8bEn0HUM+iMjhzmkLvqvnXswGGEfsHWWkW
fagQVLQQBHDDzZWKP4ziGtKIfRyiut0gVlccgLR54UrBjkXGtl+DcgAjiAB8iyLm
FkD+JG2PnU+39oBYK8LGcUb9cZj8H+szHlRqzdW4AB/rSyRtU9VujPvU78HSQCIr
bL6ZBqdFwv5IfbThyp26AC20e3GqXpebEiJJTbSJbRr7wKsqTAKJKtJeWl2KZLQL
Lyry6wMHzbAei1vl2U3BOoPCVQ0M4zlnz4o6aOfVE9yna/fplZZttJsbYyLwx6jl
Z/SA7YiEJZB2VQXDc3wJN9ay2QnORQ==
=BDk1
-----END PGP SIGNATURE-----

--6/ZnCXYOB14izKmh--