Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92358ff1-86ca-76b0-c4f3-3d4e0dddc80a@redhat.com>
Date:   Wed, 14 Dec 2022 16:42:34 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH] Add HP Stream 8 to bytcr_rt5640.c
Content-Language: en-US, nl
To:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Moises Cardona <moisesmcardona@gmail.com>,
        cezary.rojewski@intel.com
Cc:     liam.r.girdwood@linux.intel.com, peter.ujfalusi@linux.intel.com,
        yung-chuan.liao@linux.intel.com, ranjani.sridharan@linux.intel.com,
        kai.vehmanen@linux.intel.com, broonie@kernel.org, perex@perex.cz,
        tiwai@suse.com, oder_chiou@realtek.com, akihiko.odaki@gmail.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
References: <20221213173550.1567875-1-moisesmcardona@gmail.com>
 <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com>
From:   Hans de Goede <hdegoede@redhat.com>
In-Reply-To: <08403fff-359b-b5f4-d039-18eeef660637@linux.intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 12/13/22 20:04, Pierre-Louis Bossart wrote:
> 
> 
> On 12/13/22 11:35, Moises Cardona wrote:
>> The HP Stream 8 tablet is identical to the HP Stream 7 in terms of the PCB,
>> with the exception of the added SIM Card Slot. 
>> Therefore, I'm submitting this patch which properly initializes the audio 
>> and enables the headphone jack to work, just like it does in the 
>> HP Stream 7.
>>
>> Signed-off-by: Moises Cardona <moisesmcardona@gmail.com>
> 
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Note this is the old version which wrongly contains the
BYT_RT5640_MONO_SPEAKER flag.

Mark, please merge the new version (which unfortunately
was not marked as v2) which correctly drops
the BYT_RT5640_MONO_SPEAKER flag.

(this tablet has 2 speakers so it should not have the mono flag)

Regards,

Hans


> 
>> ---
>>  sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
>> index fb9d9e271845..1d964b1ceff4 100644
>> --- a/sound/soc/intel/boards/bytcr_rt5640.c
>> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
>> @@ -796,6 +796,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>>  					BYT_RT5640_SSP0_AIF1 |
>>  					BYT_RT5640_MCLK_EN),
>>  	},
>> +	{	/* HP Stream 8 */
>> +		.matches = {
>> +			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),
>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "HP Stream 8 Tablet"),
>> +		},
>> +		.driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
>> +					BYT_RT5640_MONO_SPEAKER |
>> +					BYT_RT5640_JD_NOT_INV |
>> +					BYT_RT5640_SSP0_AIF1 |
>> +					BYT_RT5640_MCLK_EN),
>> +	},
>>  	{	/* I.T.Works TW891 */
>>  		.matches = {
>>  			DMI_EXACT_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."),
>