Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1382280rwb; Wed, 14 Dec 2022 09:28:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf5WosMWDbBCmN7Dg62KO4xw2n4SMq0TjFq1KTYmNDmZ7gtjzkbc+aGGHGqFmACUAMeOaFKM X-Received: by 2002:a05:6a20:d687:b0:a3:5124:c98d with SMTP id it7-20020a056a20d68700b000a35124c98dmr32310408pzb.53.1671038931039; Wed, 14 Dec 2022 09:28:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671038931; cv=none; d=google.com; s=arc-20160816; b=RufcSTBjyHqQQDu7Wz58ttXnQkCTcFB6mlh5upQaB+NchVmqrQI0l5RUkENmw/CNuz xfECXZACodjJM+f4NukJKpOl++hnGNxv19W1OeGkmR7viU27mDiVZHMfzLw4jaCLc0X0 zA+JkxPOga83ebL+t+kmWgKL+jVJVKtcDI75eO7dkay1JO6BtBcurce7s99EwQybbv8F kl6BYL+6ZFy38ryrLL2IcDAzl5BW4MdjlB/vbQ+2rvqYF+hYsbws1+PSKu4/HdZZWZQg oe+BJdrsmo0hLlR7MpjuFXV9lZqA6iUPoTjq1A/Gq3xD3fcF3QQmDZCez4r0SJK1x8Ct yorw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LUIcL+YXbcbzvkfJ4G0OlJ2uFHW1TivRGIOqxGEv0/8=; b=yvXDkDTUfVvnjUqsPpKkpwkvFnU9eGlsUeA1C+pwtwrq8uJoCoTa6j7Q4nYzveBGd9 c9+uxxKCkhQyGFlHFcKTZqlMLb0mpX34Umo3MDYpULqg3ZX/hDn1i/23ii69Z503OGn9 CIKH2BVE1UIXlP1vHDNRafWi4X0gOi3ddR2eZk6Pg08Kltenis0r5gbTaPUUnqZXTSrB 3WIXCsAuRG1qGRemOiFhCd1Xc5HZjOfKUyWd0firIh7vsts1jT9HbfCDDtWTiJlJ5UZv nztWUdNzwlwbZmrthVUwceUQR9JrQxZAAUWHCQFOz9w+ov7nhgLr4by+Msi909NjjDoM WUgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=gSAfY5dd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a65580e000000b00478c967a84esi238765pgr.748.2022.12.14.09.28.41; Wed, 14 Dec 2022 09:28:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=gSAfY5dd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229649AbiLNQoa (ORCPT + 70 others); Wed, 14 Dec 2022 11:44:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239092AbiLNQoY (ORCPT ); Wed, 14 Dec 2022 11:44:24 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ABE81A3BA; Wed, 14 Dec 2022 08:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LUIcL+YXbcbzvkfJ4G0OlJ2uFHW1TivRGIOqxGEv0/8=; b=gSAfY5ddPi2TwSDSFkf0Y9QKWA n7BBpDDTJRFtjZrMHyZm1SvSOv/lQ+TQfLeCEehgDrTmx0nmQNfhdmaxTzGjhe4NH6QtEzTZ92DfM X/u9rC16spIa4Fr9n23l6a+DMwUuYmQP8d2pRI+NiN3ceG15HE1AtxJQ7xysLWBjg0jt6un25NBJ2 D5Dyt9HsIFn2IrIYN2zg7HQTGLJs5/Fgr4PVtKPUJvSZ7J/CrH0YpwYl6YAN8QASt7ZkwWBRhZHn4 DEj4taU/2obMToxaNl7qFEUCsBG6tK8t94KFtM2WCOW3Qe07fj/00npp0Xhw194enMECXgJflWaA6 o7VsnK4Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5Urj-000mR8-56; Wed, 14 Dec 2022 16:44:19 +0000 Date: Wed, 14 Dec 2022 08:44:19 -0800 From: Christoph Hellwig To: Daniel Golle Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig , Richard Weinberger , Matthew Wilcox , Jens Axboe , "Martin K. Petersen" , Chaitanya Kulkarni , Wolfram Sang Subject: Re: [RFC PATCH 1/2] init: move block device helpers from init/do_mounts.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2022 at 12:45:42PM +0000, Daniel Golle wrote: > In init/do_mounts.c there are helper functions devt_from_partuuid, > devt_from_partlabel and devt_from_devname. In order to make these > functions available to other users, move them to block/bdev.c. NAK. As pointed out many times there should be no more users. These functions are a horrible hack forthe pre-initramfs boot code and should not grow any additional users.