Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1390327rwb; Wed, 14 Dec 2022 09:34:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf5gQk0QRU7RxzCcGxLy2JoM4CeMNshhTRtU7jrh7MMbakkEGOMAmUIOrXEarLySIiFvViIc X-Received: by 2002:a05:6a20:a68f:b0:ad:6305:a4 with SMTP id ba15-20020a056a20a68f00b000ad630500a4mr21895464pzb.48.1671039267740; Wed, 14 Dec 2022 09:34:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671039267; cv=none; d=google.com; s=arc-20160816; b=0oQ6NUzVg15Iv/LiZLS2z+8gxmb0cQRCGd+lNbtg97cc0W29u50JEc1Bsgrt/uy5hL h5gCamRUEuCHFksqtZx4J41uf0i3jj0bRMS9iRmtRjM7xFeqVcF5pK7WhN1jRIIUBc66 WLFMEXnYQ1Pl4Gs2euh+uyLBGgUCndU6ce5pvfMU58LS0zEmDEuiDZS0vKb2t7Cwqttn 3saWKL9x0+07lvr+E3ceFlAxghK5cPQ2eqbVTp30CJpi1jJ4jZRSvJePqnzRsAydmYIg KJw794bkflDLvO2KjMzjFf9zsMpeBzYbkrSoIaOFPq5c8rZFevLMNIZDOLo7qvVZDMzx 1LoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=LbDNBydaewl5dltimDBqmtpJAJq+VfTZXoANK7KfgaM=; b=Ivu90SqHcXgU5O/17btcMU2CCYQuPlo5JXoaH6FMx4m9qgAg7rBg3pNr9raVC9kD6p tutCtRW57izz3+wOd0t+8Ft9QKA7+GZiZ6wee1GrbWQ40ywBnFtsxoc5sV2pC/rgeRVX ki8I6VBVXsStrZ7WL8Dl5JHhkCv0eBmHx6QbkXSTr+S2xy1fhJo4ml4BoHebNyFhABeV ihSr/8N15bbznshNUPP4oR9J/DzA3fNSJEbC7iLsFJT+kmFEVZhrvwKuDfVvd9zDxNe8 ceMKyoOXGJtAkcmuEt4TsjIJypdCURoBAjvMCB1L5Tir+1m1VVJaKntUgCD8LglJwCll n/QQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="FfGyrKw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q12-20020a170902c9cc00b001870a181f24si3018253pld.222.2022.12.14.09.34.18; Wed, 14 Dec 2022 09:34:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="FfGyrKw/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239046AbiLNQjK (ORCPT + 69 others); Wed, 14 Dec 2022 11:39:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238629AbiLNQjH (ORCPT ); Wed, 14 Dec 2022 11:39:07 -0500 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB5E5FDD for ; Wed, 14 Dec 2022 08:39:06 -0800 (PST) Received: by mail-pg1-x530.google.com with SMTP id 79so2330358pgf.11 for ; Wed, 14 Dec 2022 08:39:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LbDNBydaewl5dltimDBqmtpJAJq+VfTZXoANK7KfgaM=; b=FfGyrKw/pmdyACIFzyBjx3+I1RbAhXpY1KnMvcvd+IcY08hb1o4LUYI2jEIuzO+mFU IgAhBi3hP4RrTENiY/AvN82n/S44+iEqYaPvULsrJ9dxTtrbC/XbDwJFSvm5WCy2qF6i 0OIdfwcoq7wp6CwHFi6W5FtXCOO4Glo8XLi1g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LbDNBydaewl5dltimDBqmtpJAJq+VfTZXoANK7KfgaM=; b=qxiiZXbfgSaUVoT53e2qOyaslnHbUtEMXAeHFuirWmPUq8+/gYXj2AC2SLax7VxTug 0NY26nZvN5psPMqJfvdBKosZyQOwBN0mv1+ssV4xiysnJ0DPLPWkvabSh489JTuwMKBQ FfxSiN907CU9zAlfcw6STK7Sew53oGRBYKvcMwExA6wl6btAwkTwElVo5is5snS63Tl4 ylk+laplGwcHAAHTBIsQ5yJhwO6+gQcbJep27PkxVKT9hJ1SHcOTGgLa+HUiWV6YCFc+ sLldfKLKTOS3EwyngSwcVKA6R/jzHd/nXb3wuq0RWH4499Iuwn6ptHClauLj5plsu0U5 9VYQ== X-Gm-Message-State: AFqh2kqui4734h2uoOxZJoj0NjF2ZukKgr2GmzUHZhNUVtwib+zDIOBE x2PmMZpkaoOTnIGr/RSAhbpbVivgUkhTaKFwW0Q= X-Received: by 2002:a62:388d:0:b0:57c:c79e:2a41 with SMTP id f135-20020a62388d000000b0057cc79e2a41mr2715579pfa.1.1671035945521; Wed, 14 Dec 2022 08:39:05 -0800 (PST) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com. [209.85.214.172]) by smtp.gmail.com with ESMTPSA id k201-20020a6284d2000000b00576f9773c81sm59534pfd.211.2022.12.14.08.39.03 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 08:39:04 -0800 (PST) Received: by mail-pl1-f172.google.com with SMTP id l10so3891062plb.8 for ; Wed, 14 Dec 2022 08:39:03 -0800 (PST) X-Received: by 2002:a17:902:ce04:b0:174:af35:4b90 with SMTP id k4-20020a170902ce0400b00174af354b90mr79455890plg.8.1671035943448; Wed, 14 Dec 2022 08:39:03 -0800 (PST) MIME-Version: 1.0 References: <20221212-uvc-race-v3-0-954efc752c9a@chromium.org> In-Reply-To: From: Ricardo Ribalda Date: Wed, 14 Dec 2022 17:38:52 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3] media: uvcvideo: Fix race condition with usb_kill_urb To: Laurent Pinchart Cc: Mauro Carvalho Chehab , Sergey Senozhatsky , Max Staudt , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yunke Cao , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Laurent On Wed, 14 Dec 2022 at 14:30, Laurent Pinchart wrote: > > > Isn't this still racy ? > > > > Indeed... > > > > I could add a mutex just for flush_status > > > > what do you think? > > It may be possible to avoid that. I'm giving it a try. Just sent a new version without lock... -- Ricardo Ribalda