Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1391968rwb; Wed, 14 Dec 2022 09:35:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf4PQCeJ0g5MWWDpxXqJLDCj8+fFoUOIGH/DQUdgiBGInHu83asYRhN1V3aMiY6BIFwDFJ75 X-Received: by 2002:a17:906:ae56:b0:7c0:b569:8efe with SMTP id lf22-20020a170906ae5600b007c0b5698efemr19869363ejb.60.1671039335924; Wed, 14 Dec 2022 09:35:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671039335; cv=none; d=google.com; s=arc-20160816; b=zoi0gr8odzfvIa5C7gGFdBrCyElrBO+zhUT0zrredjMX0mqEbPbiujEsK3GeVoKw8A 2whBKeb7JKFPaJnm6RucxvxB4B1Ah8pwxKAGGyXZ5WIdoINMfcwOk19zPYIe8K1Pupoe fLxKy+2ZH0n2ci+ErOpCxuc5waSAiprpKuooY7ug0p0v9avbpW0tJuxeHeQuWyYZECtP lEnZTPKtdsWNpG13sAVCONwNZ0J24nXxgKW7nGAfl+9GQLmbkmyotalYDsriA5qqVKMZ A7zJFRBfi3+QAtjhjqz9op69IFIDwz31GaDZfGqPsOuMRtKIsPx/r5xX0cqOeiYB8Vfp hxog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nHnR4TkuzOchBDqf1SuiCAx95osqwKJzT394UY/Kto8=; b=D9vhRHczx6qdoDohwjurq464kwGcmkHCwE17a5qgTnvFrAZ4j1IbiAbPt8xmtnan+o LcNqat9OOI9zTJ0myynsVxAwEQSCos+kv/IypIzbG9ck2bQPIAK9w+4YG/suDTKSasC8 DQqV2p3OMP8VU4klQMaWmN4VdeJPb+kWitQZB0hzClCuS9Xk7ZlQuNMPAkHnMCMP90Gf 5F/b2ZsMZ9k8LwzHAzDu8NjtfMcRx7C+359gs0ASWQ4efJvOMNlL6pyjmU212XU4avF8 NEjbj22cgmqu5otvn0cqVDwT2C53UXbTBo5JJrB5hrpdruzidc751EpR1z6zVCqXowH+ 9Wug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iol2eLvj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hd34-20020a17090796a200b007c4fb1332c0si695070ejc.174.2022.12.14.09.35.19; Wed, 14 Dec 2022 09:35:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iol2eLvj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239160AbiLNQvT (ORCPT + 69 others); Wed, 14 Dec 2022 11:51:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239127AbiLNQvJ (ORCPT ); Wed, 14 Dec 2022 11:51:09 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12BC01649F; Wed, 14 Dec 2022 08:51:09 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9373061B4B; Wed, 14 Dec 2022 16:51:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7ED2AC433EF; Wed, 14 Dec 2022 16:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671036668; bh=nHnR4TkuzOchBDqf1SuiCAx95osqwKJzT394UY/Kto8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iol2eLvjBWZ+W6QY9+1Jx/OqQjcfLN00qRbpc6OOd/aLvBqEz8o6exVl2LR0diXw8 0/ReEYLvVaAvNTGaZYFVedcI4fmqeUxidcqMt1zzqTI9eAkRDlfCwv3i2Ha6VsoHTr AphYVG+PVFvXbQMFgSCX/vO79jx/eQyCMiPo2EEEP+atpeVM7W4CbIzIs0zl912kzH ebT4P+cOJvixzId0/Y52KvTgNLtWZ7e8sqX/gEzMoTjeBaNlj2Jig5VWTrf7fXp2vF rLFJ3sYcwojy0CuxuCw1jUhIkHPgu82IkPhxLmPpnV84KIw/VauvtlSYGN+tklM3gr ptv4hS4SwvP8A== Date: Wed, 14 Dec 2022 08:51:06 -0800 From: Jakub Kicinski To: Leon Romanovsky Cc: Lixue Liang , anthony.l.nguyen@intel.com, linux-kernel@vger.kernel.org, jesse.brandeburg@intel.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, lianglixue@greatwall.com.cn Subject: Re: [PATCH v7] igb: Assign random MAC address instead of fail in case of invalid one Message-ID: <20221214085106.42a88df1@kernel.org> In-Reply-To: References: <20221213074726.51756-1-lianglixuehao@126.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Dec 2022 09:22:13 +0200 Leon Romanovsky wrote: > NAK to any module driver parameter. If it is applicable to all drivers, > please find a way to configure it to more user-friendly. If it is not, > try to do the same as other drivers do. I think this one may be fine. Configuration which has to be set before device probing can't really be per-device.