Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 13:32:18 -0700
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        bp@alien8.de, x86@kernel.org, hpa@zytor.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: lib: Separate instruction decoder MMIO type from
 MMIO trace
Message-ID: <Y5oy0vwZQAwzkDkr@zx2c4.com>
References: <20221212210254.2559995-1-Jason@zx2c4.com>
 <20221214195629.GA15255@ranerica-svr.sc.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221214195629.GA15255@ranerica-svr.sc.intel.com>
Precedence: bulk

On Wed, Dec 14, 2022 at 11:56:29AM -0800, Ricardo Neri wrote:
> > @@ -347,7 +347,7 @@ static int handle_mmio(struct pt_regs *regs, struct ve_info *ve)
> >  	unsigned long *reg, val, vaddr;
> >  	char buffer[MAX_INSN_SIZE];
> >  	struct insn insn = {};
> > -	enum mmio_type mmio;
> > +	enum insn_mmio_type mmio;
> 
> It would be good to preserve the reverse fir order in the variable
> declarations.
>
> > -	enum mmio_type mmio;
> > +	enum insn_mmio_type mmio;
> 
> Same here.

Maintaining reverse Christmas trees would be in the holiday spirit,
after all. I'll send a v2.

Jason