Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 22:10:35 +0100
From:   Lukasz Majewski <lukma@denx.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Stephen Kitt <steve@sk2.org>, patches@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] ASoC: wm8940: Rewrite code to set proper clocks
Message-ID: <20221214221035.25347427@wsk>
In-Reply-To: <Y5nWEPTDenOIrXFY@sirena.org.uk>
References: <20221214123743.3713843-1-lukma@denx.de>
        <20221214123743.3713843-3-lukma@denx.de>
        <Y5nWEPTDenOIrXFY@sirena.org.uk>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/QNpDM0lSQp3YUsIs1hh5dY5";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/QNpDM0lSQp3YUsIs1hh5dY5
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Mark,

> On Wed, Dec 14, 2022 at 01:37:41PM +0100, Lukasz Majewski wrote:
>=20
> > Without this change, the wm8940 driver is not working when
> > set_sysclk callback (wm8940_set_dai_sysclk) is called with
> > frequency not listed in the switch clause. =20
>=20
> Your commit log doesn't actually describe what this change is...
>=20
> > This change adjusts this driver to allow non-standard frequency
> > set (just after the boot) being adjusted afterwards by the sound
> > system core code. =20
>=20
> This doesn't appear to correspond to the commit.  The change will
> result in the driver automatically configuring it's PLL.
>=20

Yes, indeed - I will update the description.

The problem with the old code was that after boot up - the frequency
was not in the 'switch' values, so the driver aborted in early init.

> > Code in this commit is based on previous change done for wm8974
> > (SHA1: 51b2bb3f2568e6d9d81a001d38b8d70c2ba4af99). =20
>=20
> Please include human readable descriptions of things like commits and
> issues being discussed in e-mail in your mails, this makes them much
> easier for humans to read especially when they have no internet
> access. I do frequently catch up on my mail on flights or while
> otherwise travelling so this is even more pressing for me than just
> being about making things a bit easier to read.

Ok. I will provide proper description.

>=20
> > @@ -496,7 +505,6 @@ static int wm8940_set_bias_level(struct
> > snd_soc_component *component, return ret;
> >  			}
> >  		}
> > -
> >  		/* ensure bufioen and biasen */
> >  		pwr_reg |=3D (1 << 2) | (1 << 3);
> >  		/* set vmid to 300k for standby */ =20
>=20
> Unrelated (and questionable) whitespace change.

Ok. I will remove it.

Thanks for the review.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/QNpDM0lSQp3YUsIs1hh5dY5
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmOaO8wACgkQAR8vZIA0
zr2Utwf+K6mHim7wUuBqEsORod1LhFNJ6FO47rpdO1WayfqWjVQJ28/0CbQ6ZpmZ
CuDzOvjP/T6+tfAVmIkrbqMI6JSpWZznbbWjO38SlymTriKKTh5sBWDIspRZ+mnN
WCUo+okBaeUgJqVCARMse+i8WpJWLAtMFaID6oV01cqcKPaw61yhECpw1U4v1sa5
uwZyr3SOVrZ40gK7xZIeVQzuQZ52GVPBr/VvweSwiOsgbKvjYECQ1TmZQYtWM3QE
FJAKbd8v5Ad/CPkH34KohoxCzQyl0B7GS+ImCr05LS9iDi78iwfVbA8XX0dB5LX8
pazkoNn8U1O3hhfKdxk4HK8NTYHbRA==
=kxtP
-----END PGP SIGNATURE-----

--Sig_/QNpDM0lSQp3YUsIs1hh5dY5--