Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 21:55:46 +0100
From:   Lukasz Majewski <lukma@denx.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Charles Keepax <ckeepax@opensource.cirrus.com>,
        Stephen Kitt <steve@sk2.org>, patches@opensource.cirrus.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ASoC: wm8940: Mute also the speaker output
Message-ID: <20221214215546.657a04f3@wsk>
In-Reply-To: <Y5nbf72ksywcXK65@sirena.org.uk>
References: <20221214123743.3713843-1-lukma@denx.de>
        <20221214123743.3713843-4-lukma@denx.de>
        <Y5nbf72ksywcXK65@sirena.org.uk>
Organization: denx.de
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/pua.gfK73puRtpwqm2giex9";
 protocol="application/pgp-signature"; micalg=pgp-sha512
Precedence: bulk

--Sig_/pua.gfK73puRtpwqm2giex9
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Mark,

> On Wed, Dec 14, 2022 at 01:37:42PM +0100, Lukasz Majewski wrote:
> > Without this change the BTL speaker produces some
> > "distortion" noise when test program
> > (speaker-test -t waw) is ended with ctrl+c. =20
>=20
> > As our design uses speaker outputs to drive BTL speaker,
> > it was necessary to also mute the speaker via the codec
> > internal WM8940_SPKVOL register with setting
> > WM8940_SPKMUTE bit. =20
>=20
> > @@ -465,9 +465,18 @@ static int wm8940_mute(struct snd_soc_dai
> > *dai, int mute, int direction) { =20
>=20
> > +	spkvol_reg &=3D ~WM8940_SPKMUTE;
> > +	if (mute) {
> >  		mute_reg |=3D 0x40;
> > +		spkvol_reg |=3D WM8940_SPKMUTE;
> > +	}
> > +
> > +	ret =3D snd_soc_component_write(component, WM8940_SPKVOL,
> > spkvol_reg);
> > +	if (ret)
> > +		return ret;
> > =20
> >  	return snd_soc_component_write(component, WM8940_DAC,
> > mute_reg); =20
>=20
> In addition to the issue Charles raised this is simply not what the
> mute callback should do, the mute callback should specifically mute
> the digital input (with the goal of masking any glitching on there
> while clocks are started/stopped).=20

Ok

> Looking at the driver the device
> supports analogue bypass paths to the speaker - these will be broken
> by your patch

I was not aware about this side effect. I just wanted to be sure that
the speaker is muted.

> so if you genuinely need some workaround in this area
> I'd be looking at the Speaker Mixer PCM Playback Switch rather than
> muting the speaker as a whole.

I would be more than happy if I could use for example the 'amixer'
command to setup the audio correctly without this patch.=20

For example - on this system - before I run any speaker test I need to
call: amixer -d set 'Speaker Mixer PCM',0 on

to unmute the system.

>  If the device just can't cope without
> an input then ignore_mdown_time might be what you're looking for, it
> looks like the device doesn't have any lengthy sleeps in the power
> up/down paths so that should be fine so long as it doesn't pop/click.
>=20

Ok. I will check this as well.

> I'd also check there's not some other system configuration issue here
> which is more obvious when the input from the DAC stops getting input,
> check that you don't see similar issues when silence is played for
> example.  It might be worth checking that none of the analogue bypass
> paths are enabled.

Thanks for your hints. I will investigate it further.

It looks like this patch is some kind of a hack, to fix my system
configuration and shall be dropped in v2.


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/pua.gfK73puRtpwqm2giex9
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmOaOFIACgkQAR8vZIA0
zr3r7gf+JJEoZ1l46O2qdDS8vRVF97kEnEFeTTC5zZ2pz8azjnZjc31YMXAdnM0d
Gm2AQ0cQrg4E3mSqedFE/XB+9kCrlRXbYoqvFCf8eJrSZJMOv6FDs5O1aRsL945+
bds52k+gCnnrG9/AFCYBvkouwRYP4rQXK55oFkJMM3vofLMhQmjfqMlVn6z+QcUA
0PNlpDi00kPRC4s5DbsNnlaNzLbjiKgf8ToO/xHsgHoPkjzUXZmTK9j/DugB9xJU
D9XfYNzEOcMMOnOrKUznpv6/dQfAjMfjkx1iKu16jgPNtXSnlv2ywlR6cycNzm1h
d7PeKwQELJG973Ig7ddujVcaZoIQvA==
=P500
-----END PGP SIGNATURE-----

--Sig_/pua.gfK73puRtpwqm2giex9--