Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 22:43:21 +0100
From:   Lukas Wunner <lukas@wunner.de>
To:     Florian Weimer <fweimer@redhat.com>,
        James Bottomley <James.Bottomley@HansenPartnership.com>
Cc:     linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efitools: Include <strings.h> for the strcasecmp function
Message-ID: <20221214214321.GA23425@wunner.de>
References: <87pmcllll9.fsf@oldenburg.str.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87pmcllll9.fsf@oldenburg.str.redhat.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

[+cc James]

On Wed, Dec 14, 2022 at 10:30:26PM +0100, Florian Weimer wrote:
> Otherwise, an implicit function declaration is the result, and the
> code may fail to compile with future compilers.
> 
> ---
>  efi-updatevar.c | 1 +
>  1 file changed, 1 insertion(+)

efitools appears to be maintained by James, so you may want to cc
your submissions to him.

Your patches are missing a DCO, yet existing commits in the efitools
repository have one.  You may want to respin with your Signed-off-by
added.

Thanks,

Lukas

> 
> diff --git a/efi-updatevar.c b/efi-updatevar.c
> index 4247105..033d938 100644
> --- a/efi-updatevar.c
> +++ b/efi-updatevar.c
> @@ -11,6 +11,7 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <string.h>
> +#include <strings.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
>  #include <unistd.h>
> 
> Related to:
> 
>   <https://fedoraproject.org/wiki/Changes/PortingToModernC>
>   <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>
>