Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 14:17:22 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 14/47] hugetlb: make default arch_make_huge_pte
 understand small mappings
Message-ID: <Y5pLcoxp2qVZtOq9@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-15-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-15-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?87e55OvQOC7M5Wn4YPQiH1agroi8bdXaaVTqXF+fdO+LCQ8IJZE0ny8FFxkd?=
 =?us-ascii?Q?TyhMBfOVWeFXYw5bRCWd1Nckj530/gT3ZnehVt/NwlybAMbRuiVElF/acK77?=
 =?us-ascii?Q?UuIqH/QuubcOWd1W1s6hEfWXVMZdWesYVFa/93LEJJEYW3icY5LSVZy//Q5c?=
 =?us-ascii?Q?g9dqfiJwgTLapuMpaiP9apd0aBsfIh8ssptJ2XQT5EkL1DG4s9vd7erTpTP+?=
 =?us-ascii?Q?+oXU1H+4UVmjDTkOq7BQUWfrwukdXpWkvOKL7ErBpvsT6c/kXng7Gc61WZID?=
 =?us-ascii?Q?phfPGuP0iZ8Zn6co+HWvulVmR55c1cPI1GfqvB+1DwF/6paYNeUTHC+eYo4/?=
 =?us-ascii?Q?spXsMvhR/Pxr/P9ZbrZmJTq1oSu2fJstQWmKXFDUAvmU9fvdiqDTLkxYQ3yu?=
 =?us-ascii?Q?yBUsqkKdwLMVdFy0rS/sx9MBFHQ0onX/091f63Xf8AAgUWyTrVQiys4GZVXr?=
 =?us-ascii?Q?GLWII15ud4gX+EPBPEKaoKTImpLpE/nQiMcvepbS5dIBs6c6CHAxcv9AZY/l?=
 =?us-ascii?Q?PWYIV0D/FyvTYTLvr9wVExQzhjyNLYzHmzGYJzer9cORh1SI9rq2yNBrov3m?=
 =?us-ascii?Q?rookle5ZFeJBesOt6vlGsLSb6FtWmpNavrIUZF+QFaNDivqfcM8lhpVFs4rb?=
 =?us-ascii?Q?XoqJt80IdDhq5wYsV8Q+3qJ3uMcuLNeP1cG8sh1US8ej6lXASkES7wWjOoiF?=
 =?us-ascii?Q?PQx12hyCIVUKgW+bjTdlvBVkKhzvudtutBZ5wJMDVVIPCZxIWs/w0p322ykf?=
 =?us-ascii?Q?CyxrbCIp+OlAFUSrwyXQmeGfEvT6dewjEHNaODcLoCGwtw1NGIrkpUNWj/d7?=
 =?us-ascii?Q?lVVVY1/hn2fyjTQ+C4vOOcR4o37/VA11PzUAvTgyZBHsJAKqbbJLJuHN4MeV?=
 =?us-ascii?Q?YP06TU2nWscFNcFVCxUcBFwVsypXsCHawdNrDk8O+ndJGNha6Jnx/9kLNnUF?=
 =?us-ascii?Q?GcUiXA2ZGgQVaVOYTO+immz509mkDcTgMuIeHfaUYfDJtJ6DcNW0juSEhqk+?=
 =?us-ascii?Q?BrSODzexbnz1eS68FlPT/SrCJO48FfvnCxIKwkD2GW+mQJSSaeU79URvO5DS?=
 =?us-ascii?Q?+OnKDvdqI2oq8Zwpndad8WTwQh3L68ZM+vHoG7+xbIe0PJ7N49TcDPvIMwDH?=
 =?us-ascii?Q?vvgb01wPmHwioTq/N0cbyg01LZ/vfCkPd3Sl0TPOPhLfvNy8sEgzbaY1bFMU?=
 =?us-ascii?Q?adeBJWEuEhwgWw3wcDNXPd0YV/QEvU5GYebtyZp8grtNRaJZv8hICfe7pMxS?=
 =?us-ascii?Q?o8U7cVinLTgwJEHD2+p2cL3IhVApoYSjBzik+E12j417EuZr4+wKJdWjKjn4?=
 =?us-ascii?Q?95A2lbgLBsfWUddyYm6R/tm4U8VeSYEiNm6hbcX68mXpnCkQxf/0AQXKm7Lo?=
 =?us-ascii?Q?5VRsTpctYlHOd6lNT8H0B43vilrSGmegjeRbvvJy7WUzRRI3W7YdJ0K6XeAO?=
 =?us-ascii?Q?MOAF5m/p20eUONYqYQS9CKUupSqgK8jF/MtXKMOlAwjrnJT2S/3ExqC9lMKl?=
 =?us-ascii?Q?PlRvLV4xxybjNbN0+d3Zua1gbGCPrZO6YRNOMvTUnR2SL9QwaBt7P2a3H5uw?=
 =?us-ascii?Q?fDSHFNwoD/Ad8+si3bV0PSFXVlY0NvPxX7My/iZxRn29me9F4ZDzOdH/JJv0?=
 =?us-ascii?Q?QA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e3338295-c2a6-44bf-5510-08dade20fb49
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 22:17:26.5209
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vL9uqebJT0m6XJTrkraqmd1lTLz23VcQuzFYKxosR0bdraX8JbXjF9Zw2O+Q2wzdlfnkzw7mvpCyunRmMhwqhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6237
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-14_11,2022-12-14_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 phishscore=0 adultscore=0 mlxlogscore=783 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212140182
X-Proofpoint-ORIG-GUID: Kd97RpbF0XmSwCxDYN_JV-MbalQpFn6D
X-Proofpoint-GUID: Kd97RpbF0XmSwCxDYN_JV-MbalQpFn6D
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> This is a simple change: don't create a "huge" PTE if we are making a
> regular, PAGE_SIZE PTE. All architectures that want to implement HGM
> likely need to be changed in a similar way if they implement their own
> version of arch_make_huge_pte.

Nothing wrong with this patch.

However, I wish there was some way we could flag this requirement in
arch specific code.  Just seems like something that would be easy to
overlook.

-- 
Mike Kravetz

> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  include/linux/hugetlb.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 4b1548adecde..d305742e9d44 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -907,7 +907,7 @@ static inline void arch_clear_hugepage_flags(struct page *page) { }
>  static inline pte_t arch_make_huge_pte(pte_t entry, unsigned int shift,
>  				       vm_flags_t flags)
>  {
> -	return pte_mkhuge(entry);
> +	return shift > PAGE_SHIFT ? pte_mkhuge(entry) : entry;
>  }
>  #endif
>  
> -- 
> 2.38.0.135.g90850a2211-goog
>