Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221110112622.389332-1-Yuwei.Guan@zeekrlife.com> <3153dcb3-dd9b-7a2b-a15a-8244d805f246@huaweicloud.com>
In-Reply-To: <3153dcb3-dd9b-7a2b-a15a-8244d805f246@huaweicloud.com>
From:   Yuwei Guan <ssawgyw@gmail.com>
Date:   Thu, 15 Dec 2022 09:48:59 +0800
Message-ID: <CALJQGLmOaEnHawYvNz5fk_MtGhz6DPpW+8E-hgvmWxF--8V4zA@mail.gmail.com>
Subject: Re: [PATCH v1] block, bfq: do the all counting of pending-request if
 CONFIG_BFQ_GROUP_IOSCHED is enabled
To:     Yu Kuai <yukuai1@huaweicloud.com>, Jan Kara <jack@suse.cz>
Cc:     paolo.valente@linaro.org, axboe@kernel.dk,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Yuwei.Guan@zeekrlife.com, "yukuai (C)" <yukuai3@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Yu Kuai <yukuai1@huaweicloud.com> =E4=BA=8E2022=E5=B9=B411=E6=9C=8814=E6=97=
=A5=E5=91=A8=E4=B8=80 11:33=E5=86=99=E9=81=93=EF=BC=9A
>
> Hi,
>
> =E5=9C=A8 2022/11/10 19:26, Yuwei Guan =E5=86=99=E9=81=93:
> > The 'bfqd->num_groups_with_pending_reqs' is used when
> > CONFIG_BFQ_GROUP_IOSCHED is enabled, so let the variables and processes
> > take effect when ONFIG_BFQ_GROUP_IOSCHED is enabled.
> >
>
> This patch looks good to me, fell free to add:
> Reviewed-by: Yu Kuai <yukuai3@huawei.com>
>
> BTW, this patch need to be reviewed by Jan or Paolo before it can be
> applied.
>
Hi Jan,

Could you help to review this patch.

Thanks.

> Thanks,
> Kuai
>
> > Cc: Yu Kuai <yukuai3@huawei.com>
> > Signed-off-by: Yuwei Guan <Yuwei.Guan@zeekrlife.com>
> > ---
> >   block/bfq-iosched.c | 2 ++
> >   block/bfq-iosched.h | 4 ++++
> >   block/bfq-wf2q.c    | 8 ++++----
> >   3 files changed, 10 insertions(+), 4 deletions(-)
> >
> > diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c
> > index 2381cf220ba2..5f54091e7fe9 100644
> > --- a/block/bfq-iosched.c
> > +++ b/block/bfq-iosched.c
> > @@ -7051,7 +7051,9 @@ static int bfq_init_queue(struct request_queue *q=
, struct elevator_type *e)
> >       bfqd->idle_slice_timer.function =3D bfq_idle_slice_timer;
> >
> >       bfqd->queue_weights_tree =3D RB_ROOT_CACHED;
> > +#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >       bfqd->num_groups_with_pending_reqs =3D 0;
> > +#endif
> >
> >       INIT_LIST_HEAD(&bfqd->active_list);
> >       INIT_LIST_HEAD(&bfqd->idle_list);
> > diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h
> > index 9fa89577322d..41aa151ccc22 100644
> > --- a/block/bfq-iosched.h
> > +++ b/block/bfq-iosched.h
> > @@ -197,8 +197,10 @@ struct bfq_entity {
> >       /* flag, set to request a weight, ioprio or ioprio_class change  =
*/
> >       int prio_changed;
> >
> > +#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >       /* flag, set if the entity is counted in groups_with_pending_reqs=
 */
> >       bool in_groups_with_pending_reqs;
> > +#endif
> >
> >       /* last child queue of entity created (for non-leaf entities) */
> >       struct bfq_queue *last_bfqq_created;
> > @@ -491,6 +493,7 @@ struct bfq_data {
> >        */
> >       struct rb_root_cached queue_weights_tree;
> >
> > +#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >       /*
> >        * Number of groups with at least one process that
> >        * has at least one request waiting for completion. Note that
> > @@ -538,6 +541,7 @@ struct bfq_data {
> >        * with no request waiting for completion.
> >        */
> >       unsigned int num_groups_with_pending_reqs;
> > +#endif
> >
> >       /*
> >        * Per-class (RT, BE, IDLE) number of bfq_queues containing
> > diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
> > index b02b53658ed4..ea4c3d757fdd 100644
> > --- a/block/bfq-wf2q.c
> > +++ b/block/bfq-wf2q.c
> > @@ -1612,28 +1612,28 @@ void bfq_requeue_bfqq(struct bfq_data *bfqd, st=
ruct bfq_queue *bfqq,
> >
> >   void bfq_add_bfqq_in_groups_with_pending_reqs(struct bfq_queue *bfqq)
> >   {
> > +#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >       struct bfq_entity *entity =3D &bfqq->entity;
> >
> >       if (!entity->in_groups_with_pending_reqs) {
> >               entity->in_groups_with_pending_reqs =3D true;
> > -#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >               if (!(bfqq_group(bfqq)->num_queues_with_pending_reqs++))
> >                       bfqq->bfqd->num_groups_with_pending_reqs++;
> > -#endif
> >       }
> > +#endif
> >   }
> >
> >   void bfq_del_bfqq_in_groups_with_pending_reqs(struct bfq_queue *bfqq)
> >   {
> > +#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >       struct bfq_entity *entity =3D &bfqq->entity;
> >
> >       if (entity->in_groups_with_pending_reqs) {
> >               entity->in_groups_with_pending_reqs =3D false;
> > -#ifdef CONFIG_BFQ_GROUP_IOSCHED
> >               if (!(--bfqq_group(bfqq)->num_queues_with_pending_reqs))
> >                       bfqq->bfqd->num_groups_with_pending_reqs--;
> > -#endif
> >       }
> > +#endif
> >   }
> >
> >   /*
> >
>