Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Zhang, Chen" <chen.zhang@intel.com>
To:     Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
CC:     "x86@kernel.org" <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Gao, Chao" <chao.gao@intel.com>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Christopherson,, Sean" <seanjc@google.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: RE: [RFC PATCH 2/9] KVM: x86: Add a kvm-only leaf for RRSBA_CTRL
Thread-Topic: [RFC PATCH 2/9] KVM: x86: Add a kvm-only leaf for RRSBA_CTRL
Thread-Index: AQHZDLMfWcd8CShN1kKrF7OSJP+Sha5t7gqAgABaGHA=
Date:   Thu, 15 Dec 2022 02:59:45 +0000
Message-ID: <MWHPR11MB0031009C01144135F0EE32279BE19@MWHPR11MB0031.namprd11.prod.outlook.com>
References: <20221210160046.2608762-1-chen.zhang@intel.com>
 <20221210160046.2608762-3-chen.zhang@intel.com>
 <20221214213335.GB16072@ranerica-svr.sc.intel.com>
In-Reply-To: <20221214213335.GB16072@ranerica-svr.sc.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?u3he+JZIPpfUPp63LojgZcZEbbpfQSMPYiV+JKtD9RVp792yTh4pgYLKIomu?=
 =?us-ascii?Q?z+oBnMXrWP+5lT0jUl4DlX2DRuROZV0XMFnOGy+KEDCeOCmdSBZLUCKcjakV?=
 =?us-ascii?Q?SvZWgPnEe0z33QCQ/XHDu6Los+dFEd3eBaz/9z9/lrhDnvGhVr9rtP/jLPO/?=
 =?us-ascii?Q?dJbCBQfiJVOTQM2JPXiJTQubevaN2RTSVJtVw21+O5nTXpFjBHJ9zxvyicRY?=
 =?us-ascii?Q?auFtBth//SXMZ+GTVcLsO9nkZhn9GnFnkDy+vUbh8DeeXpC1d2iWM5XARhdO?=
 =?us-ascii?Q?YG1sFFblny/Mld3jR5FAZUm5YO+6O1ucSIBdUi2xXFgA0OyM7FmzLxFta5gc?=
 =?us-ascii?Q?9C2C3dKydbSfdWsm0ut7LKQRTYCxIt38Bg5MMwEWP1OV+DDC8WIyDHHjpC1Y?=
 =?us-ascii?Q?mxJ/DRMFSMVj6EIfP5ivPkQnO0fjtcOgxuzb+pQudWAGvfH+MBODGH1KMpdJ?=
 =?us-ascii?Q?MmgBoJbp3AVdrm5dIUpO+pDQDGGN5eBK/mZ3siDJawAJxBIlGtqv+3VWQpNM?=
 =?us-ascii?Q?hhfoLiB0Fxgf0tD3cRh7QMFisD9ohg0n+esIKenVR4dYjARnX27LQ94WSUYV?=
 =?us-ascii?Q?6Cg49jDJd6zZCQLRz5SpfQ/qxt48B0pW8D5nLolrAxgpV3rkbBBdYvFebNk6?=
 =?us-ascii?Q?ChRoV1ot+UD6cK/aiorJ1whJdC/x9GErl6UE/3P6I93NfC7WbdR7FVa9ofBJ?=
 =?us-ascii?Q?VgqoVvPurY0xLD3z/oJLu4LoRVwhxwd7xUraMT1QiiiYLL2GtF6A6jntKbqN?=
 =?us-ascii?Q?P/gb+lec3+F77Or4NEnUR24EE7NCv85KKIAU60QwepHARRlUygKtjrBuaqYC?=
 =?us-ascii?Q?arpCqPRwpW0rOUwMgaxLBEatwBc05D3fWcdyLIiM6lps9r2boh03Fj6Vyzi/?=
 =?us-ascii?Q?2rVeMA2fHOEOF1J5a9LYYC9ROvLkKioExFgKFC071wU0psZzwTP0rKVzuR6p?=
 =?us-ascii?Q?ukOU3vJ6aV0W5TsTRExLfNTOCtAe5c9l9cKaayo/KsVXVmFpChfAj4755SWV?=
 =?us-ascii?Q?KYzzg4JYSrJtagMR0b9IarBAiJrylidi69s8298izlYsdCeg94LTnGRFerra?=
 =?us-ascii?Q?Rr1Lh+dYTolQCussoAmcmEtV+dTCud0oHOBupFE5O5Z6BDgPPJsKD6vtm4d1?=
 =?us-ascii?Q?1j26sHnthagpC1tDVEMdWVMdD37F8PKh8lk/bLtBCE6j7v6biUi1nMQQP+1f?=
 =?us-ascii?Q?Cc/nyRpfb30AiCJ2OQeKYAZ04jG/zQTXyB7sgtUfkEBWxWgUgE/cN88yWGA1?=
 =?us-ascii?Q?OPi1UDLgeIynHbIJmXtAzb/AVxEzRcfROy+T7VyEZXc38KPeXm/XFHXjZXBW?=
 =?us-ascii?Q?E8QW+YIxSeNUVS3+A0yZJUYPQZyb3EPutoz/iFIdJnb711YWCzZ68fcPEBtc?=
 =?us-ascii?Q?Dx45Qgco7CTMeq3zdI5Z8KE1dbj6N5kFihJH864gdAJWp2LuCIKH750dCR2/?=
 =?us-ascii?Q?O7jflsIOpsbOtg9GthnUVoLTZRNUb4p0Gvpa5iGqGzTJv6cLb9EtAtvyOqUU?=
 =?us-ascii?Q?B1wstpkKdbntJP66YfSCO1yLU6SDzCnraX6vKAj+Vvhql/V0GLdqFSawXBz0?=
 =?us-ascii?Q?9ZKQqNFWjrxkWauYIsJErSXhO2cFkr6sm6btR4M5?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0031.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aeb9e4a1-2710-4caa-1154-08dade486b9e
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Dec 2022 02:59:45.0566
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FgBqQ/paouikh3PgzlgEiHQ1IPDvYsAArJFOBfNXOoX/Lt8IkJW/RSkQAv31Gwamx5sRQ6qQBEg9eD9qx8+UFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7776
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
> Sent: Thursday, December 15, 2022 5:34 AM
> To: Zhang, Chen <chen.zhang@intel.com>
> Cc: x86@kernel.org; linux-kernel@vger.kernel.org; kvm@vger.kernel.org; Ga=
o,
> Chao <chao.gao@intel.com>; Pawan Gupta
> <pawan.kumar.gupta@linux.intel.com>; Paolo Bonzini
> <pbonzini@redhat.com>; Christopherson,, Sean <seanjc@google.com>; H.
> Peter Anvin <hpa@zytor.com>; Dave Hansen <dave.hansen@linux.intel.com>;
> Borislav Petkov <bp@alien8.de>; Ingo Molnar <mingo@redhat.com>; Thomas
> Gleixner <tglx@linutronix.de>
> Subject: Re: [RFC PATCH 2/9] KVM: x86: Add a kvm-only leaf for RRSBA_CTRL
>=20
> On Sun, Dec 11, 2022 at 12:00:39AM +0800, Zhang Chen wrote:
> > KVM needs to check if guests can see RRSBA_CTRL. If a guest is using
> > retpoline and cannot see RRSBA_CTRL and the host enumerates RRSBA, KVM
> > is responsible for setting RRSBA_DIS_S for the guest.
> >
> > This allows VM migration from parts doesn't enumerates RRSBA to those
>=20
> perhaps s/parts doesn't enumerates/parts that do not enumerate/ reads
> better?

OK.

>=20
> > that enumerate RRSBA.
>=20
> and here maybe s/that enumerate RRSBA/do/ ?

Looks good to me. Thanks for your comments.
I will fix patch2/3 in the next version.

Thanks
Chen

>=20
> Thanks and BR,
> Ricardo