Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\))
Subject: Re: [PATCH mm-unstable] mm: move folio_set_compound_order() to
 mm/internal.h
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <cda1b5ca-a03e-e545-d206-30d74ed33a3d@oracle.com>
Date:   Thu, 15 Dec 2022 13:31:24 +0800
Cc:     linux-kernel@vger.kernel.org,
        Linux Memory Management List <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Matthew Wilcox <willy@infradead.org>,
        John Hubbard <jhubbard@nvidia.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E39CAB80-2745-498C-8CDF-A469430F0276@linux.dev>
References: <20221213212053.106058-1-sidhartha.kumar@oracle.com>
 <0B650D64-1F64-4695-9365-CF695029C50C@linux.dev>
 <cda1b5ca-a03e-e545-d206-30d74ed33a3d@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Precedence: bulk


> On Dec 15, 2022, at 13:09, Sidhartha Kumar =
<sidhartha.kumar@oracle.com> wrote:
>=20
> On 12/14/22 7:44 PM, Muchun Song wrote:
>>> On Dec 14, 2022, at 05:20, Sidhartha Kumar =
<sidhartha.kumar@oracle.com> wrote:
>>>=20
>>> folio_set_compound_order() is moved to an mm-internal location so =
external
>>> folio users cannot misuse this function. Change the name of the =
function
>>> to folio_set_order() and use WARN_ON_ONCE() rather than BUG_ON. =
Also,
>>> handle the case if a non-large folio is passed and add clarifying =
comments
>>> to the function.
>>>=20
>>> Link: =
https://lore.kernel.org/lkml/20221207223731.32784-1-sidhartha.kumar@oracle=
.com/T/
>>> Fixes: 9fd330582b2f ("mm: add folio dtor and order setter =
functions")
>>>=20
>>> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
>>> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
>>> Suggested-by: Muchun Song <songmuchun@bytedance.com>
>>> Suggested-by: Matthew Wilcox <willy@infradead.org>
>>> Suggested-by: John Hubbard <jhubbard@nvidia.com>
>> Reviewed-by: Muchun Song <songmuchun@bytedance.com>
> Hi Muchun,
>=20
> Does this review include the change from

Yes.

Thanks.

>=20
> + if (!folio_test_large(folio)) {
> + 	WARN_ON_ONCE(order);
> + 	return;
> + }
>=20
> to
>=20
> if (WARN_ON_ONCE(!folio_test_large(folio)))
> 	return;
>=20
> discussed in in this thread?
>=20
> Thanks,
> Sidhartha Kumar
>> Thanks.