Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp652515rwb; Thu, 15 Dec 2022 00:07:13 -0800 (PST) X-Google-Smtp-Source: AA0mqf5k8a2O2OLhUZJrivhWCLGfe+Ukd/ZJSUabAn24rKIcbdB9JUblxCSKUCCPVJy/QkYWH2Tx X-Received: by 2002:a17:906:eb5b:b0:7c0:dd66:e991 with SMTP id mc27-20020a170906eb5b00b007c0dd66e991mr22436548ejb.6.1671091632785; Thu, 15 Dec 2022 00:07:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671091632; cv=none; d=google.com; s=arc-20160816; b=YREpZaOdK3j2sYzzIXXxaGzTsMpORv6rRSWLb+l94CvMwCbIgQUBsxgOXizBM1lEJy qe8rm+MjonlkfM1T+5vN2Bhm95LajAdoIioYG7wHJ/fRDMJ4WiudXOVuQCciJHI76SlJ cZEInWt8RWz7LAhFMsn0hp7ZX9/njXfBYoP2h+JWEsvv62Q0br2SiSuwBuG/IcRS2bMf VTeRYQD+wHEEubsaQhFqxUtqwIFddEqcB5OBWN0His7zfusyqsAAmhq9yykWyZuYjYlq CnkortnAZYAQ9ZBDjxiEB88UWds5QXAoI2Kg7KQQoSXmgfhu3psyAKNojXscrBBD1kMA AfrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5G1lZ4l41GqTHjKJk3vBh1fkYrbJKu6icifPsmP1DNk=; b=Nvd3YuX2hBw+X9zvtX7IruLZeyDkjmV+ZV5Te/bH/8LvNDzVsEEFexyGiBueK6ihdR m61LJueyZLdKcosDhL/TYYsYdB+C5zL+7QqrOy9X2MTLp7dnxuEoZRJOQwZ+YWCWWDJI c2s/lJ0rN226NFhhB5eE6Y4h3Qm2P+jEvMTo660TBpuO3Tl/KdO7413vpCYpIlHJl7zR mO9RyfYrx9mj9J5A/5RQKYkbsUSJt5AMUTVZo0KRE8S1lpgyIzchHpJsEjOR3LcisH1d 8iBzPLjG6jN5rO8UFOH4aIQ79XTdcqfHLiYyLBnFpEzoyrCmBGEPPQdqmharn1UcTg4s N76g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=uoURvYpi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc21-20020a1709071c1500b0078dce2b1985si15326790ejc.134.2022.12.15.00.06.56; Thu, 15 Dec 2022 00:07:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b=uoURvYpi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229705AbiLOH22 (ORCPT + 70 others); Thu, 15 Dec 2022 02:28:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229616AbiLOH2X (ORCPT ); Thu, 15 Dec 2022 02:28:23 -0500 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A27C205FD for ; Wed, 14 Dec 2022 23:28:18 -0800 (PST) X-UUID: 34dc1c1026254c8b9c8ae3340cca24eb-20221215 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=5G1lZ4l41GqTHjKJk3vBh1fkYrbJKu6icifPsmP1DNk=; b=uoURvYpiaUYK9q/x9jAUIJ6AML5LO8x8/MibmDqqRNYId1GTnk1QU/ybFL0Fx+xKBUj+NRIMaVoSizbUROrxwAQ1PaMbIinlAJO7Az456GF3iSGumP3MtiwZHHPri2rBdZr39MP4Z8duuXJZ9MqahviivS5H+GfC4Tf+6LzLEU0=; X-CID-P-RULE: Spam_GS6885AD X-CID-O-INFO: VERSION:1.1.14,REQID:c0132f52-aa5f-493b-83c0-906eed8750a5,IP:0,U RL:0,TC:0,Content:100,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS6885AD,AC TION:quarantine,TS:195 X-CID-INFO: VERSION:1.1.14,REQID:c0132f52-aa5f-493b-83c0-906eed8750a5,IP:0,URL :0,TC:0,Content:100,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_US65DF41,ACTI ON:quarantine,TS:195 X-CID-META: VersionHash:dcaaed0,CLOUDID:0faeb4af-9f02-4d44-9c44-6e4bb4e4f412,B ulkID:221215152813C7BCLOH9,BulkQuantity:0,Recheck:0,SF:38|28|17|19|48|801, TC:nil,Content:3,EDM:-3,IP:nil,URL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,C OL:0 X-UUID: 34dc1c1026254c8b9c8ae3340cca24eb-20221215 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2006584776; Thu, 15 Dec 2022 15:28:11 +0800 Received: from mtkmbs13n2.mediatek.inc (172.21.101.108) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Thu, 15 Dec 2022 15:28:09 +0800 Received: from localhost.localdomain (10.17.3.154) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 15 Dec 2022 15:28:09 +0800 From: Yongqiang Niu To: CK Hu , Chun-Kuang Hu , "Jassi Brar" , Matthias Brugger CC: , , , , Hsin-Yi Wang , Yongqiang Niu , AngeloGioacchino Del Regno Subject: [PATCH v11, 1/4] mailbox: mtk-cmdq: Use GCE_CTRL_BY_SW definition instead of number Date: Thu, 15 Dec 2022 15:28:03 +0800 Message-ID: <20221215072806.10224-2-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221215072806.10224-1-yongqiang.niu@mediatek.com> References: <20221215072806.10224-1-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS, T_SPF_TEMPERROR,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use GCE_CTRL_BY_SW definition instead of number Signed-off-by: Yongqiang Niu Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: CK Hu --- drivers/mailbox/mtk-cmdq-mailbox.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index 9465f9081515..c3cb24f51699 100644 --- a/drivers/mailbox/mtk-cmdq-mailbox.c +++ b/drivers/mailbox/mtk-cmdq-mailbox.c @@ -38,6 +38,7 @@ #define CMDQ_THR_PRIORITY 0x40 #define GCE_GCTL_VALUE 0x48 +#define GCE_CTRL_BY_SW GENMASK(2, 0) #define CMDQ_THR_ACTIVE_SLOT_CYCLES 0x3200 #define CMDQ_THR_ENABLED 0x1 @@ -129,7 +130,8 @@ static void cmdq_init(struct cmdq *cmdq) WARN_ON(clk_bulk_enable(cmdq->gce_num, cmdq->clocks)); if (cmdq->control_by_sw) - writel(0x7, cmdq->base + GCE_GCTL_VALUE); + writel(GCE_CTRL_BY_SW, cmdq->base + GCE_GCTL_VALUE); + writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + CMDQ_THR_SLOT_CYCLES); for (i = 0; i <= CMDQ_MAX_EVENT; i++) writel(i, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE); -- 2.25.1