Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from
 device pinctrl
Message-ID: <efa9171f-98ac-f518-e59e-f6c4d7d3d4e6@amazon.com>
Date:   Thu, 15 Dec 2022 10:15:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <jarkko.nikula@linux.intel.com>, <mika.westerberg@linux.intel.com>,
        <jsd@semihalf.com>, <linux-i2c@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dwmw@amazon.co.uk>,
        <benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>,
        <jonnyc@amazon.com>, <hanochu@amazon.com>, <farbere@amazon.com>,
        <itamark@amazon.com>
References: <20221214142725.23881-1-hhhawa@amazon.com>
 <Y5n1U1lYbcbJ5U1k@smile.fi.intel.com>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
In-Reply-To: <Y5n1U1lYbcbJ5U1k@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/14/2022 6:09 PM, Andy Shevchenko wrote:
> ...should be located here.
> 
> ...

Ack - will move them.

> 
>> +     if (dev->dev->pins && dev->dev->pins->p)
>> +             rinfo->pinctrl = dev->dev->pins->p;
> Hmm... I don't see how this field is being used.
> Can you elaborate?

This field is used in i2c_generic_scl_recovery(), if it's not NULL then 
the flow will set the state to GPIO before running the recovery mechanism.
         if (bri->pinctrl)
                 pinctrl_select_state(bri->pinctrl, bri->pins_gpio);

.
.

I saw that that the change failed in complication for SPARC 
architecture, as the pins field is wraparound with CONFIG_PINCTRL in 
device struct. I though on two options to solve the compilation error, 
first by adding wraparound of CONFIG_PINCTRL when accessing the pins 
field. And the second option is to add get function in pinctrl/devinfo.h 
file, which return the pins field, or NULL in case the PINCTRL is not 
defined. Which option you think we can go with?