Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 01:30:17 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Sergei Shtepa <sergei.shtepa@veeam.com>
Cc:     axboe@kernel.dk, corbet@lwn.net, linux-block@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 07/21] block, blksnap: init() and exit() functions
Message-ID: <Y5rpKXuJxqeUYfJP@infradead.org>
References: <20221209142331.26395-1-sergei.shtepa@veeam.com>
 <20221209142331.26395-8-sergei.shtepa@veeam.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221209142331.26395-8-sergei.shtepa@veeam.com>
Precedence: bulk

On Fri, Dec 09, 2022 at 03:23:17PM +0100, Sergei Shtepa wrote:
> +	result = diff_io_init();
> +	if (result)
> +		return result;
> +
> +	result = snapimage_init();
> +	if (result)
> +		return result;
> +
> +	result = tracker_init();
> +	if (result)
> +		return result;

You need to clean up all these initialization if a later one fails.

Also, does this really need a separate file?  Any good reason to
not just keep the tiny amount of init code in ctrl.c?

> +static void __exit blk_snap_exit(void)
> +{
> +	pr_info("Unloading module\n");

Also we try to avoid these verbose messages for new code normally.