Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 10:17:47 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     Mark Brown <broonie@kernel.org>
Cc:     Rouven Czerwinski <r.czerwinski@pengutronix.de>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, kernel@pengutronix.de,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: max98088: fix initial dai mute state
Message-ID: <20221215091747.xn3f7ecrwoc7ssyo@pengutronix.de>
References: <20221213095328.122309-1-r.czerwinski@pengutronix.de>
 <20221213095328.122309-2-r.czerwinski@pengutronix.de>
 <Y5hpqWH2WuSIUHil@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y5hpqWH2WuSIUHil@sirena.org.uk>
User-Agent: NeoMutt/20180716
Precedence: bulk

Hi Mark,

On 22-12-13, Mark Brown wrote:
> On Tue, Dec 13, 2022 at 10:53:28AM +0100, Rouven Czerwinski wrote:
> 
> > To fix that we need to explicit set the mute state. Now the first
> > playback request gets played correctly.
> 
> > +++ b/sound/soc/codecs/max98088.c
> > @@ -1710,6 +1710,11 @@ static int max98088_probe(struct snd_soc_component *component)
> >         snd_soc_component_write(component, M98088_REG_1E_DAI2_IOCFG,
> >                 M98088_S2NORMAL|M98088_SDATA);
> >  
> > +       snd_soc_component_update_bits(component, M98088_REG_2F_LVL_DAI1_PLAY,
> > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > +       snd_soc_component_update_bits(component, M98088_REG_31_LVL_DAI2_PLAY,
> > +               M98088_DAI_MUTE_MASK, M98088_DAI_MUTE);
> > +
> 
> Won't this be broken again after suspend?  The device gets powered off
> over suspend, then when it powers on again with the output unmuted
> nothing will do another write since the register is already in the state
> in the cache.

I didn't found any suspend logic within the driver. Is this handled
within the ASoC core?

Regards,
  Marco