Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp818844rwb; Thu, 15 Dec 2022 02:55:57 -0800 (PST) X-Google-Smtp-Source: AA0mqf663dCiGnUI9wqJU8oC5nWmTrzXFjrl4OB7BjHyuo3ipbvZ6T+7mTELK/9Fmu+ce617RR7E X-Received: by 2002:a17:906:351b:b0:7c0:a6a9:64e9 with SMTP id r27-20020a170906351b00b007c0a6a964e9mr31943208eja.36.1671101757359; Thu, 15 Dec 2022 02:55:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671101757; cv=none; d=google.com; s=arc-20160816; b=rc01BGQ+VDZZ+765gBK6O2b4Wku55axp9yjDZoZB+S+mf9ThMjmFt+WRTQzJgnlZ/B 0FzvRqqAdlvcXHe1GggsdbLw0Xhawnncmm2ecw3MGjou74D05khCSyTgIMhERLJuKWBK VenVrwyUBmbWEmWPIE4nSzqkYcrqc/rQiDqoyUbUOhtqKmuDYnNPoQzCP6ddMjMWeBH6 bfP0wT2s5c0SIZ4lHiff4J0Cq/tFfKerSOABbp2o8+vUwDnJ6Kil1Cmv9PsyE/Wu4gUw tIBAeYm+j8C/mpXZtTXzJn09aYaLAgJ/AVWcO9IWYjOHjSXvh11EwkQemyCo7nv8q/Ua qnvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=iRzkPWuCkQml6FYGQ4TeSDfpbXjzHlPcMLaQkvZAaQE=; b=IdN742/3ZLYC99GIgPqSh4XnRxC8TiT5o59PSgvPZwlSyXCuG79CyrHmNYBcSCO9lA 0ZRah2U9EkT/QoeEUqd7kJ1VVI83k5984acCu4/bknP/yRoJ25VscRk8cmus5OMGC6xJ EHyVX0dG4g0Npz0WwvGkF+60xoXhQjGrRPvksnchi6WkyqeQXWkdl8dSbM5G1wp+1KpK laivzFooZPv3kULdpckw6hMGi5kl4rH1Iw2L4421BTQZvu7RFNv54Wuhh2jc33R2Mtzt yabOJ3HGfQdkpCdNMPPLipXI4gb1a7MHBGowHr6cy22nKdzVMdQzivMjjwrR3a2QCaAb jIig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2V1qG2uH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb7-20020a170907160700b0078db3762061si6601166ejc.439.2022.12.15.02.55.40; Thu, 15 Dec 2022 02:55:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=2V1qG2uH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230174AbiLOKG3 (ORCPT + 68 others); Thu, 15 Dec 2022 05:06:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229945AbiLOKG1 (ORCPT ); Thu, 15 Dec 2022 05:06:27 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92C76FDD; Thu, 15 Dec 2022 02:06:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=iRzkPWuCkQml6FYGQ4TeSDfpbXjzHlPcMLaQkvZAaQE=; b=2V1qG2uHmplQmT3bRDjmbko+Ot HY9m8IrWLuV49vQ/8DgONSsiWewojZXnbLNKHm/FdweSHW90r6i7onM+uXP9jPMahqSBNW+RiE6Ix jnE9iIFRM+4hRDUhauomEVtIo2ZRZ2qE5w0hxa/Cw1xOoLPLzwNhTUFx41OACjAgdO3o5wjvaRK1J DVtqQC7NAiVFfF4ik3p/Y61CtKdO7jVliVCIEEJ8VYSy1G/lLfi1MqIkVFRkB0Dk0/w8E2+WxKmQ0 /GnElXVHFDtAU0TSJgq1gVova4ZCO/X8a0OFn6ehKzhFSUjwHQj+dceCySI9ibpAqAUD0cnapqLUV 0SRsX12A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p5l8A-008ffS-Mn; Thu, 15 Dec 2022 10:06:22 +0000 Date: Thu, 15 Dec 2022 02:06:22 -0800 From: Christoph Hellwig To: Sergei Shtepa Cc: axboe@kernel.dk, corbet@lwn.net, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 13/21] block, blksnap: functions and structures for performing block I/O operations Message-ID: References: <20221209142331.26395-1-sergei.shtepa@veeam.com> <20221209142331.26395-14-sergei.shtepa@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221209142331.26395-14-sergei.shtepa@veeam.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + bio = bio_alloc_bioset(diff_region->bdev, nr_iovecs, opf, gfp_mask, > + &diff_io_bioset); > + if (unlikely(!bio)) { > + if (is_nowait) > + ret = -EAGAIN; > + else > + ret = -ENOMEM; > + goto fail; bio_alloc_bioset can't fail for the !is_nowait case.