Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221214182247.79824-1-sebastian.reichel@collabora.com> <20221214182247.79824-4-sebastian.reichel@collabora.com>
In-Reply-To: <20221214182247.79824-4-sebastian.reichel@collabora.com>
From:   Jagan Teki <jagan@edgeble.ai>
Date:   Thu, 15 Dec 2022 16:15:47 +0530
Message-ID: <CA+VMnFzMgOC7sgcpQ7nZx2gaJfqqvRu8RxETguaBHN1Lg_nG_w@mail.gmail.com>
Subject: Re: [PATCHv6 3/7] arm64: dts: rockchip: Add base DT for rk3588 SoC
To:     Sebastian Reichel <sebastian.reichel@collabora.com>
Cc:     Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Marc Zyngier <maz@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Christopher Obbard <chris.obbard@collabora.com>,
        Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Kever Yang <kever.yang@rock-chips.com>, kernel@collabora.com,
        Yifeng Zhao <yifeng.zhao@rock-chips.com>,
        Elaine Zhang <zhangqing@rock-chips.com>,
        Sugar Zhang <sugar.zhang@rock-chips.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 14 Dec 2022 at 23:53, Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
>
> From: Kever Yang <kever.yang@rock-chips.com>
>
> This initial version supports (single core) CPU, dma, interrupts, timers,
> UART and SDHCI. In short - everything necessary to boot Linux on this
> system on chip.
>
> The DT is split into rk3588 and rk3588s, which is a reduced version
> (i.e. with less peripherals) of the former.
>
> Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> Signed-off-by: Elaine Zhang <zhangqing@rock-chips.com>
> Signed-off-by: Sugar Zhang <sugar.zhang@rock-chips.com>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> [rebase, squash and reword commit message]
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3588.dtsi  |   58 +
>  arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 1703 +++++++++++++++++++++
>  2 files changed, 1761 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588.dtsi
>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s.dtsi
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588.dtsi b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
> new file mode 100644
> index 000000000000..d085e57fbc4c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588.dtsi
> @@ -0,0 +1,58 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2021 Rockchip Electronics Co., Ltd.

< snip>

> +       qos_vop_m0: qos@fdf82000 {
> +               compatible = "rockchip,rk3588-qos", "syscon";
> +               reg = <0x0 0xfdf82000 0x0 0x20>;
> +       };
> +
> +       qos_vop_m1: qos@fdf82200 {
> +               compatible = "rockchip,rk3588-qos", "syscon";
> +               reg = <0x0 0xfdf82200 0x0 0x20>;
> +       };
> +
> +       gmac1: ethernet@fe1c0000 {
> +               compatible = "rockchip,rk3588-gmac", "snps,dwmac-4.20a";
> +               reg = <0x0 0xfe1c0000 0x0 0x10000>;
> +               interrupts = <GIC_SPI 234 IRQ_TYPE_LEVEL_HIGH 0>,
> +                            <GIC_SPI 233 IRQ_TYPE_LEVEL_HIGH 0>;
> +               interrupt-names = "macirq", "eth_wake_irq";
> +               clocks = <&cru CLK_GMAC_125M>, <&cru CLK_GMAC_50M>,
> +                        <&cru PCLK_GMAC1>, <&cru ACLK_GMAC1>,
> +                        <&cru CLK_GMAC1_PTP_REF>;
> +               clock-names = "stmmaceth", "clk_mac_ref",
> +                             "pclk_mac", "aclk_mac",
> +                             "ptp_ref";
> +               power-domains = <&power RK3588_PD_GMAC>;
> +               resets = <&cru SRST_A_GMAC1>;
> +               reset-names = "stmmaceth";
> +               rockchip,grf = <&sys_grf>;
> +               rockchip,php-grf = <&php_grf>;
> +               snps,axi-config = <&gmac1_stmmac_axi_setup>;
> +               snps,mixed-burst;
> +               snps,mtl-rx-config = <&gmac1_mtl_rx_setup>;
> +               snps,mtl-tx-config = <&gmac1_mtl_tx_setup>;
> +               snps,tso;
> +               status = "disabled";
> +
> +               mdio1: mdio {
> +                       compatible = "snps,dwmac-mdio";
> +                       #address-cells = <0x1>;
> +                       #size-cells = <0x0>;
> +               };

One nick with dtbs_check,
ethernet@fe1c0000: Unevaluated properties are not allowed ('reg',
'interrupts', 'interrupt-names', 'power-domains', 'resets',
'reset-names', 'snps,axi-config', 'snps,mixed-burst',
'snps,mtl-rx-config', 'snps,mtl-tx-config', 'snps,tso', 'mdio',
'stmmac-axi-config', 'rx-queues-config', 'tx-queues-config' were
unexpected)

Jagan.