Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 11:26:46 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Adrian Freund <adrian@freund.io>
cc:     kernel test robot <lkp@intel.com>, linux-input@vger.kernel.org,
        oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
        Basavaraj Natikar <basavaraj.natikar@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Ivan Dovgal <iv.dovg@gmail.com>,
        "Luke D . Jones" <luke@ljones.dev>
Subject: Re: [PATCH] HID: amd_sfh: Add support for tablet-mode-switch
 sensor
In-Reply-To: <3447483d-11bc-8ab2-8aba-96870b42281b@freund.io>
Message-ID: <nycvar.YFH.7.76.2212151125090.9000@cbobk.fhfr.pm>
References: <20221214214127.15347-1-adrian@freund.io> <202212151621.e3OmYctb-lkp@intel.com> <3447483d-11bc-8ab2-8aba-96870b42281b@freund.io>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 15 Dec 2022, Adrian Freund wrote:

> >     In file included from drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_desc.c:15:
> >>> drivers/hid/amd-sfh-hid/sfh1_1/../hid_descriptor/amd_sfh_hid_report_desc.h:649:17:
> >>> warning: 'tms_report_descriptor' defined but not used
> >>> [-Wunused-const-variable=]
> >       649 | static const u8 tms_report_descriptor[] = {
> >           |                 ^~~~~~~~~~~~~~~~~~~~~
> hid_descriptor/amd_sfh_hid_report_desc.h is included from both
> hid_descriptor/amd_sfh_hid_desc.c and sfh1_1/amd_sfh_desc.c, the first of
> which has 4 usages of tms_report_descriptor. The later is for sensor fusion
> hub 1.1. I don't have access to a devices using sfh1.1, so I can't add support
> for the tablet mode switch there, causing the variable to be unused for that
> import.

I'd say either move the rdesc directly to 
hid_descriptor/amd_sfh_hid_desc.c, or alternatively mark it with 
__attribute__((used)).

-- 
Jiri Kosina
SUSE Labs