Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp877048rwb; Thu, 15 Dec 2022 03:48:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf6MTJyHSKxNckv5+XA1VXK1oRkXwezDT+wVFQ4xRHV/50NmbJN1SHbJx3NlbADlTuet1sOJ X-Received: by 2002:a17:903:22c3:b0:189:d92b:86e4 with SMTP id y3-20020a17090322c300b00189d92b86e4mr40870158plg.52.1671104889210; Thu, 15 Dec 2022 03:48:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671104889; cv=none; d=google.com; s=arc-20160816; b=B/YsTf8bZoITE3mBj1XNxBzKG3Ie0/tMU06sA7IhALvt73xwrmpcL4LC/sU9zMTV0G 1mZOPp9afPMlCSInJrG7Wj7hHHTkju4cToGssVF1a/E5n2sEFz6pSkF+f78SF6Dk3yr3 i/22P7sE0frkhyx9vH287fJ6oTdhiXAffZwLzs7OTxWnA5xWYzWukpnsZcdJskInIxZx NbcPw8YegimskYCwPj9g1u3SHhOZX5rxBbkT5w48PchNxX9Hj4znG/lV2h+26BmcoMad ALcYZ9qkUvm2kgXqFf1jyZOqNAAbGpuJp8IbABej5k4p8vOvIN9u9rOCpfc8PTZ52bPl x80A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=xhll34qBllbleKx66EAPbdWrQOO5TZUZ0637lrp11Nc=; b=SPjZed0A72UwTJxcA/TQWcZ86aoeS5+ZaDX0p5H8Y9Chh6IfVKUOky2Gx5czwgFiSL 6RcDTuMyJ9SHvdAiNmx18M5sfcjfMyLdJaPT9gE7vUVcR2sYNbTMg+kk6fL0zVMcguvR Oc9FgIzdZsgKtOd7KrEQ4wAyFD9QPlxB6RWRfEERp5o5Z0Wj/A4mA5LIm+sfo69SJ/pk Yy+3Twdg7Ji/GgBLZnM9J8H5lpL7tLTa/DOHcizbKx8OVvVv+rfjczkQPlLUYsF6lzI3 pZuy1xmADkwtwAGcVrw5JKyIWPqsrijywFMYKqHNKLiQ/jhKnJOIXWpK2HMJhh0hn9vT X0lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@veeam.com header.s=mx1-2022 header.b=TKrwTfOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b28-20020a631b1c000000b00477e3b523c4si2680388pgb.226.2022.12.15.03.48.00; Thu, 15 Dec 2022 03:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@veeam.com header.s=mx1-2022 header.b=TKrwTfOB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=veeam.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230177AbiLOKqz (ORCPT + 68 others); Thu, 15 Dec 2022 05:46:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230036AbiLOKqw (ORCPT ); Thu, 15 Dec 2022 05:46:52 -0500 Received: from mx1.veeam.com (mx1.veeam.com [216.253.77.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42C5A1C410; Thu, 15 Dec 2022 02:46:49 -0800 (PST) Received: from mail.veeam.com (prgmbx01.amust.local [172.24.128.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.veeam.com (Postfix) with ESMTPS id D099241D42; Thu, 15 Dec 2022 05:47:41 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=veeam.com; s=mx1-2022; t=1671101262; bh=xhll34qBllbleKx66EAPbdWrQOO5TZUZ0637lrp11Nc=; h=Date:Subject:To:CC:References:From:In-Reply-To:From; b=TKrwTfOBXBuHz/g0VqQ2IiMSFrcARyCoIRxkmMNuLSh3CfzQE5657obtdA8fxCebV VR09826PnxKczE2lZv0AUwj2g7e1g0UJoxqpvMdHcOdk+paSt3nJORTW+kYmD3ZMC/ FFpjN6uHi2LuGH4aOVDc9mb05UUXP8W1CoGb9YrzmI9/9uJIoXnq9iRbUHYAOFjz/4 3zcWPe4GuMFHoZfSqu7artJAHbCTbLAzsLG+l+bbJY2u21J8STR9+OXhgLvak5Glxs dqhFxDCLLCC1m/TQCOe0YSjPStdyUPu9S4NZAZyldw7Nj3OwWEbrHEnquUdBVbd7dz pQBWfxyL+K7sg== Received: from [172.24.10.107] (172.24.10.107) by prgmbx01.amust.local (172.24.128.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.20; Thu, 15 Dec 2022 11:46:43 +0100 Message-ID: <28b715eb-f9bc-c0d3-8dfd-22d0f84080c0@veeam.com> Date: Thu, 15 Dec 2022 11:46:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 02/21] block, blkfilter: Block Device Filtering Mechanism Content-Language: en-US To: Christoph Hellwig CC: , , , , References: <20221209142331.26395-1-sergei.shtepa@veeam.com> <20221209142331.26395-3-sergei.shtepa@veeam.com> From: Sergei Shtepa In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.24.10.107] X-ClientProxiedBy: colmbx01.amust.local (172.18.0.171) To prgmbx01.amust.local (172.24.128.102) X-EsetResult: clean, is OK X-EsetId: 37303A29240315566D7061 X-Veeam-MMEX: True X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I am very glad to see your comments, Christoph. Thank you so much for the review. I have read all the comments and agree with them. Now I see new ways to make the code of the filter and the blksnap module better. There seems to be a lot of work to be done. :)