Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp886582rwb; Thu, 15 Dec 2022 03:58:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf5ekhYcO/UESTQ4sX2t9EUIDqbI2pQcBBMaaLz9CHSDcEaOcRb2U9Nz28FsEQh4gJUEOSo/ X-Received: by 2002:a17:906:f6d7:b0:7c0:bf7c:19f4 with SMTP id jo23-20020a170906f6d700b007c0bf7c19f4mr23510850ejb.74.1671105480564; Thu, 15 Dec 2022 03:58:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671105480; cv=none; d=google.com; s=arc-20160816; b=bh4tXdrDq2SFoZblV13q1xvNZG7RahNbLbNRJWGPPmbJE6ZH7eef5wowN8aoU3eyVz jtoIRn5Weq9Szu5ClOiThZQlWo8P7GmyhWPdfrRGDLoIbPv8ZNnx5i+9WzsuEtXTXAHb dNELmRpdDiaxlELJSwylOqtCkxIlu4CzQAzRT2GX2zcSkQHlsTp3czEsL/Ucg4CS9nAQ m4N7u4CzbnRemjrKcoByDY5ahm5nBaPbfOQg9/Kz0rHQ7657H8/gIte05+V8M87boKKh Y2ZfIAqco1UuV0Fm2tDD9ICzRJ9Cn6sgY7GKn4E1ICibe71IR93M3EISPSsT3nfdbR3G uulQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=V4CdQPa/rbzK4ubCmw06k0HO9OX6GhYJ48qdtvthm70=; b=V4zc4M5LvJI7VoESh2o+BCKRc7IbaKyBFI9m4eTV7LIZCV9FINa3z31J6rjmRMtNIF PdoAnh2Y5FhAIeoQqbMZnxpb5NpPvbTbd1i2jN8CYopOLJx4prm/F2CGajgkn/jwo2wX gQV2SffGucTAXv4jTlC453cFdY0y3TcdtM2hex3ESkGmkFqBZc1L5FtRxcN0I11sXYbK 2wGE9ry1KyFsj0A8/wYpO3gt8j1fUHq3HtH9MOSgXPlxil3JWeAuLSnxEeiqmLJi+qMr hGe3MkQ85EKpmY2cbHYVCk57V0jcNQO/FNLZqjCcOqaxSCQU2x3RQO/39HcKtHviByoR A9dQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ox29-20020a170907101d00b0078d9d67841fsi11152316ejb.400.2022.12.15.03.57.43; Thu, 15 Dec 2022 03:58:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230006AbiLOK5p (ORCPT + 68 others); Thu, 15 Dec 2022 05:57:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229966AbiLOK5e (ORCPT ); Thu, 15 Dec 2022 05:57:34 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C104926C5; Thu, 15 Dec 2022 02:57:32 -0800 (PST) Received: from dggpemm500017.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NXq0z2HcMzJqZS; Thu, 15 Dec 2022 18:56:35 +0800 (CST) Received: from [10.174.178.220] (10.174.178.220) by dggpemm500017.china.huawei.com (7.185.36.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 15 Dec 2022 18:57:30 +0800 Message-ID: <02631c6e-d8b8-c6fe-7339-9471f8c13227@huawei.com> Date: Thu, 15 Dec 2022 18:57:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] ata:libata-eh:Cleanup ata_scsi_cmd_error_handler Content-Language: en-US To: Damien Le Moal , , CC: , References: <20221215100959.1926459-1-haowenchao@huawei.com> From: Wenchao Hao In-Reply-To: <20221215100959.1926459-1-haowenchao@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.220] X-ClientProxiedBy: dggpeml100011.china.huawei.com (7.185.36.193) To dggpemm500017.china.huawei.com (7.185.36.178) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/15 18:09, Wenchao Hao wrote: > If ap->ops->error_handler is NULL, just go out and release the > spinlock. This patch is just a cleanup, which would not change > the origin error handle logic. > > Signed-off-by: Wenchao Hao > --- > drivers/ata/libata-eh.c | 96 ++++++++++++++++++++--------------------- > 1 file changed, 48 insertions(+), 48 deletions(-) > Sorry, I send the wrong patch file, please ignore it