Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c963fd9-97c9-d513-a8ae-5d3f22ef57cc@i2se.com>
Date:   Thu, 15 Dec 2022 12:30:29 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH 3/7] staging: vc04_services: Drop VCHIQ_ERROR usage
To:     Umang Jain <umang.jain@ideasonboard.com>,
        linux-staging@lists.linux.dev,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Kees Cook <keescook@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Adrien Thierry <athierry@redhat.com>,
        Dan Carpenter <error27@gmail.com>,
        Dave Stevenson <dave.stevenson@raspberrypi.com>,
        Kieran Bingham <kieran.bingham@ideasonboard.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <20221215065853.34477-1-umang.jain@ideasonboard.com>
 <20221215065853.34477-4-umang.jain@ideasonboard.com>
Content-Language: en-US
From:   Stefan Wahren <stefan.wahren@i2se.com>
In-Reply-To: <20221215065853.34477-4-umang.jain@ideasonboard.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:JzvnbawC/y0=;UBeFh/McymgWzME8tQ8tjuJ9PJY
 dijUc02+A3kmFtam9pD+LZHyFGRBv+OHnSvwy4mW/tPoYiU+WGAKgMgxBp3IKGRpPpmdPR4pK
 vBMMyXmDcAXuDdCZUxp3P7+84Z1eoxqeWhn7YKszLD4QDzoo+B5OSppb3sQ+G42O97mJUAJPd
 /GBZdJ86DWugh3L6KW2JBPxfGrk29zcHi7oEeDKnXA/38dVdkhV7cnOBWJw79N6PvHJnRTvnB
 Q9O8aiwApNTui0S4ELbxbBlyMCXOPMqt+zPi3rtiiwTgUr7eOhNB9whDDpu0SbMlm8UUFVGTh
 KNOwjZZfyE8RMGX5rNeR8V2OYC2ga90r8WLSy6p+3bulp0y5dMoQxiDY/DCkSlzjCswFfFTAA
 E1rOrbi4BGPDsYTww4VpKNT4khSJWTNdNmbzt9eO+F0/7+siCEB4ArS+IK/cK+Xs9W77PYzLf
 x3yiQty8zfb1NoSCJIouEUBY3a3eJMrWiQDvONuFV0UrA7XffuSuA25zApMCQVKcXEY+os8DP
 qm70iHgVYB4eXmVUkQrH+/koWiTh/WRCBxm738wUd14andoMeUfIVfQyGzjUnBMuZ33P68IJ0
 8gRzIlo/11IEbB6xPN5WaLJduhRnv2xk9/F1V6/q/fxgpn8dH3AbUosNEYHpNkdiaVf2JahL2
 4Xl6NOY/akCvOGPhYTLDZYU5MBJUr8tKK1TqYkTpfQ==
Precedence: bulk

Hi Umang,

thanks for taking care of this.

Am 15.12.22 um 07:58 schrieb Umang Jain:
> Drop the usage of VCHIQ_ERROR vchiq_status enum type. Replace it with
> -EINVAL to report the error.

I would prefer to use adequate error codes like ENOMEM and so on. I 
agree simply replacing all VCHIQ_ERROR with -EINVAL is easier, but 
wasn't the real intention of the TODO item.

The rest of the series looks good to me.

Best regards