Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932212AbXHOOuB (ORCPT ); Wed, 15 Aug 2007 10:50:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758349AbXHOOtq (ORCPT ); Wed, 15 Aug 2007 10:49:46 -0400 Received: from mail.suse.de ([195.135.220.2]:43076 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761034AbXHOOtq (ORCPT ); Wed, 15 Aug 2007 10:49:46 -0400 Date: Wed, 15 Aug 2007 17:43:51 +0200 From: Andi Kleen To: Glauber de Oliveira Costa Cc: Andi Kleen , Glauber de Oliveira Costa , linux-kernel@vger.kernel.org, akpm@linux-foundation.org, rusty@rustcorp.com.au, mingo@elte.hu, chrisw@sous-sol.org, jeremy@goop.org, avi@qumranet.com, anthony@codemonkey.ws, virtualization@lists.linux-foundation.org, lguest@ozlabs.org, Steven Rostedt Subject: Re: [PATCH 21/25][V3] export cpu_gdt_descr Message-ID: <20070815154351.GI3406@bingen.suse.de> References: <11871823373106-git-send-email-gcosta@redhat.com> <11871823673236-git-send-email-gcosta@redhat.com> <11871823782610-git-send-email-gcosta@redhat.com> <11871823892519-git-send-email-gcosta@redhat.com> <11871823991803-git-send-email-gcosta@redhat.com> <11871824081337-git-send-email-!gcosta@redhat.com> <11871824192375-git-send-email-gcosta@redhat.com> <11871824292046-git-send-email-gcosta@redhat.com> <20070815140339.GG3406@bingen.suse.de> <5d6222a80708150725i45a064bfqfd43139338287988@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5d6222a80708150725i45a064bfqfd43139338287988@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 19 On Wed, Aug 15, 2007 at 11:25:43AM -0300, Glauber de Oliveira Costa wrote: > On 8/15/07, Andi Kleen wrote: > > > +#ifdef CONFIG_PARAVIRT > > > +extern unsigned long *cpu_gdt_descr; > > > > No externs in .c files > > > > Normally they should be where the variable is defined > > anyways. > Given that this variable is defined in head.S, what do you propose? Move it to C code first. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/