Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932850AbXHOOxe (ORCPT ); Wed, 15 Aug 2007 10:53:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1765523AbXHOOxG (ORCPT ); Wed, 15 Aug 2007 10:53:06 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:3683 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756877AbXHOOxD (ORCPT ); Wed, 15 Aug 2007 10:53:03 -0400 Date: Wed, 15 Aug 2007 22:52:07 +0800 From: Herbert Xu To: Satyam Sharma Cc: Stefan Richter , Heiko Carstens , Chris Snook , clameter@sgi.com, Linux Kernel Mailing List , linux-arch@vger.kernel.org, Linus Torvalds , netdev@vger.kernel.org, Andrew Morton , ak@suse.de, davem@davemloft.net, schwidefsky@de.ibm.com, wensong@linux-vs.org, horms@verge.net.au, wjiang@resilience.com, cfriesen@nortel.com, zlynx@acm.org, rpjday@mindspring.com, jesper.juhl@gmail.com, segher@kernel.crashing.org Subject: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures Message-ID: <20070815145207.GA23106@gondor.apana.org.au> References: <46C2350A.1010807@redhat.com> <20070815081841.GA16551@osiris.boeblingen.de.ibm.com> <46C30540.2070603@s5r6.in-berlin.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 23 On Wed, Aug 15, 2007 at 08:05:38PM +0530, Satyam Sharma wrote: > > > I don't know if this here is affected: > > Yes, I think it is. You're clearly expecting the read to actually happen > when you call get_hpsb_generation(). It's clearly not a busy-loop, so > cpu_relax() sounds pointless / wrong solution for this case, so I'm now > somewhat beginning to appreciate the motivation behind this series :-) Nope, we're calling schedule which is a rather heavy-weight barrier. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/