Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <28eceb7c-fbd7-896b-8951-f640cd510c4c@linaro.org>
Date:   Thu, 15 Dec 2022 14:01:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: pm8941-rtc add alarm register
Content-Language: en-US
To:     Eric Chanudet <echanude@redhat.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Andrew Halaney <ahalaney@redhat.com>,
        Brian Masney <bmasney@redhat.com>
References: <20221214210908.1788284-1-echanude@redhat.com>
 <20221214210908.1788284-3-echanude@redhat.com>
From:   Konrad Dybcio <konrad.dybcio@linaro.org>
In-Reply-To: <20221214210908.1788284-3-echanude@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 14.12.2022 22:09, Eric Chanudet wrote:
> A few descriptions including a qcom,pm8941-rtc describe two reg-names
> for the "rtc" and "alarm" register banks, but only one offset. For
> consistency with reg-names, add the "alarm" register offset. No
> functional change is expected from this.
> 
> Signed-off-by: Eric Chanudet <echanude@redhat.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/pm8150.dtsi      | 2 +-
>  arch/arm64/boot/dts/qcom/pm8916.dtsi      | 3 ++-
>  arch/arm64/boot/dts/qcom/pm8950.dtsi      | 2 +-
>  arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi | 2 +-
>  arch/arm64/boot/dts/qcom/pmp8074.dtsi     | 2 +-
>  arch/arm64/boot/dts/qcom/pms405.dtsi      | 2 +-
>  6 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/pm8150.dtsi b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> index 574fa95a2871..db90c55fa2cf 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150.dtsi
> @@ -121,7 +121,7 @@ pm8150_adc_tm: adc-tm@3500 {
>  
>  		rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  		};
> diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> index 08f9ca006e72..e2a6b66d8847 100644
> --- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
> @@ -93,7 +93,8 @@ adc-chan@f {
>  
>  		rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
> +			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>;
>  		};
>  
> diff --git a/arch/arm64/boot/dts/qcom/pm8950.dtsi b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> index 07c3896bd36f..d7df4ad60509 100644
> --- a/arch/arm64/boot/dts/qcom/pm8950.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8950.dtsi
> @@ -126,7 +126,7 @@ xo-therm-buf@3c {
>  
>  		rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  		};
> diff --git a/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi b/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi
> index 20c5d60c8c2c..ee1e428d3a6e 100644
> --- a/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmm8155au_1.dtsi
> @@ -108,7 +108,7 @@ pmm8155au_1_adc_tm: adc-tm@3500 {
>  
>  		pmm8155au_1_rtc: rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  
> diff --git a/arch/arm64/boot/dts/qcom/pmp8074.dtsi b/arch/arm64/boot/dts/qcom/pmp8074.dtsi
> index ceb2e6358b3d..580684411d74 100644
> --- a/arch/arm64/boot/dts/qcom/pmp8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmp8074.dtsi
> @@ -74,7 +74,7 @@ vph-pwr@131 {
>  
>  		pmp8074_rtc: rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  			allow-set-time;
> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> index ffe9e33808d0..22edb47c6a84 100644
> --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> @@ -125,7 +125,7 @@ xo_therm: xo_temp@76 {
>  
>  		rtc@6000 {
>  			compatible = "qcom,pm8941-rtc";
> -			reg = <0x6000>;
> +			reg = <0x6000>, <0x6100>;
>  			reg-names = "rtc", "alarm";
>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
>  		};