Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1214883rwb; Thu, 15 Dec 2022 07:39:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5fvnXPeMXrfreIlRoRDQk95e4WlWaXwEFZi/6xzflVmfGNriNgS+5DeS4iBFT/dKvU73fO X-Received: by 2002:a05:6402:5298:b0:462:32d2:9696 with SMTP id en24-20020a056402529800b0046232d29696mr22931146edb.2.1671118766354; Thu, 15 Dec 2022 07:39:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671118766; cv=none; d=google.com; s=arc-20160816; b=o0My4PfH1gWpZZQBUoybsvpp9S6rm+Az0uhYsORjFkik4gxZdMLU6vBLAYTFOrLk6m WdU/w98o1WFO3gkKtlZS9qU2XpSBExdqZgobnPwH0M/heIAONycuXSjWPMcbMx8f0wyT 1cCvXswk4hzTkw0NS1cDC41V6spiXV76TMqDRE1xOibSps+xTcXqRVAaUI221wZjvrZ0 1q7qyZpHM5FG71k9GJU5ZBB2iKZl6KSkvRmZi1X1ApoAKi/s8PoNNLd+DaufrPmZADZ4 DT28B0oGestXF6yyWqGdU8KcIxO2wBWh1R+jUluh+aUI7vYyOoWMGN9ALpAu8DPC80d+ yBCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :references:in-reply-to:message-id:cc:to:from:date:dkim-signature; bh=3zeWx/VcZJ+nKDoxQSjrPrYjj2F0B/NTv4M2nB0Taxo=; b=z2Bqr+Ur/hRNawXwdeAMtzShxIXu1w5Bh68A6bY0dP7na0x7SO7cUQYzrKcNwGNiEj oV2JXRpwBuIJ4/4+gb5AnhsKDrluwwLR4SIshtFdZNTRaXJ49jV0nAQMxcn+WzIWXAcK oxq7AhQfeFopU6hXtp19McRCYp3kgzws1SpEWEXNy4oFG/F2IurS83jbY08MNPS5qVvQ hqYIKf8A10mQfzVzjWVaTElGDGiC3pJf7bqvLfdTWSVf0fMb6unUQ9XOd2HxEm66gdyg Vc5D/oOHm/52os/jQrquKztPypQWOQOmCzNDyKkMtai973wuEphP3A5/0Z5Y4faC3DEL 3fag== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=XGVRecjP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g3-20020a056402320300b004612505ece4si6787131eda.483.2022.12.15.07.39.09; Thu, 15 Dec 2022 07:39:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=XGVRecjP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229634AbiLOPN6 (ORCPT + 69 others); Thu, 15 Dec 2022 10:13:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbiLOPN1 (ORCPT ); Thu, 15 Dec 2022 10:13:27 -0500 X-Greylist: delayed 524 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 15 Dec 2022 07:12:44 PST Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BFA4932B8F; Thu, 15 Dec 2022 07:12:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:Mime-Version: References:In-Reply-To:Message-Id:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3zeWx/VcZJ+nKDoxQSjrPrYjj2F0B/NTv4M2nB0Taxo=; b=XGVRecjPvKN1DiEoK3zrmKwJgf dWEDw4jOTpFgBvU8dBgihUP5XjHpeVRupNcj9IXw94trWULMNnwKW6wd8vZm6vJvGCGOY2VGxY52j vzJ+xy7fEf/F7RUY0ktMDb2XSAVik9jhS46pHut3Gv9K2eA6+iID9ubN+OgosU4QMFZc=; Received: from modemcable168.174-80-70.mc.videotron.ca ([70.80.174.168]:48106 helo=pettiford) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1p5puc-0000OA-0h; Thu, 15 Dec 2022 10:12:42 -0500 Date: Thu, 15 Dec 2022 10:12:41 -0500 From: Hugo Villeneuve To: Alexandre Belloni Cc: Alessandro Zummo , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20221215101241.993999be8b51f133fb11bfba@hugovil.com> In-Reply-To: References: <20220309162301.61679-1-alexandre.belloni@bootlin.com> <20220309162301.61679-11-alexandre.belloni@bootlin.com> <20220310110918.41a681474f5a0e11abdedc39@hugovil.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 70.80.174.168 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 Subject: Re: [PATCH 11/29] rtc: pcf2127: set RTC_FEATURE_ALARM_RES_2S X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 10 Mar 2022 21:58:49 +0100 Alexandre Belloni wrote: > On 10/03/2022 11:09:18-0500, Hugo Villeneuve wrote: > > On Wed, 9 Mar 2022 17:22:42 +0100 > > Alexandre Belloni wrote: > > > > > The PCF2127 doesn't support UIE because setting an alarm to fire every > > > second confuses the chip and the fastest we can go is an alarm every 2 > > > seconds. > > > > Hi Alexandre, > > can you describe what "confuses the chip" means? > > > > In my experimental PCF2131 driver, I activated UIE and it seems to be working fine at 1s intervals, but since it is similar to PCF2127, maybe there is still a problem and I just didn't see it. > > > > Did you remove uie_unsupported? Else, you may have been using uie > emulation. In my tests last year, the pcf2127 was failing to reassert > the interrupt if an alarm was set every second. The same happens on > other NXP based RTCs (i.e. including microcrystal ones). > > I'm going to test again soon (and also reply to your series). Hi Alexandre, after 9 months, I decided to resend my PCF2131 driver serie (V3), rebased on your latest rtc-next branch. I would appreciate if you or someone could take a look at it and comment. Thank you, Hugo Villeneuve > > > Signed-off-by: Alexandre Belloni > > > --- > > > drivers/rtc/rtc-pcf2127.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c > > > index f8469b134411..63b275b014bd 100644 > > > --- a/drivers/rtc/rtc-pcf2127.c > > > +++ b/drivers/rtc/rtc-pcf2127.c > > > @@ -656,6 +656,7 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, > > > pcf2127->rtc->range_min = RTC_TIMESTAMP_BEGIN_2000; > > > pcf2127->rtc->range_max = RTC_TIMESTAMP_END_2099; > > > pcf2127->rtc->set_start_time = true; /* Sets actual start to 1970 */ > > > + set_bit(RTC_FEATURE_ALARM_RES_2S, pcf2127->rtc->features); > > > clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, pcf2127->rtc->features); > > > clear_bit(RTC_FEATURE_ALARM, pcf2127->rtc->features); > > > > > > -- > > > 2.35.1 > > > > > > > > > -- > > Hugo Villeneuve > > -- > Alexandre Belloni, co-owner and COO, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > -- Hugo Villeneuve