Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221214220727.1350784-1-jcormier@criticallink.com>
 <20221214220727.1350784-2-jcormier@criticallink.com> <29f4e14f-a81a-d440-b564-5360f44c65c1@linaro.org>
 <CADL8D3ZUE5WbV0oS6hEVUNh9asrhTKQeGR4McR6Kh6qykSFw=Q@mail.gmail.com>
In-Reply-To: <CADL8D3ZUE5WbV0oS6hEVUNh9asrhTKQeGR4McR6Kh6qykSFw=Q@mail.gmail.com>
From:   Jon Cormier <jcormier@criticallink.com>
Date:   Thu, 15 Dec 2022 09:37:27 -0500
Message-ID: <CADL8D3ZT5znWjhpQpv6u-LTJfHNpkSrHZ-j-Hh_cgCZyTKw=Pg@mail.gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: adi,ltc2945: Add binding
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Bob Duke <bduke@criticallink.com>,
        John Pruitt <jpruitt@criticallink.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Resending reply in plain text

On Thu, Dec 15, 2022 at 9:35 AM Jon Cormier <jcormier@criticallink.com> wrote:
>
> On Thu, Dec 15, 2022 at 4:42 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 14/12/2022 23:07, Cormier, Jonathan wrote:
>>
>> Missing commit msg. Describe hardware.
>
> Thanks
>>
>>
>>
>>
>> > Signed-off-by: "Cormier, Jonathan" <jcormier@criticallink.com>
>> > ---
>> >  .../bindings/hwmon/adi,ltc2945.yaml           | 50 +++++++++++++++++++
>> >  1 file changed, 50 insertions(+)
>> >  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
>> >
>> > diff --git a/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
>> > new file mode 100644
>> > index 000000000000..9ca7a886dec8
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/hwmon/adi,ltc2945.yaml
>> > @@ -0,0 +1,50 @@
>> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> > +%YAML 1.2
>> > +---
>> > +$id: http://devicetree.org/schemas/hwmon/adi,ltc2945.yaml#
>> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> > +
>> > +title: Analog Devices LTC2945 wide range i2c power monitor
>> > +
>> > +maintainers:
>> > +  - Guenter Roeck <linux@roeck-us.net>
>> > +
>> > +description: |
>> > +  Analog Devices LTC2945 wide range i2c power monitor over I2C.
>> > +
>> > +  https://www.analog.com/media/en/technical-documentation/data-sheets/LTC2945.pdf
>> > +
>> > +properties:
>> > +  compatible:
>> > +    enum:
>> > +      - ltc2945
>>
>> That's not a correct compatible. Missing vendor prefix.
>>
> Okay, I assume I'll need to update the driver as well to handle that.
>>
>> > +
>> > +  reg:
>> > +    maxItems: 1
>> > +
>> > +  shunt-resistor-micro-ohms:
>> > +    description:
>> > +      Shunt resistor value in micro-Ohms
>> > +    default: 1000
>> > +
>> > +required:
>> > +  - compatible
>> > +  - reg
>> > +
>> > +
>>
>> Just one blank line.
>>
>> > +additionalProperties: false
>> > +
>> > +examples:
>> > +  - |
>> > +    i2c {
>> > +           #address-cells = <1>;
>> > +           #size-cells = <0>;
>>
>> Use 4 spaces for example indentation.
>>
>> > +
>> > +           ltc2945_i2c: ltc2945@6e {
>>
>> Node names should be generic.
>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>>
>> > +              compatible = "ltc2945";
>> > +              reg = <0x6e>;
>> > +              /* 10 milli-Ohm shunt resistor */
>> > +              shunt-resistor-micro-ohms = <10000>;
>> > +           };
>> > +    };
>> > +...
>>
>> Best regards,
>> Krzysztof
>>
>
>
> --
> Jonathan Cormier
> Software Engineer
>
> Voice:  315.425.4045 x222
>
>
>
> http://www.CriticalLink.com
> 6712 Brooklawn Parkway, Syracuse, NY 13211
>
>


-- 
Jonathan Cormier
Software Engineer

Voice:  315.425.4045 x222


http://www.CriticalLink.com
6712 Brooklawn Parkway, Syracuse, NY 13211