Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932879AbXHOPdd (ORCPT ); Wed, 15 Aug 2007 11:33:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760055AbXHOPdZ (ORCPT ); Wed, 15 Aug 2007 11:33:25 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:38246 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1760697AbXHOPdY (ORCPT ); Wed, 15 Aug 2007 11:33:24 -0400 Date: Wed, 15 Aug 2007 11:33:22 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Tejun Heo cc: Michal Piotrowski , Florin Iucha , Greg KH , USB development list , Linux Kernel Mailing List Subject: Re: [linux-usb-devel] USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351 In-Reply-To: <46C313B3.4030700@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 34 On Wed, 15 Aug 2007, Tejun Heo wrote: > Alan Stern wrote: > > I think we can simply remove the error message. There's no obvious > > reason why sysfs_remove_bin_file() should complain about attempts to > > remove a nonexistent file; sysfs_remove_file() doesn't. > > > > This patch will get rid of the annoying error messages. It won't do > > anything about your keyboard's tendency to spontaneously stop working, > > alas. > > Agreed but I think sysfs_remove_bin_file() should relay the return value > from sysfs_has_and_remove() to the caller. Perhaps. But none of sysfs_remove_one() sysfs_remove_subdir() sysfs_remove_dir() sysfs_remove_file() sysfs_remove_file_from_group() sysfs_remove_group() sysfs_remove_link() return a value. Why should sysfs_remove_bin_file() be different? And what callers would pay attention to the return value? Alan Stern - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/