Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a279467764c063fccf28c7d8fdfac2ab57570fee.camel@gmail.com>
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add
 cirrus,ep9301-adc description
From:   Alexander Sverdlin <alexander.sverdlin@gmail.com>
To:     Rob Herring <robh@kernel.org>
Cc:     linux-iio@vger.kernel.org,
        Hartley Sweeten <hsweeten@visionengravers.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Thu, 15 Dec 2022 17:25:04 +0100
In-Reply-To: <20221215161835.GA138650-robh@kernel.org>
References: <20221214222024.951984-1-alexander.sverdlin@gmail.com>
         <20221215161835.GA138650-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 
MIME-Version: 1.0
Precedence: bulk

Thanks Krzysztof, Rob,

I'll incorporate your comments into the next version, but...

On Thu, 2022-12-15 at 10:18 -0600, Rob Herring wrote:
> > +=C2=A0 clock-names:
> > +=C2=A0=C2=A0=C2=A0 const: ep93xx-adc
>=20
> Weird name for a clock. Generally is signal name or what it=20
> controls (e.g. bus, core, etc.). Perhaps just drop it.
>=20
> > +
> > +=C2=A0 interrupts:
> > +=C2=A0=C2=A0=C2=A0 maxItems: 1
> > +
> > +required:
> > +=C2=A0 - compatible
> > +=C2=A0 - reg
> > +=C2=A0 - clocks
> > +=C2=A0 - clock-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +=C2=A0 - |
> > +=C2=A0=C2=A0=C2=A0 #include <dt-bindings/clock/cirrus,ep93xx-clock.h>

your robot was right, this dependency is missing, I thought I can prepare
the ADC driver in advance, but seems it has to go together with the whole
DT conversion of the EP93xx series.

--=20
Alexander Sverdlin.