Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <20ea6828-8ca9-3106-7eac-00fd9cec5fed@intel.com>
Date:   Thu, 15 Dec 2022 09:19:09 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.0
Subject: Re: [PATCH v9 07/13] x86/resctrl: Introduce data structure to support
 monitor configuration
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu>
 <166990900849.17806.5346239458898437535.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166990900849.17806.5346239458898437535.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDhyKzdXTk4vZmVTQVVZSUF3SEx0dkd5bXN6WHNZVmtJNmI1cmtXTDdqMGxh?=
 =?utf-8?B?bHZZZHN6TU1UZ2Z2UWVMZlpMNm44ejhxNUVYaXhzN1FCUjEzWGpSQUtCS3gz?=
 =?utf-8?B?MUcvSWFiZDhUR1BjTnJmejF6Ny82aUg0OTM0K1pmMUIwQW41ZVhxRHJXcHZs?=
 =?utf-8?B?ZkwyRitrWVJwY055S0xLczBVWUlCTWV4NHNITitSdzRVWENxNkc0ZGlCMXNz?=
 =?utf-8?B?cFBZR1VXbjZZS3ltS3hxYXFFY0xhZFEySis3U2duTmRCdXY2NHVDd3kzbkhp?=
 =?utf-8?B?RnJ6OTlMbElTS3F2d1NRK0ZQdlhhVjM4Zkp2Qks0U3lHaG0yNldFZ3h4WE4y?=
 =?utf-8?B?SHM4OWJ2TTQyTVJseUNaTlVZUmxuU3JjN1lVSmR1QnZ2Z285VGlhdmh1Q1Fo?=
 =?utf-8?B?Y1hlQkFVWDdFVzdRNWQwWlFQaUJhWURpQ1kxMW04QnFMTVZZdWxvRGJ3VmpP?=
 =?utf-8?B?VDVIdTl5d2l3RHlGU2c1aVIwOE0yM3VlbXRZVmt3R0cvOVh5TjRCaGV3WkNF?=
 =?utf-8?B?b2JQNEVyYWljNUd2RHZzek5jSDA3UmllWVdFQmhFS3BjMFBHaWdjMzIwL0FE?=
 =?utf-8?B?MHhnSUVYemp6ZWdnU09EMEpBbWoxcUFJTGFDeFYxd2tSU0xtMzVLSjFldU4z?=
 =?utf-8?B?QnVpNHNQOWg0UEpkUHpsR0lpQkNkcHJIcUlnOEQweHNBSkNBQUNyVUxEQVZU?=
 =?utf-8?B?SEUwSy9tZ3JTT2VFbDN0UmJDVlIwSmRqYThyTnE4WUVvdFRWUFIwT29OQ1Ft?=
 =?utf-8?B?V0I3S0ZsWXRUSGxNMXlSS1NndENQcURqcFRhU0EzUlZmeDRYVlRScVFaV09i?=
 =?utf-8?B?akRxb1lkeVo4QnJQRU5vdGRWbWgyL0lQZllhd2txL1BFZ3JYdkhYanpRdU1k?=
 =?utf-8?B?SGxmOHRkdllHUjVuZ0hjWWxMZnhKM2pMR2hzUEtSKzVuUENBY3VWVXJzNVI1?=
 =?utf-8?B?RGxCNkhVK3lQT1A1eVdoMk9LYU1udUd4NkNPQ0NsUldMOGU1QkFDQy9CRUUr?=
 =?utf-8?B?OE9ZczNreFR2bkFZaWdvNUNEcXdPS0p3U2tQdUppdFRLOEFIY2lwbHRPU0I2?=
 =?utf-8?B?ZStvY3QxYzJzTnppY0hoK09VaFEyM2pyZW85RE45ZWd5bm5EVzZ1UTc4K2Vu?=
 =?utf-8?B?cTZyTU5kMm56MjZiSHFzRXlNR1duczRvQnJRQTJNU0FWcmRPRzN6SmNLS1hX?=
 =?utf-8?B?S2RibmNzd0UwSnBZY21UM3g5K2E3Q0pvaS9kYzhYd1VhZG5zR2pibzB4bEI0?=
 =?utf-8?B?bjFndWtTS29GZi9EQkNnd3oxdVpScXlyclp0NTcxbktqbUxaWTNCTzA0bWw2?=
 =?utf-8?B?N2EyTVplSDVKeG90ZTQvWGNZclhkaXRHaldlcy9nTmVnQXM1TEtBZ0g0bERl?=
 =?utf-8?B?T0ZZcW0xNVFsZW0rVTR0a0tTUnY2YUhKcEJzQjBSWVNXVVBBOHFjdHl1QmNy?=
 =?utf-8?B?N2ZTbndnQnZXdVBENTI4YkxIYUlHMW1ESTJySmdQdkY2R3VBczBuUml0VDdZ?=
 =?utf-8?B?ZHZwOXZQZlpLVFc2b1NreVlMV2V0dUcxOXNtYTl5S0lIMm1BNEpOamthRzNJ?=
 =?utf-8?B?ODY0clNCUFJlMWFVN1RVN3RXNm1XY1BMR0EwSGtRUVNlci94c2FnbHRNVUtn?=
 =?utf-8?B?RjQrWjh4a09aa21yUW9IMFNRbUM1NndQNDVyaFFaNDdCY1hZVzgvMG9OR01K?=
 =?utf-8?B?YlE3aFQxVGI2Z1Z2bzkrTml4SkhKSVFUclB0cDJzYW05Y0VKblRNR1F4OE5X?=
 =?utf-8?B?QVFlVDBOcHZmdEZWRlN6Y2YyVk0vUmg0dzErUWVjMzJXckpBK2pGbS9qczd1?=
 =?utf-8?B?MS9Jc0owSi9NdG5KcEhyZzhJM0w2WXFrSjBVa2lFRmwyWG84ak1PYzNuaW9R?=
 =?utf-8?B?UGVpUXVkQlB2RHh0ZGdwR3BEVlJadmtUV2o5aWdQTXRZZXBYWlhuWjFwSFpY?=
 =?utf-8?B?UmRNOExaVjRsWjFJNGxjZEFQbWl2OElNemlnUDFyeXhrTlZRdWRBMStEbEVQ?=
 =?utf-8?B?dnZzV2o4MEd6a1p0NFl1b1pWYW9yNHN5aWo1ZTRWMEVLWGtoNVUzdFJzZmtS?=
 =?utf-8?B?c1lkdDlETGhiRjRJbUk0dkZXWGU5UHI3dlBtSFU4UG5sajZuUnNaVzdDUTJK?=
 =?utf-8?B?M0x4Z1VwckhjNlROaG8rT2ViUllqQ3JXVzEyU28vaHNicXBxdXpQRWxkTEw4?=
 =?utf-8?B?T2c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f90ee113-fb61-4921-f30f-08dadec07c4a
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 17:19:12.8907
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M3rh13+dS0aA0/9ouCOzb/FI2Xw0r4ROwz7kzsGY5+ajMDj/yWrTfnMpfAQYeHR9hpZTF28+r3eQZjB3XgBhLdKCpLeoJKEcDJDob7swsD4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5560
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

I do not see a new data structure introduced. Perhaps subject
could just be:
x86/resctrl: Support monitor configuration

On 12/1/2022 7:36 AM, Babu Moger wrote:
> Add a new field in mon_evt to support Bandwidth Monitoring Event

"mon_evt" -> "struct mon_evt"

> Configuration(BMEC) and also update the "mon_features" display.
> 
> The resctrl file "mon_features" will display the supported events
> and files that can be used to configure those events if monitor
> configuration is supported.
> 
> Before the change.
> 	$cat /sys/fs/resctrl/info/L3_MON/mon_features
> 	llc_occupancy
> 	mbm_total_bytes
> 	mbm_local_bytes
> 
> After the change when BMEC is supported.
> 	$cat /sys/fs/resctrl/info/L3_MON/mon_features
> 	llc_occupancy
> 	mbm_total_bytes
> 	mbm_total_bytes_config
> 	mbm_local_bytes
> 	mbm_local_bytes_config
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  arch/x86/kernel/cpu/resctrl/internal.h |    2 ++
>  arch/x86/kernel/cpu/resctrl/monitor.c  |    7 +++++++
>  arch/x86/kernel/cpu/resctrl/rdtgroup.c |    5 ++++-
>  3 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 7bbfc10094b6..b36750334deb 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -52,11 +52,13 @@ DECLARE_STATIC_KEY_FALSE(rdt_mon_enable_key);
>   * struct mon_evt - Entry in the event list of a resource
>   * @evtid:		event id
>   * @name:		name of the event
> + * @configurable:	true if the event is configurable
>   * @list:		entry in &rdt_resource->evt_list
>   */
>  struct mon_evt {
>  	enum resctrl_event_id	evtid;
>  	char			*name;
> +	bool			configurable;
>  	struct list_head	list;
>  };
>  
> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
> index e33e8d8bd796..b39e0eca1879 100644
> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
> @@ -783,6 +783,13 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
>  	if (ret)
>  		return ret;
>  
> +	if (rdt_cpu_has(X86_FEATURE_BMEC)) {
> +		if (rdt_cpu_has(X86_FEATURE_CQM_MBM_TOTAL))
> +			mbm_total_event.configurable = true;
> +		if (rdt_cpu_has(X86_FEATURE_CQM_MBM_LOCAL))
> +			mbm_local_event.configurable = true;
> +	}
> +
>  	l3_mon_evt_init(r);
>  
>  	r->mon_capable = true;
> diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> index 8a3dafc0dbf7..8342feb54a7f 100644
> --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
> @@ -1001,8 +1001,11 @@ static int rdt_mon_features_show(struct kernfs_open_file *of,
>  	struct rdt_resource *r = of->kn->parent->priv;
>  	struct mon_evt *mevt;
>  
> -	list_for_each_entry(mevt, &r->evt_list, list)
> +	list_for_each_entry(mevt, &r->evt_list, list) {
>  		seq_printf(seq, "%s\n", mevt->name);
> +		if (mevt->configurable)
> +			seq_printf(seq, "%s_config\n", mevt->name);
> +	}
>  
>  	return 0;
>  }
> 
> 

With subject and changelog changes:

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette