Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221215163046.4079767-1-arnd@kernel.org>
In-Reply-To: <20221215163046.4079767-1-arnd@kernel.org>
From:   Alexander Potapenko <glider@google.com>
Date:   Thu, 15 Dec 2022 17:39:37 +0100
Message-ID: <CAG_fn=W6TfkPiv57aFEizsmyA9NLGdPa4_CczrSd8dFsL_xSyQ@mail.gmail.com>
Subject: Re: [PATCH] kmsan: include linux/vmalloc.h
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Marco Elver <elver@google.com>,
        Dmitry Vyukov <dvyukov@google.com>, kasan-dev@googlegroups.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Dec 15, 2022 at 5:30 PM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> This is needed for the vmap/vunmap declarations:
>
> mm/kmsan/kmsan_test.c:316:9: error: implicit declaration of function 'vma=
p' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>         vbuf =3D vmap(pages, npages, VM_MAP, PAGE_KERNEL);
>                ^
> mm/kmsan/kmsan_test.c:316:29: error: use of undeclared identifier 'VM_MAP=
'
>         vbuf =3D vmap(pages, npages, VM_MAP, PAGE_KERNEL);
>                                    ^
> mm/kmsan/kmsan_test.c:322:3: error: implicit declaration of function 'vun=
map' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
>                 vunmap(vbuf);
>                 ^
>
> Fixes: 8ed691b02ade ("kmsan: add tests for KMSAN")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Alexander Potapenko <glider@google.com>

> ---
>  mm/kmsan/kmsan_test.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/mm/kmsan/kmsan_test.c b/mm/kmsan/kmsan_test.c
> index eb44ef3c5f29..088e21a48dc4 100644
> --- a/mm/kmsan/kmsan_test.c
> +++ b/mm/kmsan/kmsan_test.c
> @@ -22,6 +22,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/string.h>
>  #include <linux/tracepoint.h>
> +#include <linux/vmalloc.h>
>  #include <trace/events/printk.h>
>
>  static DEFINE_PER_CPU(int, per_cpu_var);
> --
> 2.35.1
>


--=20
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Stra=C3=9Fe, 33
80636 M=C3=BCnchen

Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg