Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 09:35:22 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Davidlohr Bueso <dave@stgolabs.net>,
        Luis Chamberlain <mcgrof@kernel.org>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Lucas De Marchi <lucas.de.marchi@gmail.com>,
        <alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>,
        <a.manzanares@samsung.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/acpi: fix null dereference on probe for missing
 ACPI_COMPANION()
Message-ID: <639b5adada2e6_b05d1294e4@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221209062919.1096779-1-mcgrof@kernel.org>
 <63937afd72956_579c1294eb@dwillia2-xfh.jf.intel.com.notmuch>
 <6393a3a9d2882_579c1294b3@dwillia2-xfh.jf.intel.com.notmuch>
 <Y5kAt3WRgncTj26x@bombadil.infradead.org>
 <63991ec886e85_b05d1294a6@dwillia2-xfh.jf.intel.com.notmuch>
 <Y5pU4XTchSKVqkjx@bombadil.infradead.org>
 <20221215060410.2p653tgqw35q6wbz@offworld>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221215060410.2p653tgqw35q6wbz@offworld>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?i7nmxTHYKjwfWwbxUYka9B6SHPjJ0SLC+lLUJOsvIlYK/e5Dtzy7r0uWwvPv?=
 =?us-ascii?Q?CYYClSa1tdqe5qrOWTeOPutLqyZGWG5qN2qZs/PeoXXeRPjX1D7PsrExmFDn?=
 =?us-ascii?Q?MmU/F5Xm/ryniPjPVsUDX0YH283wgs7OZkSxrQA+Iti+M3awDUK6l50hC6G0?=
 =?us-ascii?Q?8PeJAmpP4j6zjejDWZ6HJa9+nsYD9h5fJq0FCPx1DYILGQvVDUloqlWF2zpN?=
 =?us-ascii?Q?X4Nh+8UnRvFg0H+4RafKecRdTRqEnzQODnSmRTDRQGfwVNLCSpbmcilapWkc?=
 =?us-ascii?Q?9AqGMchMzGmQR7dfJ1NvJJEljoqiMLK4yS5GTHho0rOJGcpOGjOQF2LAOxnD?=
 =?us-ascii?Q?t7C0KeP1zD9tRiie8E5TvdgSo7rHRXdG7eLD33AuO/eWkjgo83M1plEiHgBd?=
 =?us-ascii?Q?5AZg+M5oH3X6+TseerMkzDhDX/T4yKwu95jz0ndbDYT6QmUVQ9YH3mJ53QyP?=
 =?us-ascii?Q?NMY3LFbqq/TkHqYLYIxAA/KOc/Dg8eRhKRqoEGRjNgB3qwzdhxTiQT/3GRQv?=
 =?us-ascii?Q?EzFOA8iIivANsVByyV+3HFMefR/FvJ87aUR1GvpbfMY6H5MfZA7p1IhQy9Ry?=
 =?us-ascii?Q?eNg1sVM9iU01Ij6/ERIUfbjDwYhtub6+gKzyR6vQyjDpMY0tHjOkYFxtlEPR?=
 =?us-ascii?Q?17Xy4oHoo13G4BScanUka8ZXU7IKqxwfWQ+LjibkUOTgJpzKXjLLzLIz+rjx?=
 =?us-ascii?Q?11mu4szSa6UQT6OQ13XmLwQTm2DwOSAp4a1cuB2n5+pTkfcljG8wXVtmtIQZ?=
 =?us-ascii?Q?MieHb+CksZjHXRJIcUKkRag7aoKZnVLCjY1xzIcgERiXetwLEeY5hfXG5Q+M?=
 =?us-ascii?Q?PXGbQgMnmSg9qnWHPxv6sPzwFmMnpzmDC+taA5g1nJiblnbop31SiDYz5P5O?=
 =?us-ascii?Q?MOZF7bmoR8s/dt4RRma4DbG2vwpDTsQ76XELPh5W2GxvY67GbABDD2kR9i87?=
 =?us-ascii?Q?O5i0oqLxMOfwsTfm+QIaTPSfVV+4f1x4Pxr9kQT0KZK+O7La+ch9s+UmiN4D?=
 =?us-ascii?Q?yCnKuIxf1FOdGLnRHRoWCMKEyZAzcKr2XvDcWv7lRJRu9hTJ+QBvW7RoXJGS?=
 =?us-ascii?Q?TiYMEpRbgMUn1eduphkr+1V7iOhvKQy3shcyzDK6Z+gDi+w6LJ4smz111MYr?=
 =?us-ascii?Q?HwQTAk5CXnINdLlUN0x5NNyAqxkP16pxBtKE42AJ1Q8detUbcJG5a7iYHcdu?=
 =?us-ascii?Q?uv1mPc30Wc4aENZZ0FlLguBMndHDxzylVm1+Pm8Lpx7LdGgfi7/a5HCDTrcB?=
 =?us-ascii?Q?kIbEVk8GuA1kGFjAM9bBWmFKap5Mf5lBBio+Q8KY+0EJ35AI+UngEWaY4bS0?=
 =?us-ascii?Q?1KzBg7Qw2nKRJnqlqbSZtvG+jvhNJZlov3i315rG41yh28bW571kNChc+vb7?=
 =?us-ascii?Q?DihOdy8BK1O4VrAhPV/hHvy966r4pNnAkon6LQDK8c5PYiqs6J/tAO94XcHR?=
 =?us-ascii?Q?qFwqkc2ptgsCYk7zAfFh/hB26Ywd5AD13lrG5bEFHOQO+ghOXtYwWFr/Tgg2?=
 =?us-ascii?Q?y86lbwwlI7PJIWazbuvacpaD8ltB5VqXFL6BbISpYSImzzzoqoDEprXpcMj/?=
 =?us-ascii?Q?YtxTRCUzlcSi/xHW0itTydBqCt810WmZDcgJ4gsqE0Zh8E3oIRIla6emF1vM?=
 =?us-ascii?Q?NQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 295f8983-86f6-4271-f603-08dadec2bffc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 17:35:25.4738
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ehKUZ5Sv4CHScRjE7fjnBEMgCBwhlZsUn+u1VG88EzQZBE+Um+MJ1XnW2lEKEsc11ttnW9OmdBd2b2MUO5nhpl7UOp7lAgYyO/xffrVkyWk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4823
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Davidlohr Bueso wrote:
> On Wed, 14 Dec 2022, Luis Chamberlain wrote:
> 
> >Groovy thanks. Progress, but still fails now on the cxl-xor-region.sh line 29
> >
> >https://gist.github.com/mcgrof/aeac639365a651bd77f143cf38eb7493
> 
> Unrelated, but looking at this log I noticed that we should limit the amount
> of noise "Bypassing cpu_cache_invalidate_memregion() for testing" emits.
> 
> Thanks,
> Davidlohr
> 
> -----8<-------------------------------------
> [PATCH] cxl/region: Only warn about cpu_cache_invalidate_memregion() once
> 
> No need for more than once per region.

Hmm, the below isn't once per region, it's once per cxl_core module
load.

> 
> Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
> ---
>   drivers/cxl/core/region.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c
> index b1281f528d7f..f367d1c10357 100644
> --- a/drivers/cxl/core/region.c
> +++ b/drivers/cxl/core/region.c
> @@ -2006,8 +2006,7 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr)
>   
>   	if (!cpu_cache_has_invalidate_memregion()) {
>   		if (IS_ENABLED(CONFIG_CXL_REGION_INVALIDATION_TEST)) {
> -			dev_warn(
> -				&cxlr->dev,
> +			dev_WARN_ONCE(&cxlr->dev, 1,
>   				"Bypassing cpu_cache_invalidate_memregion() for testing!\n");

This will end up failing the unit tests because those want to have a
clean kernel log from a "Call Trace" perspective. So either
dev_warn_once() or just live with the noise since the message is more
for awareness in production environments and test environments can
ignore it.