Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 09:51:54 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 08/47] hugetlb: add HGM enablement functions
Message-ID: <Y5teuidKlbKWbT/S@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-9-jthoughton@google.com>
 <Y5fDwH6XiM808oUM@monkey>
 <CADrL8HU9sQuh_W3Qx4dvGV44VLYNbt300cpWLU--BqLo3Xxgpw@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CADrL8HU9sQuh_W3Qx4dvGV44VLYNbt300cpWLU--BqLo3Xxgpw@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?E6OigIaZRy7eRDWcUKioC4PP52MG5jU2N+Hfr4NAkZkD4XnkLWH+EDthD6xp?=
 =?us-ascii?Q?sroUcU4hSbukAWA2RTUwQn2IFflyLaSzxUANL16Ri8nvIs8XYqqiSom9tIiC?=
 =?us-ascii?Q?9v0SbD4BFgPTU8BSdR9xXz5ZXF0KxIT2g569kS6Kg/ubu/SorxgWnBp7P+D7?=
 =?us-ascii?Q?JYrkPW4NQJzJmDqhGmOEjMjMfyWxLj209YIYd747ZWVM+Mk6jVErjyvGePqK?=
 =?us-ascii?Q?ZQFqUOQRiBpUVePLD10nbKbS3vPXeOgss3DeTcRTYrYgre9N0yXQH/dww8UK?=
 =?us-ascii?Q?ySX8LLJ2xB+mJSNwgHlmCBDPEkEikhwCnlAiDQWNNE6fuubw7IzkmlFFJ9Xq?=
 =?us-ascii?Q?e7K2W+luYlgEMQGd9K/ko7EdSdIqyqAvbU9qeLGqlawrTtD++uh7rUi7mLH+?=
 =?us-ascii?Q?3J+gwUSIVLYL8luQkxgzMt9jtWzTLW0Y2JT4LXs8N9kWCytW28ZyP2qM0gIq?=
 =?us-ascii?Q?Nk1nFah9uR1nkJLcr8fYoWn2a7gM11A8IzcFEgS/HWGya9Y4cVIS/Shk8wat?=
 =?us-ascii?Q?ZxsLO3RSUc4JIUDQAgCVTtYaQAHCvyLQBn7NVbnlQ97KH6WSe3CjJEz+RCzL?=
 =?us-ascii?Q?svU4DCn4impsDM0rfD7PZHQn7eSufN1jWpDWzWG4nej4bp+GjPKJgLK6gHP6?=
 =?us-ascii?Q?pBdIynSChQ0PsY3ltaPy7XO9smeb+yS8TLtpVhs2G0gHOUi05CzBlreTnDK9?=
 =?us-ascii?Q?PejnBr8nAGgEF4cTx37a6A2A6x0sdRf9kQxCBxoe0fxeSj5kxVcbxZmkWLgr?=
 =?us-ascii?Q?9A+lPpkdpVpt+mVekQitamfufu79XFDPR/lZ6ZUm9VTi3EjQFJ+E2nq2PnUp?=
 =?us-ascii?Q?+KnXD3S1aRVACADrdY2cG9CkIzwNHGSYPRqQGJwOvp88KvHBUpGKPmIxdRoY?=
 =?us-ascii?Q?Wf+pwQ6CLDm8t9GW2ZDPlhrq0rVDLkK4sDG2bpiV/AeW46Y3nmf/z7OiKgDl?=
 =?us-ascii?Q?9HN6daYzafia0tQvOXSsJPdnyDXhKgH2EoKC5kkH0V5QzmOutQCcITvpIWL+?=
 =?us-ascii?Q?waIUEFUXraPwEdpeeJc/m1ms+saTzVA7vMsMCKIHrF0RGlRobzUawfnKA2ue?=
 =?us-ascii?Q?5BI71O9wOv0LVcTW5dkTlgx1RiPyiSYpKuhCmORw1rNAjFi35VSXQ4kktW65?=
 =?us-ascii?Q?bk2c0DhOJfYO5i3XFufUSWt+DOFfr/jMv3/0x5aOIMArWs88DYcyp7zSOkDY?=
 =?us-ascii?Q?bkV5gbkmR6rv8VOAhdbIlOnXHEkIV/PQCRyUPYtKFBT3ZRIrL/8OVJ9CSqTZ?=
 =?us-ascii?Q?ReR+WihaW0JYI/vFglnlSvRh/Jee8WRpgawqxWV2IJFVXKOWCEhUEuyCr9Zt?=
 =?us-ascii?Q?1bl64aIMgwESWXaMdgnq4oSaFvUXq+aAnm4Zm1qf6uC9IEc3scvkYfGfm4HV?=
 =?us-ascii?Q?xQjpEC0cpBYWitPNp771KR/yyDEu7aMtbhH/MTjLRtVEt0mdqPL/hJB5GUh/?=
 =?us-ascii?Q?D86ZIFhQX8LFjDFKcQd4fcls+D9msMk52ZfM+BtNDniiQ0B9YHybrUpwYLgx?=
 =?us-ascii?Q?YJgjxQqYLvOP4HNkpLGEgsT+WCmeMtLfDbf9yc40TObF3IlVFAlK05+9Ql2q?=
 =?us-ascii?Q?/pLmcJQ69LEG7w9d8/0x2QaYPGiEfVXSf0FKb/NpA0F8VG2A5T6zY/iALWbp?=
 =?us-ascii?Q?Sg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3079d202-4263-468f-e28e-08dadec50f6b
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 17:51:57.7341
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fMCHPB7p1jCbBcQrzZtZj0VbaZm4wNKOurUuRNtHT6q6KqgOF0YAyRjYWlkicO8gHTk/4YxlW+oZYacUL1MlaA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7224
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-15_10,2022-12-15_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 mlxscore=0
 phishscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212150148
X-Proofpoint-GUID: fBm5qHc83QCyqU0DttEjgXOR42fserSq
X-Proofpoint-ORIG-GUID: fBm5qHc83QCyqU0DttEjgXOR42fserSq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/13/22 10:49, James Houghton wrote:
> On Mon, Dec 12, 2022 at 7:14 PM Mike Kravetz <mike.kravetz@oracle.com> wrote:
> >
> > On 10/21/22 16:36, James Houghton wrote:
> > > Currently it is possible for all shared VMAs to use HGM, but it must be
> > > enabled first. This is because with HGM, we lose PMD sharing, and page
> > > table walks require additional synchronization (we need to take the VMA
> > > lock).
> >
> > Not sure yet, but I expect Peter's series will help with locking for
> > hugetlb specific page table walks.
> 
> It should make things a little bit cleaner in this series; I'll rebase
> HGM on top of those patches this week (and hopefully get a v1 out
> soon).
> 
> I don't think it's possible to implement MADV_COLLAPSE with RCU alone
> (as implemented in Peter's series anyway); we still need the VMA lock.

As I continue going through the series, I realize that I am not exactly
sure what synchronization by the vma lock is required by HGM.  As you are
aware, it was originally designed to protect against someone doing a
pmd_unshare and effectively removing part of the page table.  However,
since pmd sharing is disabled for vmas with HGM enabled (I think?), then
it might be a good idea to explicitly say somewhere the reason for using
the lock.
-- 
Mike Kravetz