Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <171f3c50-17e7-de78-17fc-47f91f83d395@intel.com>
Date:   Thu, 15 Dec 2022 09:12:02 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.0
Subject: Re: [PATCH v9 04/13] x86/resctrl: Include new features in command
 line options
Content-Language: en-US
To:     Babu Moger <babu.moger@amd.com>, <corbet@lwn.net>,
        <tglx@linutronix.de>, <mingo@redhat.com>, <bp@alien8.de>
CC:     <fenghua.yu@intel.com>, <dave.hansen@linux.intel.com>,
        <x86@kernel.org>, <hpa@zytor.com>, <paulmck@kernel.org>,
        <akpm@linux-foundation.org>, <quic_neeraju@quicinc.com>,
        <rdunlap@infradead.org>, <damien.lemoal@opensource.wdc.com>,
        <songmuchun@bytedance.com>, <peterz@infradead.org>,
        <jpoimboe@kernel.org>, <pbonzini@redhat.com>,
        <chang.seok.bae@intel.com>, <pawan.kumar.gupta@linux.intel.com>,
        <jmattson@google.com>, <daniel.sneddon@linux.intel.com>,
        <sandipan.das@amd.com>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <linux-doc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <bagasdotme@gmail.com>,
        <eranian@google.com>, <christophe.leroy@csgroup.eu>,
        <jarkko@kernel.org>, <adrian.hunter@intel.com>,
        <quic_jiles@quicinc.com>, <peternewman@google.com>
References: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu>
 <166990898682.17806.2447018872734886554.stgit@bmoger-ubuntu>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <166990898682.17806.2447018872734886554.stgit@bmoger-ubuntu>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a2FhMU01KytFd0xSN1FUcXNtVDI2SEs1cDBSTjV4WmtMYXMxQ2ZKajBnR3dz?=
 =?utf-8?B?N2hDWUJDUzBaQ05paDhjckdXd2VSbDFCcWUyV3FwWXFaVW9UdkZoUVhCMm1W?=
 =?utf-8?B?ZHFkMUx2ZTRyT2tJeHRKdXRtcUQxRmlsWjJRR25YQ2hUc1VJb2dlYzJVV2Zv?=
 =?utf-8?B?TmhNUjNrVkFlV3N3MDBnSlhiUEpMdW5Vd3FZbnl0QXRWMW1CZFRoSUNjWWti?=
 =?utf-8?B?OEpTREV1T3JaMkVXZFJ1NUd6RXNOVWtSWTBsRDA2dUtJdk5aS25Jck5DOE9S?=
 =?utf-8?B?UG5oYnlYUmpLbWlvejNBS2VwL2hQY0Zad0dUbW43TWVGV0xhOGRpeG5iejBS?=
 =?utf-8?B?YThmdVpBaVVERTVoNDNOQmxoQnNRakdXc3NZeDBGYi9GK3dYcDV6cG1YQ3ZK?=
 =?utf-8?B?dXFhYUFEb3FibkQvY3ZRamJIczgrdzdPbE1iNjNCbmQ3ZDBNa3ZsSHdXS1Zk?=
 =?utf-8?B?THFBaDhOSFhNYWJVR2gvRjQ3UlRvTGlBNGJteXNUMTJGSkp6QWhEYzdTdDV0?=
 =?utf-8?B?djNSWmlMT1N0bk1nbHJVbVNWVElraWkxRFlXVTE4YVFVVHgraDFORGFoV2I4?=
 =?utf-8?B?UmlSVkg0VWRMMWo2R2JrWW5vQkJRczBYNGFpY0NqWDJMN3VKc0tpRkJZY3BJ?=
 =?utf-8?B?ajhMOWozVEt5Ynd1ZmkxdFFrTzh4VC9tYXdqazNFT2F2dEI4dkIvT2lCdmgz?=
 =?utf-8?B?Z3djV2dheGJKaUhTWGZRRVZoRCtka0dZV05DV2twbkhkSGtHV0JTZStxRzJz?=
 =?utf-8?B?a2ZsOEgzLy9QRkRYVUpEOTh1b2N3SUF5Z1NkUWVlWFIreWFBQWsramZCYW42?=
 =?utf-8?B?TFVkYzFieHVkbDBuKzVueldDc0JMU1QvQmRVWjJCbmx4RXFxTE1ER2hTbk4w?=
 =?utf-8?B?MWlIMG1OQkJFMzQ4b2oyMWtWNCtpK28veW9TRWVRSjV2amgzNE9wWFQzcHp5?=
 =?utf-8?B?L0wybEg2OUtFeG1MaU1Bc2dIMWNuR1RXNUU5VzJDRXV3SXZHUkc2bFp0OTAz?=
 =?utf-8?B?T2pFVWIzczlvS3RadVZSZzllSFM3eHg3N3lmRFlOUUNqbHZVNTduTzNRMCth?=
 =?utf-8?B?TVlGeVR2NzhNQXpFWTA2bmxTUmhHSzVNaUx2eUFHUHVGTkNXbkg4TFVsNWw5?=
 =?utf-8?B?eDlxZElHeUxORHpHZytjRjNZRTF3L1A5QjFLY1IxSUVmc3JvN3dKQjhHV3JM?=
 =?utf-8?B?djNFa2tLbDVnNXhDRUVrcjRTcEk5WmhxemhZcTM4dCtNOGxsWUVjKyszVSto?=
 =?utf-8?B?MU9xdmNBdWw2NFpyc0dFZWhjd2NIdUZMSWF1NUwycGF4clUrZFliN1kyZk1w?=
 =?utf-8?B?WHQ0c0FlSGJUem9KMjdLOUVrdWtiMS9PU3JsenNIbHZ3aWlaRnM3TnZkdlVH?=
 =?utf-8?B?ZWFHUmVQLys0NHAwN1ViQ1pZd0dHenJoMytScDhudUJ4bHcwb0Y1eE1sTWp5?=
 =?utf-8?B?Z2o1MlZWTUVtMVJhL1ZqdHRmMmoxTUFwZzRlQVBSSEhtekw5eUpUckI2RWJp?=
 =?utf-8?B?SzM3RC9mUFh3aDFQTU80T25MTGl2NkViaERuUDlWblQzYUQvUFliZkZXU3FI?=
 =?utf-8?B?RmF6MjlBbHJqTzZnYlE5SXo2anBqdzViV1VqNFpUN1NNYU5TYkhqRlR2Znlt?=
 =?utf-8?B?RC8rZHg1c1A1eXlZLy9wSnMwbjMwcFpiNk1ZRDFYbFhteHhmK1hRS1VCZUNT?=
 =?utf-8?B?cllDanVjeFkveW01Y1BZbXhsZlFCVi9qaGx6aVRKZjRReXorb09qUVNUem1K?=
 =?utf-8?B?Mk5HLzF1UDVUczFhejBRMUJxdFhQcTFuQU9YYWZnU0ptOVpkV2h2TGhaSElD?=
 =?utf-8?B?Nmt3YVJZdGZIQld1U0w4OVYzSU9jN2dTei93RWhsYWtFanczUHVZSHdHZGZ1?=
 =?utf-8?B?endsbW5vZDFyZ2Jud3VIenFJS1RXZjIxK1NxZW01TTJEakRVU2wrblFrbE5a?=
 =?utf-8?B?QzlxZTB5V0FtbDUxeTNGbnl6ZFhVMFFYdmFwUDR1Sjk4amtqTnhsanRnNWov?=
 =?utf-8?B?SVg5NDBUeXJLQWwvMkw3R2ZiVVFpZkZvSEZsYTNwcHI4VlYrZTkxL3ZYYndF?=
 =?utf-8?B?RmFvaXFpUEV4M3d6VWRIL3RYWmhBNE1LWFM2MlF5bG5BcWIvK25pS3c5cUJV?=
 =?utf-8?B?Wnlhc1prWEJicHVOb29SczYxRHdJdjRuYllGcUl3NlcyOVlPK05TVXQ2aEd3?=
 =?utf-8?B?OHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f911b7-775b-4b9b-c80d-08dadebf7dc8
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 17:12:05.9120
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5IAo6oRUfqK2QyMzhtA+JmH7Ze1oPfYnheGUgfy6lihGR8K+5EPc2X8DM5lcvL7CH07r2wSG1avl8w1Q9ZlXAGQv8Xc13EXND7heIelz7yg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5329
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 12/1/2022 7:36 AM, Babu Moger wrote:
> Add the command line options to enable or disable the new resctrl features.
> smba : Slow Memory Bandwidth Allocation
> bmec : Bandwidth Monitor Event Configuration.
> 
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
>  Documentation/admin-guide/kernel-parameters.txt |    2 +-
>  arch/x86/kernel/cpu/resctrl/core.c              |    4 ++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 42af9ca0127e..a7b6634f4426 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -5190,7 +5190,7 @@
>  	rdt=		[HW,X86,RDT]
>  			Turn on/off individual RDT features. List is:
>  			cmt, mbmtotal, mbmlocal, l3cat, l3cdp, l2cat, l2cdp,
> -			mba.
> +			mba, smba, bmec.
>  			E.g. to turn on cmt and turn off mba use:
>  				rdt=cmt,!mba
>  
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index f6af3ac1ef20..10a8c9d96f32 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -659,6 +659,8 @@ enum {
>  	RDT_FLAG_L2_CAT,
>  	RDT_FLAG_L2_CDP,
>  	RDT_FLAG_MBA,
> +	RDT_FLAG_SMBA,
> +	RDT_FLAG_BMEC,
>  };
>  
>  #define RDT_OPT(idx, n, f)	\
> @@ -682,6 +684,8 @@ static struct rdt_options rdt_options[]  __initdata = {
>  	RDT_OPT(RDT_FLAG_L2_CAT,    "l2cat",	X86_FEATURE_CAT_L2),
>  	RDT_OPT(RDT_FLAG_L2_CDP,    "l2cdp",	X86_FEATURE_CDP_L2),
>  	RDT_OPT(RDT_FLAG_MBA,	    "mba",	X86_FEATURE_MBA),
> +	RDT_OPT(RDT_FLAG_SMBA,	    "smba",	X86_FEATURE_SMBA),
> +	RDT_OPT(RDT_FLAG_BMEC,	    "bmec",	X86_FEATURE_BMEC),
>  };
>  #define NUM_RDT_OPTIONS ARRAY_SIZE(rdt_options)
>  
> 
> 

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette