Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 15 Dec 2022 10:15:27 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 17/47] hugetlb: make hugetlb_change_protection
 compatible with HGM
Message-ID: <Y5tkP8qUdsAzAe7D@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-18-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-18-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KvqYoI0V9vibsTBCwFg0PNkgMzWAggsf1rImrKt1s977fV9TSxswPsm+RHR0?=
 =?us-ascii?Q?C2UydRU6L3PTT6NDPyEI3UbziEnQNCNk78m71JTiDl/QZsUnfYSRiW9bDuJr?=
 =?us-ascii?Q?38cYRin3tVUoBhd93R/If8Aov9wFWrdn+DvfMWvl6LI+DOO1IKJoTna5hQ+h?=
 =?us-ascii?Q?FCHY2caLB8OX0RSY42fzumketkmFPO7a0+f9AKGdqM92NmF8mSDrWbcIstZy?=
 =?us-ascii?Q?weykFTySAuOFnSbaeVmWoKN4v/Nz7xhRTy8hxm01Gn2SY9vTOKSvK+Y9Hsci?=
 =?us-ascii?Q?pK1Yn2ePnT1dKu31ZM9bKriu+QDIkgmPehVm0N5r+6fIHA/xid4hH7y2fKmK?=
 =?us-ascii?Q?O0cH1JhxAH08pgf7ELLfvw/YevDDHhk43I79t1PsdwnqlDGgLQmS3HpmRYS8?=
 =?us-ascii?Q?zqTqYembYszbFov+nLPuHalorCUa08JEatLi6yYPJ2MDOkBeFaMfu/ZSD7bd?=
 =?us-ascii?Q?9phpGV/jLAJOFlrZBY5zGPMoWk5sTOddI1Ye0mCQdZNk5frYhQvXjRHLHr5Z?=
 =?us-ascii?Q?fhioaRHRIHwZPkepcGiQy4LfMx+AmCca8I/ZGLSaVhKTZMvtPFts7mHMibun?=
 =?us-ascii?Q?uDntdGLT4NrnQ0CEZamkRC92Gvetvj3Ua5y/P4ZrwcaJefxkHCwriLakhOzW?=
 =?us-ascii?Q?4rLxmy5YLF/Bsa78sckdH/W+AD2MZ6goGwoIQ0Q27c0J4/aM7RWJfPgDpX8B?=
 =?us-ascii?Q?0csUyRZC9Akze8ToKr8B15pf2z389I03p7T5AlswfaByvwxy2Uu/ASth+U/T?=
 =?us-ascii?Q?UhEID2aCTLK1hQVFqCPe36/xtsO5BRgZBKHoc9ikavaMvfEKGMC4AcTb9Z5J?=
 =?us-ascii?Q?J2kwabhowe+hNS+S4qHLxHne9TuCZTIUzQNGa0NRxNYsL/fc2kMrBkO7H3VB?=
 =?us-ascii?Q?9qk1ddAthZgQNnUb7cCNe4W+hP3p/ZTsHL45qyjSr9AHIHRFpA0yiuwe0oWG?=
 =?us-ascii?Q?guy7E31/gJvPm+Q53s2L1AKItB4d+XaP9Gcvenresa1zK3+RvUJjDCG7w61S?=
 =?us-ascii?Q?FgRHYjgZrjE9o4D/f++AXh7OMQCbYVUKcif6s6DCdHlY8NxBUatTwLysAYVo?=
 =?us-ascii?Q?lIRx28Z5/tq+lEHjMJrCwhZs0ibOWA7NjyAao4vNKVhaKujJr2XHnUZjTniW?=
 =?us-ascii?Q?h5JbGQtcVF7Sil1+POuKU+0z7vrl2JBhln9qSBqucTillMVNreVYtuhxbdec?=
 =?us-ascii?Q?Cn64/yW5HNmdx+G32x+dzACPVPjBNgotlhi+bPY5lolaa1cqdi/L29cFBacq?=
 =?us-ascii?Q?bQaUWB2mHieQXrZz+6RFOHXoq+O2nPT2EYbcbZ16QATRi/Kw5NjrI7zAEIU4?=
 =?us-ascii?Q?PNQNIDsplh7oqlpdzqUjSeBYF8aXB9AD7a2RKpSFZCHMOSXrhffvdUS3OIOP?=
 =?us-ascii?Q?DXXzAjNbD1frbdqCLTXOhKYVagi79KuA0mwKipxqq7RMtBZA2mWSx1qV8wdX?=
 =?us-ascii?Q?cigjzDHwh1sk54Sn/mC0t3NXzw/M+U0R4YZ5+sZ26S+UDk1Hkbz8Gl36+eVo?=
 =?us-ascii?Q?KmqeqjFX27JEd3rkodr/auNq1OiQnmD8Yrlja4o6l0Cb6RESxmNdt4KEOH+s?=
 =?us-ascii?Q?GpnFbH0R1TyIntEmribWVjkbyR3NUHuwwcEvIMzKh5OkbLAt5u9zlOH9Q11Z?=
 =?us-ascii?Q?Bw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d15a550b-f108-4f02-7626-08dadec859df
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2022 18:15:31.9143
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EcVD4bOScNurjdTdoO0q9fQDyCnWKaxPZzc+CTfAJXPqqXCfH1k9Eo8NY2v18Iwk3vx5wHGUWqVs/OhXJczrXA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6832
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-15_11,2022-12-15_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=734 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212150151
X-Proofpoint-ORIG-GUID: 3EKOKTMirvcwfwX086c_GybIkG7NqkyC
X-Proofpoint-GUID: 3EKOKTMirvcwfwX086c_GybIkG7NqkyC
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> The main change here is to do a high-granularity walk and pulling the
> shift from the walk (not from the hstate).
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  mm/hugetlb.c | 65 ++++++++++++++++++++++++++++++++++++----------------
>  1 file changed, 45 insertions(+), 20 deletions(-)

Nothing stands out.  The more patches I look at, the more familiar I am
becoming with the new data structures and interfaces.

-- 
Mike Kravetz