Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1522626rwb; Thu, 15 Dec 2022 11:05:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf7aJ3xD2DymhrQTamqjVK8tlVPFgaOv/xZzxNx4Y74T8AY83MWQQHEPaJK23uNxTjVLxW/X X-Received: by 2002:a17:906:7043:b0:7b1:316c:38f5 with SMTP id r3-20020a170906704300b007b1316c38f5mr23952684ejj.30.1671131119514; Thu, 15 Dec 2022 11:05:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671131119; cv=none; d=google.com; s=arc-20160816; b=sGn+VFhpV9ELgJDC6fgcL5Ml3CfYmM0LwSefYQ1AGH3bze7mh/2NM6A5QOaKhzoyLC H8BpPOVIKTYjNOwwWFVY0bCqzLYk4EJ7N6TeVfNKa1+ig7vMfOn2Io5DLKgY8NXEeiXj e1gj0wS99lCaJ1BhDgAe0tTjIwT0CNLyUiOciiC/1sXz5/VH2AW+kCd+U2POsdX/U1B9 xbSibCplpwmahMr9gbHL6HMX+degEOZwLem0Tc4B6U8GkEq3M85tZNXIsQIaSl0OjlxI 9tVzoIVhUHKmmk/2QacQOyHvsXmtceps2t5C2Yc4Ogt0EJfwARx01GgXEqzyzRUAifFc WY/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=iB3EgU//2XXLYrZd0Up3941soIDemxGFb1c6VyqrhV8=; b=QSafIrIFd/bV8Q8lvuUzDfxp3/kBmbpuPp63nvRkw2rMSRiPx+o3qIy190eSbepmm1 SkF7w7mAViGxY2K/dAkltsaRAg7d2nqXJpRBNv5BBYoN9dPytVrh6wiwdc2YNbl2i4AV M4fSKzAdwWVRjt2Cdo/f2GMGDz+WrQGUfhTiOUmBrD6lBd6aIqJ7PV6ntpZkdkbDOXy/ d1LJc5UvTNfkgeY+s/zQdQna3oK3yktoatpD5JDx3ZEW2fGbPqKBgy0NPkIwoPGuAsXT 6bt2MweXcWjHeibvGw8bovanq9k107DnIq6xfBP52rtXyY5jgdeCLGpWPxv7E6434H/s TkAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bFYX+6AS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa17-20020a1709076d1100b007c109e62bfdsi14985898ejc.984.2022.12.15.11.05.03; Thu, 15 Dec 2022 11:05:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=bFYX+6AS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230214AbiLOSfK (ORCPT + 69 others); Thu, 15 Dec 2022 13:35:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230131AbiLOSen (ORCPT ); Thu, 15 Dec 2022 13:34:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDB9A252A5 for ; Thu, 15 Dec 2022 10:32:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671129155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iB3EgU//2XXLYrZd0Up3941soIDemxGFb1c6VyqrhV8=; b=bFYX+6ASE9kjni+P2E9VBw6Iy8FYXQlOo/ogH0gVKk87yqMkbBy8fGdSnBw8Bj9aFLgRqG NHxHoI36vXECXWn5rZCST68Wvs/IR9RXbWsXCmX2Xkxceg8FB+APEcyC3cgTBziID3IBT0 qv8996ZfKOGz+sGgX4WWn9xbYu/LI3Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-582-B9FOM99MNcOwDuIX1PyPwg-1; Thu, 15 Dec 2022 13:32:34 -0500 X-MC-Unique: B9FOM99MNcOwDuIX1PyPwg-1 Received: by mail-wm1-f70.google.com with SMTP id c126-20020a1c3584000000b003cfffcf7c1aso1494210wma.0 for ; Thu, 15 Dec 2022 10:32:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iB3EgU//2XXLYrZd0Up3941soIDemxGFb1c6VyqrhV8=; b=YEqiS184FBWV6M39qcUhTPsNVi/en4HZUFxXyKc40KJ3/6wX4bqQGMrZN4uZjcqhoF pGfVLXNmQqbUqxZNvIGL+KlpSpmBUQiP1GWCgjBO3eGEuZ2iNi4bPeDvxfw+xGcmwbS0 5kLc45SDq1Hu6o+PV3/3GXsljduFDScl6J0GqlC61UdwXWhgbBoaraZOCpL9TFMnDx2e 9sCBAA7P53/HcKgFnN26Bp/5UYBpB4QrbvfUugVcjHUolipY8oGB75bh8b2YoxIv1unh toECEfOmp45saRVp60pPXpLeUBSxMrj9J7z1LwnUR90xaZV3oRdipNXEhTDx86QpBWTF 7ukw== X-Gm-Message-State: ANoB5pk8yBGYxagv7v6Vlz+YemdxLNwjjg3WHPm32RW4XgT2/md1B0bV 1jf/OOMVnAkR0ppAYyLoCx18aXTFzIZzR55fdy69/VuoSJibLbUDlEetG6N7H2arhN3qgqlv9CI 8TDga6i/nVsf57HK80gYMYJu8 X-Received: by 2002:adf:e9c1:0:b0:243:2077:8d3b with SMTP id l1-20020adfe9c1000000b0024320778d3bmr19522863wrn.5.1671129152203; Thu, 15 Dec 2022 10:32:32 -0800 (PST) X-Received: by 2002:adf:e9c1:0:b0:243:2077:8d3b with SMTP id l1-20020adfe9c1000000b0024320778d3bmr19522854wrn.5.1671129152010; Thu, 15 Dec 2022 10:32:32 -0800 (PST) Received: from vschneid.remote.csb ([154.57.232.159]) by smtp.gmail.com with ESMTPSA id x18-20020adfec12000000b00236488f62d6sm92212wrn.79.2022.12.15.10.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 10:32:31 -0800 (PST) From: Valentin Schneider To: Yury Norov Cc: Tariq Toukan , linux-kernel@vger.kernel.org, Andy Shevchenko , Rasmus Villemoes Subject: Re: [PATCH] lib/cpumask: update comment for cpumask_local_spread() In-Reply-To: References: <20221213043248.2025029-1-yury.norov@gmail.com> Date: Thu, 15 Dec 2022 18:32:30 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/12/22 08:48, Yury Norov wrote: > On Wed, Dec 14, 2022 at 09:47:47AM +0000, Valentin Schneider wrote: >> On 12/12/22 20:32, Yury Norov wrote: >> > Now that we have an iterator-based alternative for a very common case >> > of using cpumask_local_spread for all cpus in a row, it's worth to >> > mention it in comment to cpumask_local_spread(). >> > >> > Signed-off-by: Yury Norov >> > --- >> > >> > Hi Tariq, Valentin, >> > >> > I rebased your iterators patches on top of cpumask_local_spread() rework. >> > (Rebase is not plain simple.) The result is on bitmap-for-next branch, >> > and in -next too. >> > >> >> I had a look, LGTM. > > Does it mean reviewed-by? If so - for the whole cpumask_local_spread() > series, or for the last patch? Ah sorry, I meant I had a look at your branch for the result of the rebase which looks sane to me. Feel free to add Reviewed-by: Valentin Schneider for this patch.