Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1635450rwb; Thu, 15 Dec 2022 12:27:55 -0800 (PST) X-Google-Smtp-Source: AA0mqf7LggVpRN5VGBz/bMoGBsx9HVzyUKV7c+gUCzNeDHt7T2kKQhtJPq7SnLpWZCnp01lQ0Ifj X-Received: by 2002:a17:902:e305:b0:189:6522:7cc0 with SMTP id q5-20020a170902e30500b0018965227cc0mr24966801plc.50.1671136074765; Thu, 15 Dec 2022 12:27:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671136074; cv=none; d=google.com; s=arc-20160816; b=wasVQyheTI92Wl5zACyVYnB0UQkOORvElsnl6bpSYy0eWombMsJpPMQEgrysxMXTvR LOh5CtGoOEy7L7PKuiKX6Io2qjsJMgPo3FXD0o2txuSjbqfav2cNtPiCRXnOvb13zsJV mTmH9MWjERsegdIqtd6mAFYWLqDtWb0SvnPp+xv7gPFdwQpEEkq3grAZpsuCMVfB6SW6 PzIQoWbTuvznJHhrYaAiiWG4fuOp/zxHKN58BYK4uSzOeU2qp1iQwsbSURBlL6uFs3yv MxyalKhFJiFcsEFUl8B7ZsgkzSEd/vlWVqD4Z12UbCgxrvHUyKsm3DjEGgpmui809ROU 1cDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=gew37R4d0EuaLu0BmxDsBChaXuYStTh6DwJxFVNSwZk=; b=OPJpysymsw1YGnup+vclIIsTmftHyf0eJN6JPfVqjtBuqGckVkCNSF0nq7h+ZYvXU7 hx8TUXo2sTkm92DFlAN0ZCldO8YlpQssgOMbxYDE3NVtuLl8HnJZIPw9sgXmkkyX55ui cM6jWMzR5g0d531Wvvm2/grtD3R8e0iAs5PuOrQ4QFW6o9d3TCAL478U0o90Gg0ytZci xXAAbI3HnLtP3l2UZCgfNfGtplIdk29gDBuiADxsE/bPxPembAk4k2riPrJUanbV2QTY ik9HN4uC30Za0if4FIDYF8G4I0pKuZKT6JRc7WuL/lA7Lp/bIMEay3mvFsiwLXnMy+ay fVEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a170902f2c900b00172f32450b7si199220plc.197.2022.12.15.12.27.46; Thu, 15 Dec 2022 12:27:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230244AbiLOUNm (ORCPT + 68 others); Thu, 15 Dec 2022 15:13:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229988AbiLOUNk (ORCPT ); Thu, 15 Dec 2022 15:13:40 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23DF62EF4B; Thu, 15 Dec 2022 12:13:39 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CB140B81C44; Thu, 15 Dec 2022 20:13:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54E7CC433D2; Thu, 15 Dec 2022 20:13:35 +0000 (UTC) Date: Thu, 15 Dec 2022 15:13:33 -0500 From: Steven Rostedt To: Joel Fernandes Cc: LKML , Linux Trace Kernel , linux-acpi@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , Masami Hiramatsu , Brian Norris , Ross Zwisler , Ching-lin Yu Subject: Re: [RFC][PATCH] ACPI: tracing: Have ACPI debug go to tracing ring buffer Message-ID: <20221215151333.49af5442@gandalf.local.home> In-Reply-To: References: <20221214233106.69b2c01b@gandalf.local.home> <20221215141146.6ceb7cf2@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Dec 2022 14:52:48 -0500 Joel Fernandes wrote: > Another approach could be to always enable the trace event by default, > if the CONFIG is turned on. Or do a printk() telling the user about > the event to enable, so they know why their trace buffer is empty. Yeah, that is another option. And, yes I need to document it better. I started to, but then decided to hold off until I get some feedback in case this is rejected. > > Up to you and the ACPI maintainers. ;-) I'm going to guess I may not hear back until the new year. I'm fine with that :-) I'll send a reminder then too as I Cc'd the linux-trace-kernel list, which will keep it active in patchwork. Cheers! -- Steve