Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1705847rwb; Thu, 15 Dec 2022 13:21:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf7grJZYoKLCHvAJBKxl+J+ErOLiIQKbFnCYVR2y9kl/+Hx/zkOI+pjaVitKOtq6gBJdP5DC X-Received: by 2002:a17:902:a588:b0:186:cb66:d7a5 with SMTP id az8-20020a170902a58800b00186cb66d7a5mr29006504plb.32.1671139286268; Thu, 15 Dec 2022 13:21:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671139286; cv=none; d=google.com; s=arc-20160816; b=V/P3Zpd2QO1woEWQ5X1fVfXW9zPDYUyMAU5Z9MamAKco5MRWD3Irt/VEV+Wk2ra1Kc xYBLcWKSlBF3E+BmtbI11YDT9Bu0+juEG+CY3XGWTp43vXxtKiWDoIRRMXS/1q2cN+Et IaPaZDks2PqfESflFvOoGGBuzZRWhya4TtumHWIIIqJ02nmbipUn7jSuVW3s5g/n/Uf6 4/f1cxg2TB5/HBR4fsb9HWP+045fl8YhSkhmJtQLG9oeEedGDNFSdd+lkBRMSrFtdW3r 2Ia+THAigFff2khyl5CQNeuYKDPQYvzcOHq7jQL49dotsl1aos5gUNH+Dns1SAfBC4iU qwOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=L4QzUO/5EGfDZD67/1of4/koqACiKqXGoFqpQQK4BqQ=; b=ZNiPOjueIfnzuXMCwBa2tQzNM5DRg/QMcEHZM3VsrH2THE8boPCKAOHf3lDIrIMuwp OtkAYxfQsfd/SRFBTdCHC3oBKopV7+7n3hkKX1r2XundgAOS9gNCiL8sFbN9KSfoR8Dz GjtZi+2aBZ+T84Mw36R8KgMvL5Msn7xCwdOziksCzW98hXdKhdkdSUDnVNDEcc/UQKDV Ybuz/O4w83rSnecXg78B1M96O1Z1pyjgvy1IMEodhHTbRhhLWnLVBaNB/JnTErRHsS+9 iU2RNPLmQIvwl0Yu6ngdhDMxhDbpvpFToYwZK7uPCz1jS2altCgnh5lv6gcOhkqPYDy0 nCmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lk2HkdJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g2-20020a170902e38200b001747ed48ee8si315724ple.150.2022.12.15.13.21.16; Thu, 15 Dec 2022 13:21:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=lk2HkdJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbiLOVRS (ORCPT + 69 others); Thu, 15 Dec 2022 16:17:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230024AbiLOVRC (ORCPT ); Thu, 15 Dec 2022 16:17:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 638A758BF7; Thu, 15 Dec 2022 13:17:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0784161F27; Thu, 15 Dec 2022 21:17:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C87DBC433EF; Thu, 15 Dec 2022 21:17:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671139021; bh=naga9Srm6Vs0kp9gzyWOYSbHJ4ApJqSDzqKZwSyas2o=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lk2HkdJFAdcleX8wQ8wFgWbsIF8qYsUVZi43S7kksNKVU8rjLuEZAmceh3Pv9uvTa bsG1Bu7H3xpMD+IJL3hcsAzp1eXO2ZoLXF6yV+9KJZSQM0lEVp83kAora/iDavsSRa Zmk8PwWBda2GWnh65iXpwibSNbdWUFl0fb5is5JLnANbNApJWXA19vyt2JReGOFf7n nPwESpz8gPeGMMtTV0+RBc5Dc+xNIo05TUwdrB9tEAR8aN6R+FVskSiP0nWCOZVhs/ lWQROmWU5u00vZHKzOrtiutO2mCYQRY/d5LAxST71VLKa02UXnDDyfmak+w+U4dCX6 qPBogLi6mMFGQ== Date: Thu, 15 Dec 2022 13:16:59 -0800 From: Jakub Kicinski To: David Decotigny Cc: David Ahern , "Mahesh Bandewar (=?UTF-8?B?4KSu4KS5?= =?UTF-8?B?4KWH4KS2IOCkrOCkguCkoeClh+CkteCkvuCksA==?=) " , David Decotigny , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nikolay Aleksandrov , "Denis V. Lunev" , Daniel Borkmann , Chen Zhongjin , Yuwei Wang , Alexander Mikhalitsyn , Thomas Zeitlhofer Subject: Re: [PATCH v1 1/1] net: neigh: persist proxy config across link flaps Message-ID: <20221215131659.7410a1da@kernel.org> In-Reply-To: References: <20221213073801.361500-1-decot+git@google.com> <20221214204851.2102ba31@kernel.org> <20221215110544.7e832e41@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Dec 2022 12:36:32 -0800 David Decotigny wrote: > > Makes sense. This is not urgent, tho, right? > > Not that kind of urgent. > > FTR, in the v2 you suggested to use NUD_PERMANENT, I think that was Alex. I don't have a strong preference. I could see arguments being made in both directions (basically whether it's more important to leave objects which are clearly not cache vs we care more about consistent behavior based on the permanent flag itself). Let's limit the reposts until experts are in town ;) > I can try to see how this would look like. Note that this will make > the patch larger and more intrusive, and with potentially a behavior > change for whoever uses the netlink API directly instead of the > iproute2 implementation for ip neigh X proxy things.