Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <946950be-482c-ef9f-404c-2ce758ba175d@huawei.com>
Date:   Fri, 16 Dec 2022 09:16:29 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH v2 2/2] hfsplus: fix uninit-value in hfsplus_delete_cat()
To:     Viacheslav Dubeyko <slava@dubeyko.com>
CC:     Bart Van Assche <bvanassche@acm.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Aditya Garg <gargaditya08@live.com>,
        Jens Axboe <axboe@kernel.dk>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Jeff Layton <jlayton@kernel.org>, <hannes@cmpxchg.org>,
        "Theodore Y . Ts'o" <tytso@mit.edu>, <muchun.song@linux.dev>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20221215081820.948990-1-chenxiaosong2@huawei.com>
 <20221215081820.948990-3-chenxiaosong2@huawei.com>
 <6258B9FC-0A00-46BC-9C6C-720963D58A06@dubeyko.com>
From:   ChenXiaoSong <chenxiaosong2@huawei.com>
In-Reply-To: <6258B9FC-0A00-46BC-9C6C-720963D58A06@dubeyko.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/12/16 3:03, Viacheslav Dubeyko 写道:
> 
> Maybe, I am missing something. But where in the second version of the patch
> initialization of subfolders?
> 

The first patch of the patchset factor out hfsplus_init_inode() from 
hfsplus_new_inode():

void hfsplus_init_inode(struct hfsplus_inode_info *hip)
{
         INIT_LIST_HEAD(&hip->open_dir_list);
         spin_lock_init(&hip->open_dir_lock);
         mutex_init(&hip->extents_lock);
         atomic_set(&hip->opencnt, 0);
         hip->extent_state = 0;
         hip->flags = 0;
         hip->userflags = 0;
         hip->subfolders = 0; /* I am here */
         memset(hip->first_extents, 0, sizeof(hfsplus_extent_rec));
         memset(hip->cached_extents, 0, sizeof(hfsplus_extent_rec));
         hip->alloc_blocks = 0;
         hip->first_blocks = 0;
         hip->cached_start = 0;
         hip->cached_blocks = 0;
         hip->phys_size = 0;
         hip->fs_blocks = 0;
         hip->rsrc_inode = NULL;
}