Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tharunkumar.Pasumarthi@microchip.com>
To:     <andriy.shevchenko@linux.intel.com>,
        <Kumaravel.Thiagarajan@microchip.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <macro@orcam.me.uk>,
        <cang1@live.co.uk>, <colin.i.king@gmail.com>,
        <phil.edworthy@renesas.com>, <biju.das.jz@bp.renesas.com>,
        <geert+renesas@glider.be>, <lukas@wunner.de>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support
Thread-Topic: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support
Thread-Index: AQHZEKWxJyYrAeLM7kuV3hibr7zg+q5vN+wAgADGUpA=
Date:   Fri, 16 Dec 2022 05:40:31 +0000
Message-ID: <PH7PR11MB5958DF2284FDC67FA7018E9B9BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
References: <20221216052656.2098100-1-kumaravel.thiagarajan@microchip.com>
 <20221216052656.2098100-3-kumaravel.thiagarajan@microchip.com>
 <Y5tciHzsEGU67h1Z@smile.fi.intel.com>
In-Reply-To: <Y5tciHzsEGU67h1Z@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MwZCtUC/VVZDDQJ81IJ565pWqGTckLb3zN2wU6IAws9sVYVAbU8luVJlIZzh?=
 =?us-ascii?Q?fsSINN8sF0+IUJXgz6WftgXl0ffoO2rcg9Fj+SjTKWsQrH89Pc3DvnOLO716?=
 =?us-ascii?Q?yvfIxXTdurwky3AaxM9Tnwx10DjICu0ONmxbuSCSHeVrl7kHfiYBhI3qrHaH?=
 =?us-ascii?Q?vOKOEZH/nJYWjfZ38m6PMr6S2azEXVW86LtCFzSrKwVBbdn0NheucJ+S82Ed?=
 =?us-ascii?Q?nN7qg4OcBDIuixspFEi/M/28SSIqDbqJzL4XkTnIMUvTrF4LisIGZGhXnrLB?=
 =?us-ascii?Q?7xTYwfZWmv0/i1E4wjyTpHrLK52H8V+sIT2M06RyxSX32gYcplx6r55c/O8h?=
 =?us-ascii?Q?Tum2Uw66ti0pD0OA2RsR6JIE6bFx3JbHSEK53zpzvf/Jg0Pg9QDW2rMYtn8D?=
 =?us-ascii?Q?Fynx31MKXQYWC4LGrXnlrbMes6gvZtLujvLZllIq/vc7GQ1z6i3UOwzJ8FB8?=
 =?us-ascii?Q?KGyam1qkrJr4LHgAngjvhlFw5kSBxgVX/61y/P5+DApfE12jLVb04kEz+fhb?=
 =?us-ascii?Q?Y9HAaqPldi7TjW9H63vT+fLDufDGtzw9IagJf6DfSY5Tp67s62u3RgWeyGod?=
 =?us-ascii?Q?d/Jk+Qygq4f6iW7Mbj0yPPwXCn7c9DxuAH66f0v+VhR0v3VfopcrJcqS4ioz?=
 =?us-ascii?Q?wSnBU2CCEaA+uW4XrSd+FTzHZIEXJR51Gz0I6Jc1w36W4wm6UIEYEEdxHYFz?=
 =?us-ascii?Q?nskf7b7UM0hSJ9MrqA6LLfqReQOyothJaBgoundz+5UHMbbetKpHcVJXqTFe?=
 =?us-ascii?Q?HCJy14qZSasqHg7hMnE32QoSKe9qeHVHcl3Mc4KscRvHpWnPMgE0KAwRBfFx?=
 =?us-ascii?Q?NNH2ICXFzSmQ1ZjN8TqWp+M1eNKGsM1HVr3Lscapwu9vojd7Tp40w+mOKKl1?=
 =?us-ascii?Q?4YAKHbiCFTY+qxr6ZeMFTyfqTkXyv+w8ZfuHzkR6vhnSaQVIpmfyp53yaOtF?=
 =?us-ascii?Q?DEmgK119JDxrVLl0Hqp2eNNY2KU4uyRexHE4/7cdWrrhocAL2KaqKm1aI0fs?=
 =?us-ascii?Q?MDVhfzL0pdQgFdd1k8uXn64faVcaUsv+Lgxtpx3CGS0pvBcuPUcJhM5GJw8Y?=
 =?us-ascii?Q?Qy5I+XHAUYfdZKHQD/0AWiMJB70GsI2ZVWfXRd4ljkJx0ALfD0zaIC4sTkGB?=
 =?us-ascii?Q?cmeRte+A1Vo01O9uz40iFMWyTBLacaLyNyfc2Ndp7uycJoKGO9OME0asJ6ne?=
 =?us-ascii?Q?MMuf07uWo1aO6DGtjFnEOAy6eAsY1wEaD0asrqMkU7pq9vtzOI3OmMWPT18Z?=
 =?us-ascii?Q?BjRtsk/QL5rpzf51pNkAkM0Ulap+TX/7CRzP+Cf0Q2355wtbayZw0QvuYhc0?=
 =?us-ascii?Q?rtZTp+pNYc/ukgpTas3uMLJrxpd1JysrMRKVthfI/KNxbeFFUNNVUi2s4yyP?=
 =?us-ascii?Q?GAdYv+7k1NCSdqoYs9EpJj1ynVlGyNgN223FGyY2jmbccNvqSpyu81VJEFLa?=
 =?us-ascii?Q?19GdwWU2EwTATScbVhOX4XnsD/SHz1EI5SbcGWPEIm+Fv5SmV8hfJDjEE6/v?=
 =?us-ascii?Q?08BnpS4be4g8TLGR8ohVAHue0TagToLK8pas8dOA3OO8km0N1YYGwPq8aSFC?=
 =?us-ascii?Q?lV9BCw8MrrXkfKsTftjuE4cCzWmFrhX6XP78dqil+0xKXSO+VsIKK8dte16J?=
 =?us-ascii?Q?pflaDW9QsMyTCXsNWqM8Lbc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5958.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d793cac4-3ab5-404a-539f-08dadf280bc9
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2022 05:40:31.5619
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3CBd6Q5ACe020P1GpvqtNHz0UNG2zt7w0FTAjiInp7W38aIdlYKV7OsntwIRPDwnysjN9gn6sYOoowdwjlDz6IDVTNwzcyJ/FhmktfxPRNHiWkk32GFdBV3w2CIKuy8b
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6368
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, December 15, 2022 11:13 PM
> To: Kumaravel Thiagarajan - I21417
> <Kumaravel.Thiagarajan@microchip.com>
> <Tharunkumar.Pasumarthi@microchip.com>
> Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver fo=
r
> quad-uart support
>=20
> > +     ret =3D serial8250_pci_setup_port(pdev, port, 0, port_idx * 256,
> > + 0);
>=20
> Actually isn't 0x100 better (show that there is an offset rather than a v=
alue of
> an register)?=20

Okay, I will so something like this,
#define PORT_OFFSET 0x100
ret =3D serial8250_pci_setup_port(pdev, port, 0, PORT_OFFSET * port_idx, 0)=
;
=20
> > +     num_vectors =3D pci_alloc_irq_vectors(pdev, 1, max_vec_reqd,
> PCI_IRQ_ALL_TYPES);
> > +     if (num_vectors < 0) {
>=20
> > +             pci_iounmap(pdev, priv->membase);
>=20
> Here is inconsistency on how you interpret pci_*() calls when
> pcim_enable_device() has been used. I.e. for IRQ you don't deallocate
> resources explicitly (yes, it's done automatically anyway), but you expli=
citly
> call pci_iounmap(). Choose a single approach for all of them.

AFAIK call to pci_iounmap cannot be avoided since pci_ioremap_bar is not 'm=
anaged' API.
You suggest calling pci_free_irq_vectors (even though it is not mandatory)?

Thanks,
Tharun Kumar P