Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221214092636.810883-1-milkfafa@gmail.com> <20221214092636.810883-3-milkfafa@gmail.com>
 <7e67b2d1-394e-2353-df37-5ae3cac64b9c@linaro.org>
In-Reply-To: <7e67b2d1-394e-2353-df37-5ae3cac64b9c@linaro.org>
From:   Kun-Fa Lin <milkfafa@gmail.com>
Date:   Fri, 16 Dec 2022 14:47:17 +0800
Message-ID: <CADnNmFptyu_kCdVeFbYUO0vEfLaSniSuz3UmJFiLfv3yF6Gvfw@mail.gmail.com>
Subject: Re: [PATCH v8 2/7] media: dt-binding: nuvoton: Add bindings for NPCM
 VCD and ECE engine
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        openbmc@lists.ozlabs.org, avifishman70@gmail.com,
        tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com,
        yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, kwliu@nuvoton.com,
        kflin@nuvoton.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Krzysztof,

Thanks for the review.

> > Add dt-binding document for Video Capture/Differentiation Engine (VCD)
> > and Encoding Compression Engine (ECE) present on Nuvoton NPCM SoCs.
>
> Subject: drop second, redundant "bindings for".

OK.

> > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-ece.yaml
> > @@ -0,0 +1,44 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> Drop blank line.

OK.

> > +    ece: ece@f0820000 {
>
> If this is video codec, then generic node name: "video-codec". "ece" is
> specific, not generic.

OK, will change to "ece: video-codec@f0820000".

> > +++ b/Documentation/devicetree/bindings/media/nuvoton,npcm-vcd.yaml
> > @@ -0,0 +1,72 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +
>
> Drop blank line.

OK.

> > +  memory-region:
> > +    description:
> > +      CMA pool to use for buffers allocation instead of the default CMA pool.
>
> maxItems: 1

OK.

Regards,
Marvin