Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2277104rwb; Thu, 15 Dec 2022 23:07:22 -0800 (PST) X-Google-Smtp-Source: AA0mqf4TU9A6x1Gv6Cxq2boZhU62PcQcbKob1xcXsXUg3utjoE5cfcsSPgvQ0fZnVJmIp6b76ljM X-Received: by 2002:a05:6a20:6f8c:b0:ac:5bc1:cca6 with SMTP id gv12-20020a056a206f8c00b000ac5bc1cca6mr37968161pzb.8.1671174442354; Thu, 15 Dec 2022 23:07:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671174442; cv=none; d=google.com; s=arc-20160816; b=JjfxuwXQFOnazI3gigyNdu3f9NGiTmg2a0nHS0QaYBvxgbKmI6AVp226cljWTJU2SY zAAJjao8RR8PqqUfwnXtvBmleOoO6aN1HtHF/QnlIgIkO7JRws2/NgvAxVSOnD3PeMsu 3Sv6ydAjJM620gHhRD9dYVgWjwuqNSvCweo00ltrbRwMQA97kW+S4NYOYQCQ0jaUbjxZ PZSAfzVNdTLA0+Gg71CrE1qVGSjnkLQSThTvjVsl+h+s8/eqzAANwiKIXimknWW9JV0Y 6OpaVpUyzKPz1V9yYA17RpQeDQaDYyaNU9tmHDEzodF7Ed0TztK0vpvy0o8msLatpiMW kjsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Bdn3uI2+vY5pQpRy4ybJdHr0gzTwg0wCHFdFjlS66os=; b=TiAG8VP2vDA/OFQ0lgwLAC8VVopjR/CmnTpA584/D3pQHqbKWsDkMwq9CnFXWgOS7H 0JQsL9EOQVFt/02gletVrwgtbQ+ALdBsotkkZCbgXk5y4UjFg05YQ5F8crkz20fPlfcy 0Fr6SmBc3f7B3OlUgs2BX+iGfPjiVVB4VNFNdzywNwGlL+q5e7uGxIE3R71761oV3SDv RXoS7b0JliST1SY5AhCriTdVeZTEII72UoxmECagEn16EHZ/vg5Onv8KI4QGQTM5UXos mZIVBWbmchtmWEUl8nupogAdV2bqHOtpAFLY8ylpHJD6EpmUIaHTKZnSefwlgumjgkHI rO0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=bLfJhBuv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v25-20020a637a19000000b0046b1dabcb34si2019969pgc.765.2022.12.15.23.07.13; Thu, 15 Dec 2022 23:07:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=bLfJhBuv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229891AbiLPHEm (ORCPT + 68 others); Fri, 16 Dec 2022 02:04:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229814AbiLPHEl (ORCPT ); Fri, 16 Dec 2022 02:04:41 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59BF736C42; Thu, 15 Dec 2022 23:04:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Bdn3uI2+vY5pQpRy4ybJdHr0gzTwg0wCHFdFjlS66os=; b=bLfJhBuvLnKfTacOfntkdpS2po uAg/4/QhYMKzf4mZgSJhDGyiG4KkB7RTxyWxK+FqZuwCXC8tpmImbDTEiVw8UVc+KvhOJZwd+TbOc 7kpyqxiSfd89La05577BSU/N1Pm2w8f8wLgenw8HtpqxFH6ll6ph504SagudlnHyZx6qJMo1qy6jn AfwOY34DFkgeTgN3TI/aAh9YaQOP8l5RlBs5skn91XVAHisw2DYcVEtJH7x1Y9BkNfvRDnZIPnSpG kZI+PpexyIt88X90R0K4QYbleTEnC5uzu9vnCte4RRH8VN4oR6+1PeqqWzbpC1HI80DUDcbOla61k qNV6+6Ag==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p64ln-00DJ0d-Mf; Fri, 16 Dec 2022 07:04:35 +0000 Date: Thu, 15 Dec 2022 23:04:35 -0800 From: Christoph Hellwig To: Sergei Shtepa Cc: Christoph Hellwig , axboe@kernel.dk, corbet@lwn.net, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 02/21] block, blkfilter: Block Device Filtering Mechanism Message-ID: References: <20221209142331.26395-1-sergei.shtepa@veeam.com> <20221209142331.26395-3-sergei.shtepa@veeam.com> <28b715eb-f9bc-c0d3-8dfd-22d0f84080c0@veeam.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <28b715eb-f9bc-c0d3-8dfd-22d0f84080c0@veeam.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2022 at 11:46:35AM +0100, Sergei Shtepa wrote: > I am very glad to see your comments, Christoph. > Thank you so much for the review. > > I have read all the comments and agree with them. > Now I see new ways to make the code of the filter and the blksnap module better. Sorry for being so late, but I was stuck onder a pile of work last time you posted it. But compared to the versions before I think we've made a lot of progress and we'll get there. Also feel free to ask me for input on changes before the sending the whole series if you have any questions.