Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2300039rwb; Thu, 15 Dec 2022 23:31:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Hv05RHG7SBWsg7UX4/I6Bx3gCuikFxZxNoxKlN1Pt2HqYFxmZPOHaz8L+3wX5ST6LPDBG X-Received: by 2002:a50:fb99:0:b0:46b:3943:7387 with SMTP id e25-20020a50fb99000000b0046b39437387mr27369098edq.16.1671175919269; Thu, 15 Dec 2022 23:31:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671175919; cv=none; d=google.com; s=arc-20160816; b=s4W5Wh32BgtShacp88Tobt3YMNwTXtGONQENmsE21Allvzema5epK8dFpBinzi5SLq OICvTLiH75dVOAbJPTxcvKVKIYDdJfMUqHRhPe371B1eObXAqDEi/m3qDaEOttBnRUFs upMdBSHnvASGu74RRhJwG45jWkdXk7lIOzkXnxbezKY3T7Qx9HC/jsa4f7nB1j28ctyY 7Yohi/uvgzGX/Xo55ozgVuBDlL1j86fG0QSpLeWFTn7bepdcYJp0z0ZPnJ3xEl2SnEVU winzYGiNVRyfv1iP1Qd0Xg4205+N05A+S2BmkQFJ5WzcZfwU7tXGiqxuyzfNbfcwXj/h 0uOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vqRMSpD1eVYXTGaFFnMc2dvCJYloydrqlHDvsUDDbr0=; b=DCLNlriHvVV2MhdAWtYXYYpjgN3disLTgNFqEVGze9wrfsWmeInmO3tt8NkEtN/JdI LKAnY5W4Au9UmDYkGlYfWqt3qXQzgsEeZ2vcUlIAWLnQJvjdyMVTomK8u3ceaoGPLO/s 6cGnhonqvsUzsC3plr3/Xobelo2J3TrHXc4TxB/lrPl0lQ3yWyiSdDkz0JBpvngfDZxO y10yDZJ7whJ32JFIR5ufSJviK5WeAsch+/wM/BhYt/nrN/ni/Ygh1VpzYk82IBjQisPP cMBn2Wpzq4naHOnoQT4FPcNxswzHVqEy1rWa8IN2VPqTknoXSe+BBi0gTTZgTro8HVl+ c4/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=b7yHcHD4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q13-20020a056402518d00b004690097d852si2115918edd.252.2022.12.15.23.31.42; Thu, 15 Dec 2022 23:31:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=b7yHcHD4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbiLPHOI (ORCPT + 68 others); Fri, 16 Dec 2022 02:14:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229836AbiLPHNY (ORCPT ); Fri, 16 Dec 2022 02:13:24 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 006AB19002; Thu, 15 Dec 2022 23:13:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vqRMSpD1eVYXTGaFFnMc2dvCJYloydrqlHDvsUDDbr0=; b=b7yHcHD4T9me5R9OFJ2iJjtZr+ mVKbrMop8uy2T3Qy2LUeiDHQSyWbAxNBLRHN1r2vxuWF3lgKf5T9/vuSqXAmnigQxfW+M10JGCnqi SbCcTBqebh6gbSocryrcZEK18rhNfIYgnE0VQX+l3fqeK+/Sq+kLaYNW7GEAaACXQvVVTEVT7Z7bn Tgw8h1U46sFnFjmY/RdrDZydrhJH5HI8izJgOVns8PxsmiET63z8Ic74YNSl6+VPJelsY/7pQIOz7 T1JNurmE16AyMkkPPlushDL+VscpM4mKjRH3HBVVK9zXVEAEJKTFT//7g/ibVtc7q9J4OWtJg78HM +IWF6Q2A==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p64tu-00DL2R-5w; Fri, 16 Dec 2022 07:12:58 +0000 Date: Thu, 15 Dec 2022 23:12:58 -0800 From: Christoph Hellwig To: Wenchao Hao Cc: Christoph Hellwig , "Martin K . Petersen" , Mike Christie , "James E . J . Bottomley" , Lee Duncan , Chris Leech , open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH 0/2] scsi:donot skip lun if inquiry returns PQ=1 for all hosts Message-ID: References: <20221214070846.1808300-1-haowenchao@huawei.com> <57c12317-c229-8cbe-b3d2-d799ea5f554c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57c12317-c229-8cbe-b3d2-d799ea5f554c@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2022 at 05:09:31PM +0800, Wenchao Hao wrote: > In my opinion, if the addressed lun still response the > inquiry and other commands, we should not skip it, > maybe let the scsi drivers like sd/st/sg to determine > how to handle this lun accordint to the PQ value. > > As discussed in following mail, another drivers would > be broken too. So why do you force a specific behavior for iSCSI?