Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 16 Dec 2022 11:38:43 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Tharunkumar.Pasumarthi@microchip.com
Cc:     Kumaravel.Thiagarajan@microchip.com, linux-kernel@vger.kernel.org,
        linux-serial@vger.kernel.org, gregkh@linuxfoundation.org,
        jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com,
        macro@orcam.me.uk, cang1@live.co.uk, colin.i.king@gmail.com,
        phil.edworthy@renesas.com, biju.das.jz@bp.renesas.com,
        geert+renesas@glider.be, lukas@wunner.de,
        u.kleine-koenig@pengutronix.de, wander@redhat.com,
        etremblay@distech-controls.com, jk@ozlabs.org,
        UNGLinuxDriver@microchip.com
Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support
Message-ID: <Y5w8o0vK7wuoX+yh@smile.fi.intel.com>
References: <20221216052656.2098100-1-kumaravel.thiagarajan@microchip.com>
 <20221216052656.2098100-3-kumaravel.thiagarajan@microchip.com>
 <Y5tciHzsEGU67h1Z@smile.fi.intel.com>
 <PH7PR11MB5958DF2284FDC67FA7018E9B9BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
 <Y5wrnzLMv5SCWPkn@smile.fi.intel.com>
 <PH7PR11MB5958956CB3DFD8E9B4A122379BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH7PR11MB5958956CB3DFD8E9B4A122379BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Fri, Dec 16, 2022 at 09:30:42AM +0000, Tharunkumar.Pasumarthi@microchip.com wrote:
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Friday, December 16, 2022 1:56 PM

...

> > > > > +             pci_iounmap(pdev, priv->membase);
> > > >
> > > > Here is inconsistency on how you interpret pci_*() calls when
> > > > pcim_enable_device() has been used. I.e. for IRQ you don't
> > > > deallocate resources explicitly (yes, it's done automatically
> > > > anyway), but you explicitly call pci_iounmap(). Choose a single approach
> > for all of them.
> > >
> > > AFAIK call to pci_iounmap cannot be avoided since pci_ioremap_bar is not
> > 'managed' API.
> > > You suggest calling pci_free_irq_vectors (even though it is not mandatory)?
> > 
> > Why is it not mandatory?
> 
> Following is the reason why I felt calling pci_free_irq_vectors is not
> mandatory.  Correct me if my understanding is wrong.
> 
> Following is the Callback Sequence (from 6.1 kernel) that gets executed upon
> calling pci_alloc_irq_vectors:
> pci_alloc_irq_vectors =>
>  pci_alloc_irq_vectors_affinity =>
> __pci_enable_msi_range =>
>  pci_setup_msi_context =>
>  pcim_setup_msi_release =>
> 
> devm_add_action(&dev->dev, pcim_msi_release, dev);
> 
> Inside pcim_msi_release: (called since pcim_enable_device is used)
> pci_free_irq_vectors(dev);
> 
> From this sequence, it seemed like, kernel takes care of freeing irq and
> calling pci_free_irq_vectors is not required.

Technically you are correct, but... read this discussion, and pay attention to
what Christoph said there:

https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-b7c17fd0bd2c@siemens.com/

-- 
With Best Regards,
Andy Shevchenko