Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2475497rwb; Fri, 16 Dec 2022 02:33:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf7cllRAdsoTdMc2r9tMirnPSpqiEeRt2i6X6SzH3Vn8gyTEa31Hu/+9ew6A4+sYI1N39cOu X-Received: by 2002:a17:906:ca18:b0:7c0:a181:90c5 with SMTP id jt24-20020a170906ca1800b007c0a18190c5mr26401368ejb.1.1671186798384; Fri, 16 Dec 2022 02:33:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671186798; cv=none; d=google.com; s=arc-20160816; b=YNWWWaR5N5/3d1QuXxqqIBAqb0FgiHxkXibzm6iIxooBCZR5/iVn7ybRTVXlh0t33X ExeOqi78JXPVplxCH+36XbeMeJc978ux2AtzgWHt+enLlGquq/mbi0gBJNK5h1tWaaht FpfBbbtM0I8K/BLh69L56S3gde5NYlpj+MLBEBFQBAeIg4Z8BHPoACcYI3C3z9Ngclte unILULG3PLc2G2dDJNKl1ZUY5I+b3AQsZe8egZ5ltovQVbrI5YbhUsWTci/WxAaKuN0n zRMQtXpzZJKdqcEHBXzYLYW6K6YOE9fZF/NZgHOesSiJiirz/roXgd/4OTM5K+idqinE 5Nkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JXyV8A7uSXWSLkBSUjr1gcvCink4PHGUgLpOislp6zc=; b=WqKIDhlEkqK/y9CkYhmP2h2Da41lDT7Eb4nkN63G7fCmN13HFRPsnnyNYIK0alKSWB 8If6vn03fM8fmA1Z9HiyvE4IGXW7yAEOicNzu0DkUFwUQlP3TKFwovom6PRTxf9cbE9x aIuNsvxNf5I2MMvOMlzdzKo1MoVtMMPruVBoLvfEohr3QTP0A4U2uB6liVtWtjhCgY/O TSvFPcU8OGA5nl/cGQtc73sNfoqepyYboGuMiqzC6q9MLC3SIsn0bLGKdH5ots7Z76p3 JiYx0McZlsuBunCM0A5C69fQaXiu3/RKxcnSvAehJWz2U321GQzR/jJHmksfcJVJn7Gx DplA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JfPhvIk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq41-20020a1709073f2900b007ae74740fa4si2459187ejc.275.2022.12.16.02.33.01; Fri, 16 Dec 2022 02:33:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JfPhvIk5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230161AbiLPKDw (ORCPT + 68 others); Fri, 16 Dec 2022 05:03:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbiLPKDo (ORCPT ); Fri, 16 Dec 2022 05:03:44 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A45834A056; Fri, 16 Dec 2022 02:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671185023; x=1702721023; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iL3v9W9JsUQY9SxcVHN0UWhfZb6jDPXHg3+Oshg1GJM=; b=JfPhvIk5wlmQDwv/majiT5crTI5bBFLGduhx1/X3/be4IRuf8n0Oy7SW QLdbWBGElA4B7vfzdjc9QmadiAxtYMOlg6lBNqJeT6giMQtm3eB0/D/ct E2yQvuuo+milZUQCINpCxAdc3F0bC/JkxsV+t45vd24iWhocEiagSslv3 4cxpaXYT4QvljZMohAlmmIx5jAC3PdXy84wc6x8rhwfWEzwP+mWFIK/J4 auhslu31Woy38GdD71KJoCGjBK0rDrNT5incm3tfkDgRXiWmvRZm6JBsX cPemSsH9krJco+3LBvKfC2x+XhC/okGZP3LUxeuDUKfSFW19mHQYI0elo w==; X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="316575488" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="316575488" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 01:59:30 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10562"; a="627516636" X-IronPort-AV: E=Sophos;i="5.96,249,1665471600"; d="scan'208";a="627516636" Received: from xintongc-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.168.175]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Dec 2022 01:59:25 -0800 Date: Fri, 16 Dec 2022 17:59:22 +0800 From: Yu Zhang To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Aaron Lewis Subject: Re: [PATCH v2 0/4] KVM: nVMX: Fix 2nd exec controls override goofs Message-ID: <20221216095922.swvqp7olwr2rgpyc@linux.intel.com> References: <20221213062306.667649-1-seanjc@google.com> <20221214030037.4qz6v6fvfx6of32n@linux.intel.com> <20221215112436.2iqizpso5loeficn@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > They're definitely not too trivial. This is just an especially rough time of > year for reviews, e.g. end of year corporate stuff, merge window, holidays, etc. > Glad to know that. Thanks! > Part of why I haven't provided reviews is that the patches _aren't_ super trivial, > e.g. I'm on the fence on whether mmu_is_direct() should take @vcpu or @mmu, and if > I vote to have it take @mmu, then that'll conflict with mmu_is_nested(). So I end > up staying silent until I can come back to it with fresh eyes to see if there's a > better alternative, or if I'm just being nitpicky. > Well, though I would prefer mmu_is_direct(), I appreciate for being considerate. We can discuss it later. :) B.R. Yu