Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   <Tharunkumar.Pasumarthi@microchip.com>
To:     <andriy.shevchenko@linux.intel.com>
CC:     <Kumaravel.Thiagarajan@microchip.com>,
        <linux-kernel@vger.kernel.org>, <linux-serial@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <jirislaby@kernel.org>,
        <ilpo.jarvinen@linux.intel.com>, <macro@orcam.me.uk>,
        <cang1@live.co.uk>, <colin.i.king@gmail.com>,
        <phil.edworthy@renesas.com>, <biju.das.jz@bp.renesas.com>,
        <geert+renesas@glider.be>, <lukas@wunner.de>,
        <u.kleine-koenig@pengutronix.de>, <wander@redhat.com>,
        <etremblay@distech-controls.com>, <jk@ozlabs.org>,
        <UNGLinuxDriver@microchip.com>
Subject: RE: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support
Thread-Topic: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver for
 quad-uart support
Thread-Index: AQHZEKWxJyYrAeLM7kuV3hibr7zg+q5vN+wAgADGUpCAADCNgIAAEWGggAAC54CAAA3ukA==
Date:   Fri, 16 Dec 2022 10:31:38 +0000
Message-ID: <PH7PR11MB595883AB9234881B2CF362549BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
References: <20221216052656.2098100-1-kumaravel.thiagarajan@microchip.com>
 <20221216052656.2098100-3-kumaravel.thiagarajan@microchip.com>
 <Y5tciHzsEGU67h1Z@smile.fi.intel.com>
 <PH7PR11MB5958DF2284FDC67FA7018E9B9BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
 <Y5wrnzLMv5SCWPkn@smile.fi.intel.com>
 <PH7PR11MB5958956CB3DFD8E9B4A122379BE69@PH7PR11MB5958.namprd11.prod.outlook.com>
 <Y5w8o0vK7wuoX+yh@smile.fi.intel.com>
In-Reply-To: <Y5w8o0vK7wuoX+yh@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ByA9Lp97jLWTLpM1OWlems4KhEq1AeWkK37R5t7UcgaY1DUDilHcTkZdmXrB?=
 =?us-ascii?Q?c7ErEqfdfMMNP4duRbSkyD/F+i3p5TGq/u06xmGVJgGo2ZpHEqoVFKnqRgui?=
 =?us-ascii?Q?g3s+SopFb5Pvolq2V1pFNrmT+Rl+MuSGZ+lHbzV7GAyF0ICgmZ9NnCKMqb7D?=
 =?us-ascii?Q?JX48lPKuB33yEXXVddqBVadgZ5IdYtz22Ms6t/ysp9p6Pdni3uhwYmkz9Gkw?=
 =?us-ascii?Q?i+HgbyYFDmN3awOPTkdPNaIBtwHMTFZB0e7Rd/LAUHyFspIBMCJwGZNTPodh?=
 =?us-ascii?Q?tAbWCvYYPTQSOAnh51CpXm+4oEP5FUN4THBQcLXxBsdJ47CLUm1YQ17Iqk5o?=
 =?us-ascii?Q?+ZX5pbXNpvVGEa6FWmaaDSe48CmhH5Vb33d62Flt5vkh7rbSKm7A+4rGkrqN?=
 =?us-ascii?Q?riB7P2xiMVsSuf8MkqcdA5nOpsrKUxgn0douB76/uG/WLuZV7Ukc9YSkO31d?=
 =?us-ascii?Q?fQI6ER+Z4tLPMYwInIDpBJ0cU1uQwzLuW/4EY2kdS2pjegEs6jAM2b1Yq+vm?=
 =?us-ascii?Q?0AA7CF6TjW+tGR/SXS/rFSwTTK8+Eq0EAsFXge+G2gIu+FVfLcCanMtRDles?=
 =?us-ascii?Q?oZ/RsVdY9FWhC/lFEesn5rJ3D/Z7VtWpIMcdjJfNo3T5gcByT7l7LH9U8rlL?=
 =?us-ascii?Q?Vfi5wzh/8MYlNm+zjilTOLDCnJI6bMMK6ewVPDCBuXBwYqtQQyJxmT7L9zFt?=
 =?us-ascii?Q?uT4PzzW+vDM8Hp9NT5NgdL4nKZSVLD+/XGVgLpivmmggWjAvK1966qySWJHJ?=
 =?us-ascii?Q?CjK71m5axSuOQM4JKyEoD5zzeRpqXhauZZEN5kCSB1qUJSjalMwW5lwa7rC0?=
 =?us-ascii?Q?fWt5RtgHqQhn567Q8Jk5faHe6bj1GWehqrvpUpFDltDXrcl5HN7zOGyVPIeX?=
 =?us-ascii?Q?BrvFGCg+LUz2n1/I57Wf3NRmOazCPtkvR+jMh0xYmysd+6HjtSVKDdH01CQ5?=
 =?us-ascii?Q?uHoc3El4pwMPniYE8yA1+gv+V0eKjIqQV0xuSduKN96CGR9KtWpc/XesSX9v?=
 =?us-ascii?Q?k8m8yLFoomZ9/89hPUCV+6Q47+dTrgPaBdoF1lSlnQcG6roCgyFz0Qno8WyZ?=
 =?us-ascii?Q?KQ9zKZqOqBbvK2RBfph56rIsuTd9vRbE7+mYwuCVQ8cl6zeEnOcRSR0C7vkN?=
 =?us-ascii?Q?V3AHmxKNDGFT6sxmdd5/u58YjhekWC/foipDpkDFDGu7kF3Nv5421BtwDBHm?=
 =?us-ascii?Q?j07p0BsnBx4xADUpZjjQvXsEhxJT1l4/19s0CxrFvFv34ZL5PPukioXZf4h3?=
 =?us-ascii?Q?s4uYokOvdnzrRCdRNjS++tk0kb4X2y0lPZSfP1Mp8cdHQ7aQM6GAma0Q6N3N?=
 =?us-ascii?Q?KJ95p+beX2lHLuFYkNi0L+ttgq6+ym8GSUNLGecz5ikAhTv/hKQ7BC1u32w/?=
 =?us-ascii?Q?LQvXQ5Rfu1+YZnVgrTY+vZbAyd0107wZasRQMaBnW/KHpTweXf9vCggizscH?=
 =?us-ascii?Q?II8Gi6KMaNQ/lsooJE0GWhkTHy87t4GDHJ24W2I09nX7Z3TYzrso4gSvroRY?=
 =?us-ascii?Q?Fm9E3mJbLTF/5gZPSyp1l0Ls5I4qbstpJMHSc550u73mvNXHlxcigftBj3VZ?=
 =?us-ascii?Q?FmMkeKUZMj7tE1PYuO2jBrAc32ud+haDcSmr48CthoRPwQMw+ky73b2SnbDH?=
 =?us-ascii?Q?Vv5Q39yFuSYmy3OU9+Su/Z4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5958.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c07726a1-7544-4781-ae19-08dadf50b6da
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2022 10:31:38.4040
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NReoC5g4/xW9L50XVq8psF4xpzdSjtgcLNVfnN9y4ZfPWIt5O8l80A5BAMx5sNIPcPrMMTpoCU+5iUGSvY6NSOcOLcYS9QRVUhkkZrjknzBtGjeqTbaCwOgXhu63i4cq
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7787
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Friday, December 16, 2022 3:09 PM
> To: Tharunkumar Pasumarthi - I67821
> <Tharunkumar.Pasumarthi@microchip.com>
> Subject: Re: [PATCH v9 tty-next 2/4] serial: 8250_pci1xxxx: Add driver fo=
r
> quad-uart support
>=20
> > From this sequence, it seemed like, kernel takes care of freeing irq
> > and calling pci_free_irq_vectors is not required.
>=20
> Technically you are correct, but... read this discussion, and pay attenti=
on to
> what Christoph said there:
>=20
> https://lore.kernel.org/linux-serial/0250c46e-da6c-71f3-50ae-
> b7c17fd0bd2c@siemens.com/

Okay, got it. Will use pci_free_irq_vectors.=20
Also, do you suggest using pci_enable_device instead of pcim_enable_device =
(to maintain consistency
of using non managed APIs throughout driver)?

Thanks,
Tharun Kumar P