Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6b971a4e-c7d8-411e-1f92-fda29b5b2fb9@kernel.org>
Date:   Fri, 16 Dec 2022 11:49:01 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PULL] Networking for next-6.1
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, pabeni@redhat.com,
        joannelkoong@gmail.com
References: <20221004052000.2645894-1-kuba@kernel.org>
From:   Jiri Slaby <jirislaby@kernel.org>
In-Reply-To: <20221004052000.2645894-1-kuba@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 04. 10. 22, 7:20, Jakub Kicinski wrote:
> Joanne Koong (7):

>        net: Add a bhash2 table hashed by port and address

This makes regression tests of python-ephemeral-port-reserve to fail.

I'm not sure if the issue is in the commit or in the test.

This C reproducer used to fail with 6.0, now it succeeds:
#include <err.h>
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>

#include <sys/socket.h>

#include <arpa/inet.h>
#include <netinet/ip.h>

int main()
{
         int x;
         int s1 = socket(AF_INET, SOCK_STREAM|SOCK_CLOEXEC, IPPROTO_IP);
         if (s1 < 0)
                 err(1, "sock1");
         x = 1;
         if (setsockopt(s1, SOL_SOCKET, SO_REUSEADDR, &x, sizeof(x)))
                 err(1, "setsockopt1");

         struct sockaddr_in in = {
                 .sin_family = AF_INET,
                 .sin_port = INADDR_ANY,
                 .sin_addr = { htonl(INADDR_LOOPBACK) },
         };
         if (bind(s1, (const struct sockaddr *)&in, sizeof(in)) < 0)
                 err(1, "bind1");

         if (listen(s1, 1) < 0)
                 err(1, "listen1");

         socklen_t inl = sizeof(in);
         if (getsockname(s1, (struct sockaddr *)&in, &inl) < 0)
                 err(1, "getsockname1");

         int s2 = socket(AF_INET, SOCK_STREAM|SOCK_CLOEXEC, IPPROTO_IP);
         if (s1 < 0)
                 err(1, "sock2");

         if (connect(s2, (struct sockaddr *)&in, inl) < 0)
                 err(1, "conn2");

         struct sockaddr_in acc;
         inl = sizeof(acc);
         int fdX = accept(s1, (struct sockaddr *)&acc, &inl);
         if (fdX < 0)
                 err(1, "accept");

         close(fdX);
         close(s2);
         close(s1);

         int s3 = socket(AF_INET, SOCK_STREAM|SOCK_CLOEXEC, IPPROTO_IP);
         if (s3 < 0)
                 err(1, "sock3");

         if (bind(s3, (struct sockaddr *)&in, sizeof(in)) < 0)
                 err(1, "bind3");

         close(s3);

         return 0;
}


thanks,
-- 
js
suse labs